From: "Jörn Engel" <joern@purestorage.com> To: dingtianhong <dingtianhong@huawei.com>, Jay Vosburgh <fubar@us.ibm.com>, "David S. Miller" <davem@davemloft.net> Cc: linux-kernel@vger.kernel.org, Veaceslav Falico <vfalico@redhat.com>, Andy Gospodarek <andy@greyhouse.net>, stable@vger.kernel.org Subject: [Regression] Bonding no longer support tun-interfaces Date: Mon, 8 Aug 2016 14:15:30 -0700 [thread overview] Message-ID: <20160808211530.GH22974@cork> (raw) This has been reported (and ignored) before: http://lkml.iu.edu/hypermail/linux/kernel/1407.2/03790.html https://bugzilla.kernel.org/show_bug.cgi?id=89161 Regression was introduced by: commit 00503b6f702e (refs/bisect/bad) Author: dingtianhong <dingtianhong@huawei.com> Date: Sat Jan 25 13:00:29 2014 +0800 bonding: fail_over_mac should only affect AB mode at enslave and removal processing According to bonding.txt, the fail_over_ma should only affect active-backup mode, but I found that the fail_over_mac could be set to active or follow in all modes, this will cause new slave could not be set to bond's MAC address at enslave processing and restore its own MAC address at removal processing. The correct way to fix the problem is that we should not add restrictions when setting options, just need to modify the bond enslave and removal processing to check the mode in addition to fail_over_mac when setting a slave's MAC during enslavement. The change active slave processing already only calls the fail_over_mac function when in active-backup mode. Thanks for Jay's suggestion. The patch also modify the pr_warning() to pr_warn(). Cc: Jay Vosburgh <fubar@us.ibm.com> Cc: Veaceslav Falico <vfalico@redhat.com> Cc: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Since I never needed bonding or tun-interfaces before, I come late to the party. Some 6k lines have changed in the bonding driver since the regression got in two years ago. So a simple revert is unlikely to lead to happiness. But I absolutely need that functionality and would rather run a 3.13 kernel than live with the regression. dingtianhong, any suggestions? Jörn -- It is a cliché that most clichés are true, but then, like most clichés, that cliché is untrue. -- Stephen Fry
WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@purestorage.com> To: dingtianhong <dingtianhong@huawei.com>, Jay Vosburgh <fubar@us.ibm.com>, "David S. Miller" <davem@davemloft.net> Cc: linux-kernel@vger.kernel.org, Veaceslav Falico <vfalico@redhat.com>, Andy Gospodarek <andy@greyhouse.net>, stable@vger.kernel.org Subject: [Regression] Bonding no longer support tun-interfaces Date: Mon, 8 Aug 2016 14:15:30 -0700 [thread overview] Message-ID: <20160808211530.GH22974@cork> (raw) This has been reported (and ignored) before: http://lkml.iu.edu/hypermail/linux/kernel/1407.2/03790.html https://bugzilla.kernel.org/show_bug.cgi?id=89161 Regression was introduced by: commit 00503b6f702e (refs/bisect/bad) Author: dingtianhong <dingtianhong@huawei.com> Date: Sat Jan 25 13:00:29 2014 +0800 bonding: fail_over_mac should only affect AB mode at enslave and removal processing According to bonding.txt, the fail_over_ma should only affect active-backup mode, but I found that the fail_over_mac could be set to active or follow in all modes, this will cause new slave could not be set to bond's MAC address at enslave processing and restore its own MAC address at removal processing. The correct way to fix the problem is that we should not add restrictions when setting options, just need to modify the bond enslave and removal processing to check the mode in addition to fail_over_mac when setting a slave's MAC during enslavement. The change active slave processing already only calls the fail_over_mac function when in active-backup mode. Thanks for Jay's suggestion. The patch also modify the pr_warning() to pr_warn(). Cc: Jay Vosburgh <fubar@us.ibm.com> Cc: Veaceslav Falico <vfalico@redhat.com> Cc: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net> Since I never needed bonding or tun-interfaces before, I come late to the party. Some 6k lines have changed in the bonding driver since the regression got in two years ago. So a simple revert is unlikely to lead to happiness. But I absolutely need that functionality and would rather run a 3.13 kernel than live with the regression. dingtianhong, any suggestions? J�rn -- It is a clich� that most clich�s are true, but then, like most clich�s, that clich� is untrue. -- Stephen Fry
next reply other threads:[~2016-08-08 21:15 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-08 21:15 Jörn Engel [this message] 2016-08-08 21:15 ` [Regression] Bonding no longer support tun-interfaces Jörn Engel 2016-08-08 21:17 ` David Miller 2016-08-08 21:21 ` Jörn Engel 2016-08-08 21:48 ` [PATCH] bonding: Allow tun-interfaces as slaves Jörn Engel 2016-08-09 2:18 ` Ding Tianhong 2016-08-09 3:09 ` Jörn Engel 2016-08-09 5:29 ` zhuyj 2016-08-09 13:28 ` Ding Tianhong 2016-08-09 18:08 ` Jörn Engel 2016-08-09 19:06 ` David Miller 2016-08-09 21:10 ` Jörn Engel 2016-08-09 23:51 ` Jay Vosburgh 2016-08-10 1:06 ` Ding Tianhong 2016-08-10 9:27 ` Ding Tianhong 2016-08-10 17:41 ` Jay Vosburgh 2016-08-11 1:20 ` Ding Tianhong 2016-08-10 21:26 ` Jörn Engel 2016-08-10 22:00 ` Jörn Engel 2016-08-11 0:58 ` Jay Vosburgh 2016-08-11 1:37 ` Ding Tianhong 2016-08-11 18:24 ` Jörn Engel 2016-08-29 22:49 ` Jörn Engel 2016-08-30 1:44 ` Ding Tianhong 2016-08-09 5:52 ` Ding Tianhong 2016-08-09 18:21 ` Jay Vosburgh 2016-08-09 18:40 ` Jörn Engel 2016-08-09 19:10 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160808211530.GH22974@cork \ --to=joern@purestorage.com \ --cc=andy@greyhouse.net \ --cc=davem@davemloft.net \ --cc=dingtianhong@huawei.com \ --cc=fubar@us.ibm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=stable@vger.kernel.org \ --cc=vfalico@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.