From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eryu Guan <eguan@redhat.com>,
linux-btrfs@vger.kernel.org, fstests@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH 13/17] xfs: test swapext with reflink
Date: Tue, 9 Aug 2016 16:29:43 +1000 [thread overview]
Message-ID: <20160809062943.GF19025@dastard> (raw)
In-Reply-To: <20160808174132.GC11291@birch.djwong.org>
On Mon, Aug 08, 2016 at 10:41:32AM -0700, Darrick J. Wong wrote:
> On Mon, Aug 08, 2016 at 04:13:59PM +0800, Eryu Guan wrote:
> > On Thu, Jul 21, 2016 at 04:47:38PM -0700, Darrick J. Wong wrote:
> > > Add a few tests to stress the new swapext code for reflink and rmap.
> > > +_reflink_range "$testdir/file1" 0 "$testdir/file2" 0 $bytes >> "$seqres.full"
> > > +
> > > +echo "Defrag the big file"
> > > +old_nextents=$(xfs_io -c 'stat -v' $testdir/file1 | grep 'nextents' | cut -d ' ' -f 3)
> >
> > There's a "_count_extents" helper, does that work for this case?
>
> It can, though stat -v reports GETFSXATTR results, which should be faster than
> _count_extents because the latter FIEMAPs the entire file and counts lines.
> Seeing as XFS records the extent count in the inode, we might as well use it.
perhaps put a special xfs case in _count_extents() that does this
rather than FIEMAP?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 13/17] xfs: test swapext with reflink
Date: Tue, 9 Aug 2016 16:29:43 +1000 [thread overview]
Message-ID: <20160809062943.GF19025@dastard> (raw)
In-Reply-To: <20160808174132.GC11291@birch.djwong.org>
On Mon, Aug 08, 2016 at 10:41:32AM -0700, Darrick J. Wong wrote:
> On Mon, Aug 08, 2016 at 04:13:59PM +0800, Eryu Guan wrote:
> > On Thu, Jul 21, 2016 at 04:47:38PM -0700, Darrick J. Wong wrote:
> > > Add a few tests to stress the new swapext code for reflink and rmap.
> > > +_reflink_range "$testdir/file1" 0 "$testdir/file2" 0 $bytes >> "$seqres.full"
> > > +
> > > +echo "Defrag the big file"
> > > +old_nextents=$(xfs_io -c 'stat -v' $testdir/file1 | grep 'nextents' | cut -d ' ' -f 3)
> >
> > There's a "_count_extents" helper, does that work for this case?
>
> It can, though stat -v reports GETFSXATTR results, which should be faster than
> _count_extents because the latter FIEMAPs the entire file and counts lines.
> Seeing as XFS records the extent count in the inode, we might as well use it.
perhaps put a special xfs case in _count_extents() that does this
rather than FIEMAP?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-08-09 6:29 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 23:46 [PATCH v7 00/17] xfstests: fixes and new tests for rmap/reflink/etc Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-07-21 23:46 ` [PATCH 01/17] xfs/26[34]: remove duplicate tests Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:25 ` Christoph Hellwig
2016-08-01 6:25 ` Christoph Hellwig
2016-07-21 23:46 ` [PATCH 02/17] xfs: use rmapbt-checking helper Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:25 ` Christoph Hellwig
2016-08-01 6:25 ` Christoph Hellwig
2016-07-21 23:46 ` [PATCH 03/17] xfs/310: fix the size calculation for the huge device Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:25 ` Christoph Hellwig
2016-08-01 6:25 ` Christoph Hellwig
2016-07-21 23:46 ` [PATCH 04/17] xfs/122: list the new log redo items Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:26 ` Christoph Hellwig
2016-08-01 6:26 ` Christoph Hellwig
2016-07-21 23:46 ` [PATCH 05/17] common/reflink: actually test dedupe on scratch device Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:26 ` Christoph Hellwig
2016-08-01 6:26 ` Christoph Hellwig
2016-07-21 23:46 ` [PATCH 06/17] xfs: run xfs_repair at the end of each test Darrick J. Wong
2016-07-21 23:46 ` Darrick J. Wong
2016-08-01 6:27 ` Christoph Hellwig
2016-08-01 6:27 ` Christoph Hellwig
2016-08-01 17:08 ` Darrick J. Wong
2016-08-01 17:08 ` Darrick J. Wong
2016-08-02 12:24 ` Christoph Hellwig
2016-08-02 12:24 ` Christoph Hellwig
2016-08-03 9:15 ` Eryu Guan
2016-08-03 9:15 ` Eryu Guan
2016-08-03 22:08 ` Darrick J. Wong
2016-08-03 22:08 ` Darrick J. Wong
2016-08-03 22:45 ` [PATCH v2 06/17] xfs: optionally test xfs_repair index rebuilding " Darrick J. Wong
2016-08-03 22:45 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 07/17] xfs/128: cycle_mount the scratch device, not the test device Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:27 ` Christoph Hellwig
2016-08-01 6:27 ` Christoph Hellwig
2016-08-03 9:37 ` Eryu Guan
2016-08-03 9:37 ` Eryu Guan
2016-08-03 22:09 ` Darrick J. Wong
2016-08-03 22:09 ` Darrick J. Wong
2016-08-03 22:48 ` [PATCH v2 " Darrick J. Wong
2016-08-03 22:48 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 08/17] xfs/129: fix post-metadump remounting idiocy Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:27 ` Christoph Hellwig
2016-08-01 6:27 ` Christoph Hellwig
2016-07-21 23:47 ` [PATCH 09/17] common/dmerror: fix mount option issues Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:28 ` Christoph Hellwig
2016-08-01 6:28 ` Christoph Hellwig
2016-08-03 10:38 ` Eryu Guan
2016-08-03 10:38 ` Eryu Guan
2016-08-03 22:14 ` Darrick J. Wong
2016-08-03 22:14 ` Darrick J. Wong
2016-08-03 22:50 ` [PATCH v2 " Darrick J. Wong
2016-08-03 22:50 ` Darrick J. Wong
2016-08-04 0:33 ` Darrick J. Wong
2016-08-04 0:33 ` Darrick J. Wong
2016-08-04 0:34 ` [PATCH v3 " Darrick J. Wong
2016-08-04 0:34 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 10/17] xfs/179: use scratch device helpers Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:28 ` Christoph Hellwig
2016-08-01 6:28 ` Christoph Hellwig
2016-07-21 23:47 ` [PATCH 11/17] xfs/234: " Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:29 ` Christoph Hellwig
2016-08-01 6:29 ` Christoph Hellwig
2016-07-21 23:47 ` [PATCH 12/17] reflink: test cross-mountpoint reflink and dedupe Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-01 6:29 ` Christoph Hellwig
2016-08-01 6:29 ` Christoph Hellwig
2016-08-08 7:56 ` Eryu Guan
2016-08-08 7:56 ` Eryu Guan
2016-08-08 17:28 ` Darrick J. Wong
2016-08-08 17:28 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 13/17] xfs: test swapext with reflink Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-08 8:13 ` Eryu Guan
2016-08-08 8:13 ` Eryu Guan
2016-08-08 17:41 ` Darrick J. Wong
2016-08-08 17:41 ` Darrick J. Wong
2016-08-09 6:29 ` Dave Chinner [this message]
2016-08-09 6:29 ` Dave Chinner
2016-08-19 21:53 ` Darrick J. Wong
2016-08-19 21:53 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 14/17] xfs: more rmapbt tests Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-08 8:48 ` Eryu Guan
2016-08-08 8:48 ` Eryu Guan
2016-08-08 17:59 ` Darrick J. Wong
2016-08-08 17:59 ` Darrick J. Wong
2016-07-21 23:47 ` [PATCH 15/17] xfs: scrub fs (if still mounted) at the end of the test Darrick J. Wong
2016-07-21 23:47 ` Darrick J. Wong
2016-08-08 8:52 ` Eryu Guan
2016-08-08 8:52 ` Eryu Guan
2016-08-08 18:03 ` Darrick J. Wong
2016-08-08 18:03 ` Darrick J. Wong
2016-07-21 23:48 ` [PATCH 16/17] xfs/122: add the realtime rmapbt inode and btree fields Darrick J. Wong
2016-07-21 23:48 ` Darrick J. Wong
2016-08-01 6:30 ` Christoph Hellwig
2016-08-01 6:30 ` Christoph Hellwig
2016-07-21 23:48 ` [PATCH 17/17] xfs: test realtime rmapbt code Darrick J. Wong
2016-07-21 23:48 ` Darrick J. Wong
2016-08-08 9:08 ` Eryu Guan
2016-08-08 9:08 ` Eryu Guan
2016-08-08 18:18 ` Darrick J. Wong
2016-08-08 18:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809062943.GF19025@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.