* [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function @ 2016-08-13 1:50 Stephen Boyd 2016-08-13 1:50 ` [PATCH 2/2] clk: fixed-rate: " Stephen Boyd 2016-08-15 22:08 ` [PATCH 1/2] clk: fixed-factor: " Stephen Boyd 0 siblings, 2 replies; 7+ messages in thread From: Stephen Boyd @ 2016-08-13 1:50 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd; +Cc: linux-kernel, linux-clk, Gregory CLEMENT This function is marked __init, so it can't possibly need to be exported to modules. Remove the marking. Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/clk/clk-fixed-factor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c index 070d0d75da97..a5d402de5584 100644 --- a/drivers/clk/clk-fixed-factor.c +++ b/drivers/clk/clk-fixed-factor.c @@ -196,7 +196,6 @@ void __init of_fixed_factor_clk_setup(struct device_node *node) { _of_fixed_factor_clk_setup(node); } -EXPORT_SYMBOL_GPL(of_fixed_factor_clk_setup); CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock", of_fixed_factor_clk_setup); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function 2016-08-13 1:50 [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function Stephen Boyd @ 2016-08-13 1:50 ` Stephen Boyd 2016-08-15 22:08 ` Stephen Boyd 2016-08-16 12:24 ` Geert Uytterhoeven 2016-08-15 22:08 ` [PATCH 1/2] clk: fixed-factor: " Stephen Boyd 1 sibling, 2 replies; 7+ messages in thread From: Stephen Boyd @ 2016-08-13 1:50 UTC (permalink / raw) To: Michael Turquette, Stephen Boyd; +Cc: linux-kernel, linux-clk, Denis Efremov This function is only called by builtin code, but we always exported it and had marked it as __init before commit e4eda8e0654c (clk: remove exported function from __init section, 2013-01-06) removed that marking. Given that it isn't used by modules, lets unexport it and add back __init. Cc: Denis Efremov <yefremov.denis@gmail.com> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/clk/clk-fixed-rate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c index c735272ed706..b5c46b3f8764 100644 --- a/drivers/clk/clk-fixed-rate.c +++ b/drivers/clk/clk-fixed-rate.c @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node) /** * of_fixed_clk_setup() - Setup function for simple fixed rate clock */ -void of_fixed_clk_setup(struct device_node *node) +void __init of_fixed_clk_setup(struct device_node *node) { _of_fixed_clk_setup(node); } -EXPORT_SYMBOL_GPL(of_fixed_clk_setup); CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); static int of_fixed_clk_remove(struct platform_device *pdev) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function 2016-08-13 1:50 ` [PATCH 2/2] clk: fixed-rate: " Stephen Boyd @ 2016-08-15 22:08 ` Stephen Boyd 2016-08-16 12:24 ` Geert Uytterhoeven 1 sibling, 0 replies; 7+ messages in thread From: Stephen Boyd @ 2016-08-15 22:08 UTC (permalink / raw) To: Michael Turquette; +Cc: linux-kernel, linux-clk, Denis Efremov On 08/12, Stephen Boyd wrote: > This function is only called by builtin code, but we always > exported it and had marked it as __init before commit > e4eda8e0654c (clk: remove exported function from __init section, > 2013-01-06) removed that marking. Given that it isn't used by > modules, lets unexport it and add back __init. > > Cc: Denis Efremov <yefremov.denis@gmail.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function 2016-08-13 1:50 ` [PATCH 2/2] clk: fixed-rate: " Stephen Boyd 2016-08-15 22:08 ` Stephen Boyd @ 2016-08-16 12:24 ` Geert Uytterhoeven 2016-08-16 17:31 ` Stephen Boyd 1 sibling, 1 reply; 7+ messages in thread From: Geert Uytterhoeven @ 2016-08-16 12:24 UTC (permalink / raw) To: Stephen Boyd; +Cc: Michael Turquette, linux-kernel, linux-clk, Denis Efremov Hi Stephen, On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > This function is only called by builtin code, but we always > exported it and had marked it as __init before commit > e4eda8e0654c (clk: remove exported function from __init section, > 2013-01-06) removed that marking. Given that it isn't used by > modules, lets unexport it and add back __init. > > Cc: Denis Efremov <yefremov.denis@gmail.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/clk/clk-fixed-rate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c > index c735272ed706..b5c46b3f8764 100644 > --- a/drivers/clk/clk-fixed-rate.c > +++ b/drivers/clk/clk-fixed-rate.c > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node) > /** > * of_fixed_clk_setup() - Setup function for simple fixed rate clock > */ > -void of_fixed_clk_setup(struct device_node *node) > +void __init of_fixed_clk_setup(struct device_node *node) > { > _of_fixed_clk_setup(node); > } > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup); > CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); This function is needed to instantiate clocks from DT overlays, which I'm using with out-of-tree "clk: add generic driver for fixed rate clock". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function 2016-08-16 12:24 ` Geert Uytterhoeven @ 2016-08-16 17:31 ` Stephen Boyd 2016-08-17 20:24 ` Geert Uytterhoeven 0 siblings, 1 reply; 7+ messages in thread From: Stephen Boyd @ 2016-08-16 17:31 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Michael Turquette, linux-kernel, linux-clk, Denis Efremov On 08/16, Geert Uytterhoeven wrote: > Hi Stephen, > > On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > > This function is only called by builtin code, but we always > > exported it and had marked it as __init before commit > > e4eda8e0654c (clk: remove exported function from __init section, > > 2013-01-06) removed that marking. Given that it isn't used by > > modules, lets unexport it and add back __init. > > > > Cc: Denis Efremov <yefremov.denis@gmail.com> > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > > --- > > drivers/clk/clk-fixed-rate.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c > > index c735272ed706..b5c46b3f8764 100644 > > --- a/drivers/clk/clk-fixed-rate.c > > +++ b/drivers/clk/clk-fixed-rate.c > > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node) > > /** > > * of_fixed_clk_setup() - Setup function for simple fixed rate clock > > */ > > -void of_fixed_clk_setup(struct device_node *node) > > +void __init of_fixed_clk_setup(struct device_node *node) > > { > > _of_fixed_clk_setup(node); > > } > > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup); > > CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); > > This function is needed to instantiate clocks from DT overlays, > which I'm using with out-of-tree "clk: add generic driver for fixed rate clock". > I think Ricardo's latest series should make that work for you with platform device drivers? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] clk: fixed-rate: Remove export symbol on setup function 2016-08-16 17:31 ` Stephen Boyd @ 2016-08-17 20:24 ` Geert Uytterhoeven 0 siblings, 0 replies; 7+ messages in thread From: Geert Uytterhoeven @ 2016-08-17 20:24 UTC (permalink / raw) To: Stephen Boyd; +Cc: Michael Turquette, linux-kernel, linux-clk, Denis Efremov Hi Stephen, On Tue, Aug 16, 2016 at 7:31 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 08/16, Geert Uytterhoeven wrote: >> On Sat, Aug 13, 2016 at 3:50 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> > This function is only called by builtin code, but we always >> > exported it and had marked it as __init before commit >> > e4eda8e0654c (clk: remove exported function from __init section, >> > 2013-01-06) removed that marking. Given that it isn't used by >> > modules, lets unexport it and add back __init. >> > >> > Cc: Denis Efremov <yefremov.denis@gmail.com> >> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> >> > --- >> > drivers/clk/clk-fixed-rate.c | 3 +-- >> > 1 file changed, 1 insertion(+), 2 deletions(-) >> > >> > diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c >> > index c735272ed706..b5c46b3f8764 100644 >> > --- a/drivers/clk/clk-fixed-rate.c >> > +++ b/drivers/clk/clk-fixed-rate.c >> > @@ -190,11 +190,10 @@ static struct clk *_of_fixed_clk_setup(struct device_node *node) >> > /** >> > * of_fixed_clk_setup() - Setup function for simple fixed rate clock >> > */ >> > -void of_fixed_clk_setup(struct device_node *node) >> > +void __init of_fixed_clk_setup(struct device_node *node) >> > { >> > _of_fixed_clk_setup(node); >> > } >> > -EXPORT_SYMBOL_GPL(of_fixed_clk_setup); >> > CLK_OF_DECLARE(fixed_clk, "fixed-clock", of_fixed_clk_setup); >> >> This function is needed to instantiate clocks from DT overlays, >> which I'm using with out-of-tree "clk: add generic driver for fixed rate clock". > > I think Ricardo's latest series should make that work for you > with platform device drivers? Thanks, I had missed that series. Ah, that one calls _of_fixed_clk_setup() instead, which should still work. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function 2016-08-13 1:50 [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function Stephen Boyd 2016-08-13 1:50 ` [PATCH 2/2] clk: fixed-rate: " Stephen Boyd @ 2016-08-15 22:08 ` Stephen Boyd 1 sibling, 0 replies; 7+ messages in thread From: Stephen Boyd @ 2016-08-15 22:08 UTC (permalink / raw) To: Michael Turquette; +Cc: linux-kernel, linux-clk, Gregory CLEMENT On 08/12, Stephen Boyd wrote: > This function is marked __init, so it can't possibly need to be > exported to modules. Remove the marking. > > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-17 20:25 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-08-13 1:50 [PATCH 1/2] clk: fixed-factor: Remove export symbol on setup function Stephen Boyd 2016-08-13 1:50 ` [PATCH 2/2] clk: fixed-rate: " Stephen Boyd 2016-08-15 22:08 ` Stephen Boyd 2016-08-16 12:24 ` Geert Uytterhoeven 2016-08-16 17:31 ` Stephen Boyd 2016-08-17 20:24 ` Geert Uytterhoeven 2016-08-15 22:08 ` [PATCH 1/2] clk: fixed-factor: " Stephen Boyd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.