All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk>
Cc: Chen-Yu Tsai <wens@csie.org>, Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Rob Herring <robh+dt@kernel.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Mon, 22 Aug 2016 19:09:32 +0100	[thread overview]
Message-ID: <20160822180932.GW22076@sirena.org.uk> (raw)
In-Reply-To: <20160822175205.h76hurjaopnosymc@vip.cybercity.dk>

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote:
> On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote:

> > This seems like you have buggy constraints, constraints which allow
> > voltages that can't physically be satisfied don't make obvious sense.

> No, it's for cases like this (see the cubietruck4 or a80-optimus dts
> patches):

> 			reg_bldo4: bldo4 {
> 				regulator-min-microvolt = <1080000>;
> 				regulator-max-microvolt = <1320000>;
> 				regulator-name = "vcc12-hsic";
> 			};

> The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which
> are within the constraints, so obviously the constraints can be satisfied,
> yet the regulator core fails do so with a message like this:

Sure, but the constraints also say that you can do 1.32V which the
system is not physically capable of delivering.  That's not a good sign
for the constraints, it suggests that at least the capabilities of the
regulator have not been taken into consideration when setting up the
constraints.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Rask Ingemann Lambertsen
	<ccc94453-1EA3ORoCGBhoJ7GROcy7lA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Mon, 22 Aug 2016 19:09:32 +0100	[thread overview]
Message-ID: <20160822180932.GW22076@sirena.org.uk> (raw)
In-Reply-To: <20160822175205.h76hurjaopnosymc-1EA3ORoCGBhoJ7GROcy7lA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote:
> On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote:

> > This seems like you have buggy constraints, constraints which allow
> > voltages that can't physically be satisfied don't make obvious sense.

> No, it's for cases like this (see the cubietruck4 or a80-optimus dts
> patches):

> 			reg_bldo4: bldo4 {
> 				regulator-min-microvolt = <1080000>;
> 				regulator-max-microvolt = <1320000>;
> 				regulator-name = "vcc12-hsic";
> 			};

> The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which
> are within the constraints, so obviously the constraints can be satisfied,
> yet the regulator core fails do so with a message like this:

Sure, but the constraints also say that you can do 1.32V which the
system is not physically capable of delivering.  That's not a good sign
for the constraints, it suggests that at least the capabilities of the
regulator have not been taken into consideration when setting up the
constraints.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints
Date: Mon, 22 Aug 2016 19:09:32 +0100	[thread overview]
Message-ID: <20160822180932.GW22076@sirena.org.uk> (raw)
In-Reply-To: <20160822175205.h76hurjaopnosymc@vip.cybercity.dk>

On Mon, Aug 22, 2016 at 07:52:05PM +0200, Rask Ingemann Lambertsen wrote:
> On Mon, Aug 22, 2016 at 05:29:07PM +0100, Mark Brown wrote:

> > This seems like you have buggy constraints, constraints which allow
> > voltages that can't physically be satisfied don't make obvious sense.

> No, it's for cases like this (see the cubietruck4 or a80-optimus dts
> patches):

> 			reg_bldo4: bldo4 {
> 				regulator-min-microvolt = <1080000>;
> 				regulator-max-microvolt = <1320000>;
> 				regulator-name = "vcc12-hsic";
> 			};

> The regulator can do 1100000 uV, 1200000 uV and 1300000 uV, all of which
> are within the constraints, so obviously the constraints can be satisfied,
> yet the regulator core fails do so with a message like this:

Sure, but the constraints also say that you can do 1.32V which the
system is not physically capable of delivering.  That's not a good sign
for the constraints, it suggests that at least the capabilities of the
regulator have not been taken into consideration when setting up the
constraints.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160822/7f58a619/attachment.sig>

  reply	other threads:[~2016-08-22 18:09 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-21  2:11 [PATCH 0/9] mfd: axp20x: Add support for AXP809 PMIC Chen-Yu Tsai
2016-08-21  2:11 ` Chen-Yu Tsai
2016-08-21  2:11 ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 1/9] mfd: axp20x: Add bindings for AXP806 PMIC Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-23 17:51   ` Rob Herring
2016-08-23 17:51     ` Rob Herring
2016-08-23 17:51     ` Rob Herring
2016-08-21  2:11 ` [PATCH 2/9] mfd: axp20x: Add support " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  4:15   ` [linux-sunxi] " Julian Calaby
2016-08-21  4:15     ` Julian Calaby
2016-08-21  4:15     ` Julian Calaby
2016-08-21  2:11 ` [PATCH 3/9] regulator: core: Try full range when adjusting regulators to constraints Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-22 16:29   ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 17:52     ` Rask Ingemann Lambertsen
2016-08-22 17:52       ` Rask Ingemann Lambertsen
2016-08-22 18:09       ` Mark Brown [this message]
2016-08-22 18:09         ` Mark Brown
2016-08-22 18:09         ` Mark Brown
2016-08-23  4:17         ` Chen-Yu Tsai
2016-08-23  4:17           ` Chen-Yu Tsai
2016-08-23  4:17           ` Chen-Yu Tsai
2016-08-23 10:40           ` Mark Brown
2016-08-23 10:40             ` Mark Brown
2016-08-23 10:40             ` Mark Brown
2016-08-22 16:29   ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-22 16:29     ` Mark Brown
2016-08-21  2:11 ` [PATCH 4/9] regulator: axp20x: support AXP806 variant Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-22 16:52   ` Mark Brown
2016-08-22 16:52     ` Mark Brown
2016-08-22 16:52     ` Mark Brown
2016-08-21  2:11 ` [PATCH 5/9] ARM: dts: sun9i: a80-optimus: Declare AXP809 SW regulator as unused Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 6/9] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 7/9] ARM: dts: sun9i: a80-optimus: Add AXP806 PMIC device node and regulators Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 8/9] ARM: dts: sun9i: cubieboard4: " Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11 ` [PATCH 9/9] ARM: dts: sun9i: a80-optimus: Disable EHCI1 Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  2:11   ` Chen-Yu Tsai
2016-08-21  6:51 ` [linux-sunxi] [PATCH 0/9] mfd: axp20x: Add support for AXP809 PMIC Priit Laes
2016-08-21  6:51   ` Priit Laes
2016-08-21  6:51   ` Priit Laes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160822180932.GW22076@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=ccc94453@vip.cybercity.dk \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.