All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Restore lost "Initialized i915" welcome message
@ 2016-08-25  7:23 Chris Wilson
  2016-08-25  7:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
  2016-08-25  7:51 ` [PATCH] " Daniel Vetter
  0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2016-08-25  7:23 UTC (permalink / raw)
  To: intel-gfx; +Cc: Daniel Vetter, drm-intel-fixes

A side effect of removing the midlayer from driver loading was the loss
of a useful message announcing to userspace that i915 had successfully
started, e.g.:

	[drm] Initialized i915 1.6.0 20160425 for 0000:00:02.0 on minor 0

Reported-by:  Timo Aaltonen <tjaalton@ubuntu.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Fixes: 8f460e2c78f2 ("drm/i915: Demidlayer driver loading")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: drm-intel-fixes@lists.freedesktop.org
---
 drivers/gpu/drm/i915/i915_drv.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6db1869e2c97..01757369d2d4 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1263,6 +1263,11 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	intel_runtime_pm_enable(dev_priv);
 
+	/* Everything is in place, we can now relax! */
+	DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
+		 driver.name, driver.major, driver.minor, driver.patchlevel,
+		 driver.date, pci_name(pdev), dev_priv->drm.primary->index);
+
 	intel_runtime_pm_put(dev_priv);
 
 	return 0;
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✗ Fi.CI.BAT: failure for drm/i915: Restore lost "Initialized i915" welcome message
  2016-08-25  7:23 [PATCH] drm/i915: Restore lost "Initialized i915" welcome message Chris Wilson
@ 2016-08-25  7:50 ` Patchwork
  2016-08-25  7:51 ` [PATCH] " Daniel Vetter
  1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-08-25  7:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Restore lost "Initialized i915" welcome message
URL   : https://patchwork.freedesktop.org/series/11550/
State : failure

== Summary ==

Series 11550v1 drm/i915: Restore lost "Initialized i915" welcome message
http://patchwork.freedesktop.org/api/1.0/series/11550/revisions/1/mbox/

Test drv_module_reload_basic:
                pass       -> SKIP       (fi-ivb-3520m)
Test gem_ringfill:
        Subgroup basic-default-forked:
                dmesg-warn -> PASS       (fi-snb-2520m)
        Subgroup basic-default-hang:
                pass       -> DMESG-WARN (fi-snb-2520m)
Test kms_cursor_legacy:
        Subgroup basic-cursor-vs-flip-legacy:
                pass       -> FAIL       (fi-bsw-n3050)
        Subgroup basic-cursor-vs-flip-varying-size:
                fail       -> PASS       (fi-bsw-n3050)
        Subgroup basic-flip-vs-cursor-legacy:
                fail       -> PASS       (fi-bsw-n3050)
                fail       -> PASS       (fi-skl-6700k)
        Subgroup basic-flip-vs-cursor-varying-size:
                fail       -> PASS       (fi-bsw-n3050)
                fail       -> PASS       (fi-skl-6700k)

fi-bdw-5557u     total:252  pass:235  dwarn:0   dfail:0   fail:2   skip:15 
fi-bsw-n3050     total:252  pass:204  dwarn:0   dfail:0   fail:2   skip:46 
fi-byt-n2820     total:252  pass:207  dwarn:0   dfail:0   fail:3   skip:42 
fi-hsw-4770k     total:252  pass:228  dwarn:0   dfail:0   fail:2   skip:22 
fi-hsw-4770r     total:252  pass:224  dwarn:0   dfail:0   fail:2   skip:26 
fi-ivb-3520m     total:252  pass:219  dwarn:0   dfail:0   fail:1   skip:32 
fi-skl-6260u     total:252  pass:236  dwarn:0   dfail:0   fail:2   skip:14 
fi-skl-6700k     total:252  pass:218  dwarn:4   dfail:0   fail:2   skip:28 
fi-snb-2520m     total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 
fi-snb-2600      total:252  pass:199  dwarn:8   dfail:0   fail:2   skip:43 

Results at /archive/results/CI_IGT_test/Patchwork_2426/

e14363ed1c12c86726914e3a790662e84e631c37 drm-intel-nightly: 2016y-08m-24d-18h-39m-56s UTC integration manifest
72b1ae0 drm/i915: Restore lost "Initialized i915" welcome message

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915: Restore lost "Initialized i915" welcome message
  2016-08-25  7:23 [PATCH] drm/i915: Restore lost "Initialized i915" welcome message Chris Wilson
  2016-08-25  7:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2016-08-25  7:51 ` Daniel Vetter
  2016-08-25  8:32   ` Chris Wilson
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2016-08-25  7:51 UTC (permalink / raw)
  To: Chris Wilson; +Cc: Daniel Vetter, intel-gfx, drm-intel-fixes

On Thu, Aug 25, 2016 at 08:23:14AM +0100, Chris Wilson wrote:
> A side effect of removing the midlayer from driver loading was the loss
> of a useful message announcing to userspace that i915 had successfully
> started, e.g.:
> 
> 	[drm] Initialized i915 1.6.0 20160425 for 0000:00:02.0 on minor 0
> 
> Reported-by:  Timo Aaltonen <tjaalton@ubuntu.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Fixes: 8f460e2c78f2 ("drm/i915: Demidlayer driver loading")
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: drm-intel-fixes@lists.freedesktop.org

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 6db1869e2c97..01757369d2d4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -1263,6 +1263,11 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)
>  
>  	intel_runtime_pm_enable(dev_priv);
>  
> +	/* Everything is in place, we can now relax! */
> +	DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
> +		 driver.name, driver.major, driver.minor, driver.patchlevel,
> +		 driver.date, pci_name(pdev), dev_priv->drm.primary->index);
> +
>  	intel_runtime_pm_put(dev_priv);
>  
>  	return 0;
> -- 
> 2.9.3
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/i915: Restore lost "Initialized i915" welcome message
  2016-08-25  7:51 ` [PATCH] " Daniel Vetter
@ 2016-08-25  8:32   ` Chris Wilson
  0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2016-08-25  8:32 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: Daniel Vetter, intel-gfx, drm-intel-fixes

On Thu, Aug 25, 2016 at 09:51:05AM +0200, Daniel Vetter wrote:
> On Thu, Aug 25, 2016 at 08:23:14AM +0100, Chris Wilson wrote:
> > A side effect of removing the midlayer from driver loading was the loss
> > of a useful message announcing to userspace that i915 had successfully
> > started, e.g.:
> > 
> > 	[drm] Initialized i915 1.6.0 20160425 for 0000:00:02.0 on minor 0
> > 
> > Reported-by:  Timo Aaltonen <tjaalton@ubuntu.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Fixes: 8f460e2c78f2 ("drm/i915: Demidlayer driver loading")
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: drm-intel-fixes@lists.freedesktop.org
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Ta, pushed. So much for our silent, it just works future ;)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-25  8:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-25  7:23 [PATCH] drm/i915: Restore lost "Initialized i915" welcome message Chris Wilson
2016-08-25  7:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-08-25  7:51 ` [PATCH] " Daniel Vetter
2016-08-25  8:32   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.