* [PATCH v1] rte_timer:timer lag issue correction
@ 2016-08-26 1:57 Karmarkar Suyash
0 siblings, 0 replies; 6+ messages in thread
From: Karmarkar Suyash @ 2016-08-26 1:57 UTC (permalink / raw)
To: rsanford; +Cc: dev, Karmarkar Suyash
For Periodic timers ,if the lag gets introduced, the current code added additional
delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix
the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior.
Fixes:rte_timer: timer lag issue
---
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
status.owner = (int16_t)lcore_id;
rte_wmb();
tim->status.u32 = status.u32;
- __rte_timer_reset(tim, cur_time + tim->period,
+ __rte_timer_reset(tim, tim->expire + tim->period,
tim->period, lcore_id, tim->f, tim->arg, 1);
rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
}
--
Karmarkar Suyash (1):
Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>
--
2.9.3.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1]:rte_timer:timer lag issue correction
2016-09-15 9:27 ` Pattan, Reshma
@ 2016-09-16 15:21 ` Karmarkar Suyash
0 siblings, 0 replies; 6+ messages in thread
From: Karmarkar Suyash @ 2016-09-16 15:21 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev, thomas.monjalon, rsanford
Thanks Reshma for the comments, the issue is a day one bug. I will correct the fixes line and submit v2 of the patch.
-----Original Message-----
From: Pattan, Reshma [mailto:reshma.pattan@intel.com]
Sent: Thursday, September 15, 2016 5:28 AM
To: Karmarkar Suyash <skarmarkar@sonusnet.com>
Cc: dev@dpdk.org; thomas.monjalon@6wind.com; rsanford@akamai.com
Subject: RE: [PATCH v1]:rte_timer:timer lag issue correction
Hi,
>
> For Periodic timers ,if the lag gets introduced, the current code
> added additional delay when the next peridoc timer was initialized by
> not taking into account the delay added, with this fix the code would
> start the next occurrence of timer keeping in account the lag added.Corrected the behavior.
>
> Fixes:rte_timer: timer lag issue
Fixes line format is not corerct. Fixes line should contain commit hash that introduced the bug and its subject line. For your case below should be added.
Fixes: 9b15ba89 ("timer: use a skip list")
Thanks,
Reshma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1]:rte_timer:timer lag issue correction
2016-09-14 21:13 ` Karmarkar Suyash
@ 2016-09-15 9:27 ` Pattan, Reshma
2016-09-16 15:21 ` Karmarkar Suyash
0 siblings, 1 reply; 6+ messages in thread
From: Pattan, Reshma @ 2016-09-15 9:27 UTC (permalink / raw)
To: Karmarkar Suyash; +Cc: dev, thomas.monjalon, rsanford
Hi,
>
> For Periodic timers ,if the lag gets introduced, the current code added additional
> delay when the next peridoc timer was initialized by not taking into account the
> delay added, with this fix the code would start the next occurrence of timer
> keeping in account the lag added.Corrected the behavior.
>
> Fixes:rte_timer: timer lag issue
Fixes line format is not corerct. Fixes line should contain commit hash that introduced the bug and its subject line. For your case below should be added.
Fixes: 9b15ba89 ("timer: use a skip list")
Thanks,
Reshma
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1]:rte_timer:timer lag issue correction
2016-08-26 13:27 [PATCH v1]:rte_timer:timer " Karmarkar Suyash
2016-08-29 22:28 ` Karmarkar Suyash
@ 2016-09-14 21:13 ` Karmarkar Suyash
2016-09-15 9:27 ` Pattan, Reshma
1 sibling, 1 reply; 6+ messages in thread
From: Karmarkar Suyash @ 2016-09-14 21:13 UTC (permalink / raw)
To: rsanford, thomas.monjalon; +Cc: dev
Hello,
Can you please review the change and let me know if any comments. I would like to push this patch to 16.11 release. Thanks. Please note this fix is tested as well.
Regards
Suyash Karmarkar
_____________________________________________
From: Karmarkar Suyash
Sent: Monday, August 29, 2016 6:28 PM
To: dev@dpdk.org
Subject: RE: [PATCH v1]:rte_timer:timer lag issue correction
Hello All,
Can you please review the change and let me know if any comments. I would like to push this patch to 16.07 release. Thanks
Regards
Suyash Karmarkar
-----Original Message-----
From: Karmarkar Suyash
Sent: Friday, August 26, 2016 9:27 AM
To: rsanford@akamai.com<mailto:rsanford@akamai.com>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>; Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
Subject: [PATCH v1]:rte_timer:timer lag issue correction
For Periodic timers ,if the lag gets introduced, the current code
added additional delay when the next peridoc timer was initialized
by not taking into account the delay added, with this fix the code
would start the next occurrence of timer keeping in account the
lag added.Corrected the behavior.
Fixes:rte_timer: timer lag issue
Karmarkar Suyash (1):
Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From ba885531ac26af1aabc6bd0f58d7ce744b04acf7 Mon Sep 17 00:00:00 2001
From: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
Date: Fri, 26 Aug 2016 09:20:37 -0400
Subject: [PATCH v1] Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
---
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
status.owner = (int16_t)lcore_id;
rte_wmb();
tim->status.u32 = status.u32;
- __rte_timer_reset(tim, cur_time + tim->period,
+ __rte_timer_reset(tim, tim->expire + tim->period,
tim->period, lcore_id, tim->f, tim->arg, 1);
rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
}
--
2.9.3.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1]:rte_timer:timer lag issue correction
2016-08-26 13:27 [PATCH v1]:rte_timer:timer " Karmarkar Suyash
@ 2016-08-29 22:28 ` Karmarkar Suyash
2016-09-14 21:13 ` Karmarkar Suyash
1 sibling, 0 replies; 6+ messages in thread
From: Karmarkar Suyash @ 2016-08-29 22:28 UTC (permalink / raw)
To: dev
Hello All,
Can you please review the change and let me know if any comments. I would like to push this patch to 16.07 release. Thanks
Regards
Suyash Karmarkar
-----Original Message-----
From: Karmarkar Suyash
Sent: Friday, August 26, 2016 9:27 AM
To: rsanford@akamai.com
Cc: dev@dpdk.org; Karmarkar Suyash <skarmarkar@sonusnet.com>
Subject: [PATCH v1]:rte_timer:timer lag issue correction
For Periodic timers ,if the lag gets introduced, the current code
added additional delay when the next peridoc timer was initialized
by not taking into account the delay added, with this fix the code
would start the next occurrence of timer keeping in account the
lag added.Corrected the behavior.
Fixes:rte_timer: timer lag issue
Karmarkar Suyash (1):
Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From ba885531ac26af1aabc6bd0f58d7ce744b04acf7 Mon Sep 17 00:00:00 2001
From: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
Date: Fri, 26 Aug 2016 09:20:37 -0400
Subject: [PATCH v1] Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com<mailto:skarmarkar@sonusnet.com>>
---
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
status.owner = (int16_t)lcore_id;
rte_wmb();
tim->status.u32 = status.u32;
- __rte_timer_reset(tim, cur_time + tim->period,
+ __rte_timer_reset(tim, tim->expire + tim->period,
tim->period, lcore_id, tim->f, tim->arg, 1);
rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
}
--
2.9.3.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1]:rte_timer:timer lag issue correction
@ 2016-08-26 13:27 Karmarkar Suyash
2016-08-29 22:28 ` Karmarkar Suyash
2016-09-14 21:13 ` Karmarkar Suyash
0 siblings, 2 replies; 6+ messages in thread
From: Karmarkar Suyash @ 2016-08-26 13:27 UTC (permalink / raw)
To: rsanford; +Cc: dev, Karmarkar Suyash
For Periodic timers ,if the lag gets introduced, the current code
added additional delay when the next peridoc timer was initialized
by not taking into account the delay added, with this fix the code
would start the next occurrence of timer keeping in account the
lag added.Corrected the behavior.
Fixes:rte_timer: timer lag issue
Karmarkar Suyash (1):
Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From ba885531ac26af1aabc6bd0f58d7ce744b04acf7 Mon Sep 17 00:00:00 2001
From: Karmarkar Suyash <skarmarkar@sonusnet.com>
Date: Fri, 26 Aug 2016 09:20:37 -0400
Subject: [PATCH v1] Signed-off-by: Karmarkar Suyash <skarmarkar@sonusnet.com>
---
lib/librte_timer/rte_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index 43da836..18782fa 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -613,7 +613,7 @@ void rte_timer_manage(void)
status.owner = (int16_t)lcore_id;
rte_wmb();
tim->status.u32 = status.u32;
- __rte_timer_reset(tim, cur_time + tim->period,
+ __rte_timer_reset(tim, tim->expire + tim->period,
tim->period, lcore_id, tim->f, tim->arg, 1);
rte_spinlock_unlock(&priv_timer[lcore_id].list_lock);
}
--
2.9.3.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-16 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 1:57 [PATCH v1] rte_timer:timer lag issue correction Karmarkar Suyash
2016-08-26 13:27 [PATCH v1]:rte_timer:timer " Karmarkar Suyash
2016-08-29 22:28 ` Karmarkar Suyash
2016-09-14 21:13 ` Karmarkar Suyash
2016-09-15 9:27 ` Pattan, Reshma
2016-09-16 15:21 ` Karmarkar Suyash
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.