All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v3 01/13] ARM: dts: lager: rename and reindex i2cexio
Date: Tue, 30 Aug 2016 17:29:08 +0200	[thread overview]
Message-ID: <20160830151819.GA1695@katana> (raw)
In-Reply-To: <1466567031-20381-2-git-send-email-horms+renesas@verge.net.au>

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi Simon,

>  		serial0 = &scif0;
>  		serial1 = &scifa1;
> -		i2c8 = "i2cexio";
> +		i2c10 = "i2cexio0";

Those should be pointers, i.e. "&i2cexio0;", here and in the rest of
your series. Sorry for the broken template! Did you have a chance to
test my fix for the demuxer?

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/13] ARM: dts: lager: rename and reindex i2cexio
Date: Tue, 30 Aug 2016 17:29:08 +0200	[thread overview]
Message-ID: <20160830151819.GA1695@katana> (raw)
In-Reply-To: <1466567031-20381-2-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

>  		serial0 = &scif0;
>  		serial1 = &scifa1;
> -		i2c8 = "i2cexio";
> +		i2c10 = "i2cexio0";

Those should be pointers, i.e. "&i2cexio0;", here and in the rest of
your series. Sorry for the broken template! Did you have a chance to
test my fix for the demuxer?

Regards,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160830/6e38476e/attachment.sig>

  reply	other threads:[~2016-08-30 15:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22  3:43 [PATCH v3 00/13] ARM: dts: r8a779x: use demuxer for I2C Simon Horman
2016-06-22  3:43 ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 01/13] ARM: dts: lager: rename and reindex i2cexio Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-08-30 15:29   ` Wolfram Sang [this message]
2016-08-30 15:29     ` Wolfram Sang
2016-09-02  8:17     ` Simon Horman
2016-09-02  8:17       ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 02/13] ARM: dts: lager: use demuxer for IIC1/I2C1 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 03/13] ARM: dts: lager: use demuxer for IIC2/I2C2 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 04/13] ARM: dts: lager: use demuxer for IIC3/I2C3 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  7:29   ` Geert Uytterhoeven
2016-06-22  7:29     ` Geert Uytterhoeven
2016-06-22  3:43 ` [PATCH v3 05/13] ARM: dts: koelsch: use demuxer for I2C1 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 06/13] ARM: dts: koelsch: use demuxer for I2C2 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 07/13] ARM: dts: koelsch: use demuxer for I2C4 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 08/13] ARM: dts: porter: use demuxer for I2C2 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 09/13] " Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 10/13] ARM: dts: koelsch: use demuxer for I2C4 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 11/13] ARM: dts: alt: use demuxer for I2C1 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 12/13] ARM: dts: alt: use demuxer for I2C4 Simon Horman
2016-06-22  3:43   ` Simon Horman
2016-06-22  3:43 ` [PATCH v3 13/13] ARM: dts: silk: use demuxer for I2C1 Simon Horman
2016-06-22  3:43   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160830151819.GA1695@katana \
    --to=wsa@the-dreams.de \
    --cc=horms+renesas@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.