[PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Nayna Jain]

This is documenting device tree binding for
I2C based TPM, similar concept which being used
for virtual TPM on POWER7 and POWER8 systems running PowerVM.

Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
 Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt

diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
new file mode 100644
index 0000000..8fdee14
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
@@ -0,0 +1,29 @@
+Device Tree Bindings for I2C based Trusted Platform Module(TPM)
+---------------------------------------------------------------
+
+This node describes a TPM device connected to Processor on i2c bus.
+
+Required properties:
+
+- compatible : 'manufacturer,model'
+- label : represents device type
+- linux,sml-base : base address of the Event Log. It is a physical address.
+		   sml stands for shared memory log.
+- linux,sml-size : size of the memory allocated for the Event Log.
+
+Optional properties:
+
+- status: indicates whether the device is enabled or disabled. "okay" for
+          enabled and "disabled" for disabled.
+
+Example
+-------
+
+tpm@57 {
+	reg = <0x57>;
+	label = "tpm";
+	compatible = "nuvoton,npct650", "nuvoton,npct601";
+	linux,sml-base = <0x7f 0xfd450000>;
+	linux,sml-size = <0x10000>;
+	status = "okay";
+};
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Jarkko Sakkinen]

On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> This is documenting device tree binding for
> I2C based TPM, similar concept which being used
> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> 
> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> new file mode 100644
> index 0000000..8fdee14
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> @@ -0,0 +1,29 @@
> +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
> +---------------------------------------------------------------
> +
> +This node describes a TPM device connected to Processor on i2c bus.
> +
> +Required properties:
> +
> +- compatible : 'manufacturer,model'
> +- label : represents device type
> +- linux,sml-base : base address of the Event Log. It is a physical address.
> +		   sml stands for shared memory log.
> +- linux,sml-size : size of the memory allocated for the Event Log.
> +
> +Optional properties:
> +
> +- status: indicates whether the device is enabled or disabled. "okay" for
> +          enabled and "disabled" for disabled.
> +
> +Example
> +-------
> +
> +tpm@57 {
> +	reg = <0x57>;
> +	label = "tpm";
> +	compatible = "nuvoton,npct650", "nuvoton,npct601";
> +	linux,sml-base = <0x7f 0xfd450000>;
> +	linux,sml-size = <0x10000>;
> +	status = "okay";
> +};

I would rather name the fields event-log-base and event-log-size. They
would be much more readable and obvious names.

Also, enabled should be "enabled", not "okay".

/Jarkko

------------------------------------------------------------------------------

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Peter Huewe]

Am 29. August 2016 23:36:31 GMT-07:00, schrieb Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>:
>On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
>> This is documenting device tree binding for
>> I2C based TPM, similar concept which being used
>> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
>> 
>> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29
>+++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> 
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> new file mode 100644
>> index 0000000..8fdee14
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> @@ -0,0 +1,29 @@
>> +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
>> +---------------------------------------------------------------
>> +
>> +This node describes a TPM device connected to Processor on i2c bus.
>> +
>> +Required properties:
>> +
>> +- compatible : 'manufacturer,model'
>> +- label : represents device type
>> +- linux,sml-base : base address of the Event Log. It is a physical
>address.
>> +		   sml stands for shared memory log.
>> +- linux,sml-size : size of the memory allocated for the Event Log.
>> +
>> +Optional properties:
>> +
>> +- status: indicates whether the device is enabled or disabled.
>"okay" for
>> +          enabled and "disabled" for disabled.
>> +
>> +Example
>> +-------
>> +
>> +tpm@57 {
>> +	reg = <0x57>;
>> +	label = "tpm";
>> +	compatible = "nuvoton,npct650", "nuvoton,npct601";
>> +	linux,sml-base = <0x7f 0xfd450000>;
>> +	linux,sml-size = <0x10000>;
>> +	status = "okay";
>> +};
>
>I would rather name the fields event-log-base and event-log-size. They
>would be much more readable and obvious names.

I agree - I always get stuck upon the sml thing.
>
>Also, enabled should be "enabled", not "okay".

No!
okay/ok is a dt keyword! (Or at least used in everything else)

It has nothing to do whether the TPM is enabled/disabled/activated whatever
Peter

>
>/Jarkko
>
>------------------------------------------------------------------------------
>_______________________________________________
>tpmdd-devel mailing list
>tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/tpmdd-devel

-- 
Sent from my mobile

------------------------------------------------------------------------------

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Peter Huewe]

I agree - I always get stuck upon the sml thing.
>
>Also, enabled should be "enabled", not "okay".

No!
okay/ok is a dt keyword! (Or at least used in everything else)

It has nothing to do whether the TPM is enabled/disabled/activated whatever
See http://www.devicetree.org/specifications-pdf table 2.4

Value Description
"okay" Indicates the device is operational
"disabled" Indicates that the device is not presently operational, but it might become operational in the
future (for example, something is not plugged in, or switched off).
Refer to the device binding for details on what disabled means for a given device.
"fail" Indicates that the device is not operational. A serious error was detected in the device, and it
is unlikely to become operational without repair.
"fail-sss" Indicates that the device is not operational. A serious error was detected in the device and it
is unlikely to become operational without repair. The sss portion of the value is specific to
the device and indicates the error condition detected.

------------------------------------------------------------------------------

Re: [tpmdd-devel] [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Jarkko Sakkinen]

On Mon, Aug 29, 2016 at 11:41:51PM -0700, Peter Huewe wrote:
> 
> 
> Am 29. August 2016 23:36:31 GMT-07:00, schrieb Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>:
> >On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> >> This is documenting device tree binding for
> >> I2C based TPM, similar concept which being used
> >> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> >> 
> >> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> >> ---
> >>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29
> >+++++++++++++++++++++++
> >>  1 file changed, 29 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> >> 
> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> >b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> >> new file mode 100644
> >> index 0000000..8fdee14
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> >> @@ -0,0 +1,29 @@
> >> +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
> >> +---------------------------------------------------------------
> >> +
> >> +This node describes a TPM device connected to Processor on i2c bus.
> >> +
> >> +Required properties:
> >> +
> >> +- compatible : 'manufacturer,model'
> >> +- label : represents device type
> >> +- linux,sml-base : base address of the Event Log. It is a physical
> >address.
> >> +		   sml stands for shared memory log.
> >> +- linux,sml-size : size of the memory allocated for the Event Log.
> >> +
> >> +Optional properties:
> >> +
> >> +- status: indicates whether the device is enabled or disabled.
> >"okay" for
> >> +          enabled and "disabled" for disabled.
> >> +
> >> +Example
> >> +-------
> >> +
> >> +tpm@57 {
> >> +	reg = <0x57>;
> >> +	label = "tpm";
> >> +	compatible = "nuvoton,npct650", "nuvoton,npct601";
> >> +	linux,sml-base = <0x7f 0xfd450000>;
> >> +	linux,sml-size = <0x10000>;
> >> +	status = "okay";
> >> +};
> >
> >I would rather name the fields event-log-base and event-log-size. They
> >would be much more readable and obvious names.
> 
> I agree - I always get stuck upon the sml thing.
> >
> >Also, enabled should be "enabled", not "okay".
> 
> No!
> okay/ok is a dt keyword! (Or at least used in everything else)
> 
> It has nothing to do whether the TPM is enabled/disabled/activated whatever
> Peter

OK, just to educate myself, where can I find these standard keywords?

The granularity is wrong (section 8.7 of TPM 2.0 Structures
specification). There are four different things that you can
enabled/disable.

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Peter Huewe]

Am 30. August 2016 00:06:49 GMT-07:00, schrieb Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>:
>On Mon, Aug 29, 2016 at 11:41:51PM -0700, Peter Huewe wrote:
>> 
>> 
>> Am 29. August 2016 23:36:31 GMT-07:00, schrieb Jarkko Sakkinen
><jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>:
>> >On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
>> >> This is documenting device tree binding for
>> >> I2C based TPM, similar concept which being used
>> >> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
>> >> 
>> >> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
>> >> ---
>> >>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29
>> >+++++++++++++++++++++++
>> >>  1 file changed, 29 insertions(+)
>> >>  create mode 100644
>Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> >> 
>> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> >b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> >> new file mode 100644
>> >> index 0000000..8fdee14
>> >> --- /dev/null
>> >> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
>> >> @@ -0,0 +1,29 @@
>> >> +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
>> >> +---------------------------------------------------------------
>> >> +
>> >> +This node describes a TPM device connected to Processor on i2c
>bus.
>> >> +
>> >> +Required properties:
>> >> +
>> >> +- compatible : 'manufacturer,model'
>> >> +- label : represents device type
>> >> +- linux,sml-base : base address of the Event Log. It is a
>physical
>> >address.
>> >> +		   sml stands for shared memory log.
>> >> +- linux,sml-size : size of the memory allocated for the Event
>Log.
>> >> +
>> >> +Optional properties:
>> >> +
>> >> +- status: indicates whether the device is enabled or disabled.
>> >"okay" for
>> >> +          enabled and "disabled" for disabled.
>> >> +
>> >> +Example
>> >> +-------
>> >> +
>> >> +tpm@57 {
>> >> +	reg = <0x57>;
>> >> +	label = "tpm";
>> >> +	compatible = "nuvoton,npct650", "nuvoton,npct601";
>> >> +	linux,sml-base = <0x7f 0xfd450000>;
>> >> +	linux,sml-size = <0x10000>;
>> >> +	status = "okay";
>> >> +};
>> >
>> >I would rather name the fields event-log-base and event-log-size.
>They
>> >would be much more readable and obvious names.
>> 
>> I agree - I always get stuck upon the sml thing.
>> >
>> >Also, enabled should be "enabled", not "okay".
>> 
>> No!
>> okay/ok is a dt keyword! (Or at least used in everything else)
>> 
>> It has nothing to do whether the TPM is enabled/disabled/activated
>whatever
>> Peter
>
>OK, just to educate myself, where can I find these standard keywords?


See http://www.devicetree.org/specifications-pdf table 2.4
>
>The granularity is wrong (section 8.7 of TPM 2.0 Structures
>specification). There are four different things that you can
>enabled/disable.
>
>/Jarkko

-- 
Sent from my mobile

------------------------------------------------------------------------------

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Rob Herring]

On Tue, Aug 30, 2016 at 09:36:31AM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> > This is documenting device tree binding for
> > I2C based TPM, similar concept which being used
> > for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> > 
> > Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > new file mode 100644
> > index 0000000..8fdee14
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > @@ -0,0 +1,29 @@
> > +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
> > +---------------------------------------------------------------
> > +
> > +This node describes a TPM device connected to Processor on i2c bus.
> > +
> > +Required properties:
> > +
> > +- compatible : 'manufacturer,model'
> > +- label : represents device type
> > +- linux,sml-base : base address of the Event Log. It is a physical address.
> > +		   sml stands for shared memory log.
> > +- linux,sml-size : size of the memory allocated for the Event Log.
> > +
> > +Optional properties:
> > +
> > +- status: indicates whether the device is enabled or disabled. "okay" for
> > +          enabled and "disabled" for disabled.
> > +
> > +Example
> > +-------
> > +
> > +tpm@57 {
> > +	reg = <0x57>;
> > +	label = "tpm";
> > +	compatible = "nuvoton,npct650", "nuvoton,npct601";
> > +	linux,sml-base = <0x7f 0xfd450000>;
> > +	linux,sml-size = <0x10000>;
> > +	status = "okay";
> > +};
> 
> I would rather name the fields event-log-base and event-log-size. They
> would be much more readable and obvious names.
> 
> Also, enabled should be "enabled", not "okay".

No, okay is correct. But as I mentioned, don't document it here.

Rob

------------------------------------------------------------------------------

Re: [tpmdd-devel] [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Jarkko Sakkinen]

On Fri, Sep 02, 2016 at 09:52:38AM -0500, Rob Herring wrote:
> On Tue, Aug 30, 2016 at 09:36:31AM +0300, Jarkko Sakkinen wrote:
> > On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> > > This is documenting device tree binding for
> > > I2C based TPM, similar concept which being used
> > > for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> > > 
> > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> > > ---
> > >  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
> > >  1 file changed, 29 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > > new file mode 100644
> > > index 0000000..8fdee14
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> > > @@ -0,0 +1,29 @@
> > > +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
> > > +---------------------------------------------------------------
> > > +
> > > +This node describes a TPM device connected to Processor on i2c bus.
> > > +
> > > +Required properties:
> > > +
> > > +- compatible : 'manufacturer,model'
> > > +- label : represents device type
> > > +- linux,sml-base : base address of the Event Log. It is a physical address.
> > > +		   sml stands for shared memory log.
> > > +- linux,sml-size : size of the memory allocated for the Event Log.
> > > +
> > > +Optional properties:
> > > +
> > > +- status: indicates whether the device is enabled or disabled. "okay" for
> > > +          enabled and "disabled" for disabled.
> > > +
> > > +Example
> > > +-------
> > > +
> > > +tpm@57 {
> > > +	reg = <0x57>;
> > > +	label = "tpm";
> > > +	compatible = "nuvoton,npct650", "nuvoton,npct601";
> > > +	linux,sml-base = <0x7f 0xfd450000>;
> > > +	linux,sml-size = <0x10000>;
> > > +	status = "okay";
> > > +};
> > 
> > I would rather name the fields event-log-base and event-log-size. They
> > would be much more readable and obvious names.
> > 
> > Also, enabled should be "enabled", not "okay".
> 
> No, okay is correct. But as I mentioned, don't document it here.

We'll stick to sml-base and sml-size because the existing code binds
already to those names.

/Jakrko

Re: Documentation: tpm: Adds the TPM device tree node documentation

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> This is documenting device tree binding for
> I2C based TPM, similar concept which being used
> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> 
> Signed-off-by: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++

Is the driver in 'drivers/i2c/*'? No, so the binding shouldn't be in i2c
as well.

> +- compatible : 'manufacturer,model'

You need to specify them here!

> +Optional properties:
> +
> +- status: indicates whether the device is enabled or disabled. "okay" for
> +          enabled and "disabled" for disabled.

Optional? Rather "implicit" I'd say.

This is far from ready. You should really wait for Rob's review. Or
better: Have a look at other bindings.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Rob Herring]

On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote:
> This is documenting device tree binding for
> I2C based TPM, similar concept which being used
> for virtual TPM on POWER7 and POWER8 systems running PowerVM.
> 
> Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 +++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> new file mode 100644
> index 0000000..8fdee14
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt
> @@ -0,0 +1,29 @@
> +Device Tree Bindings for I2C based Trusted Platform Module(TPM)
> +---------------------------------------------------------------
> +
> +This node describes a TPM device connected to Processor on i2c bus.
> +
> +Required properties:
> +
> +- compatible : 'manufacturer,model'

Needs specific compatible strings like your example has.

> +- label : represents device type

Why do you need this? label is human readable things like connectors on 
boards.

> +- linux,sml-base : base address of the Event Log. It is a physical address.
> +		   sml stands for shared memory log.

How is it a physical address on an i2c device? Why 2 cells (which needs 
to be documented also)?

Just 'log' would be more descriptive than sml.

> +- linux,sml-size : size of the memory allocated for the Event Log.
> +
> +Optional properties:
> +
> +- status: indicates whether the device is enabled or disabled. "okay" for
> +          enabled and "disabled" for disabled.

status is always valid, so you don't need to document it.

Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Jason Gunthorpe]

On Fri, Sep 02, 2016 at 09:51:21AM -0500, Rob Herring wrote:
> > +- linux,sml-base : base address of the Event Log. It is a physical address.
> > +		   sml stands for shared memory log.
> 
> How is it a physical address on an i2c device? Why 2 cells (which needs 
> to be documented also)?

To be clear, as I understand it, this mechanism is a hand off from the
boot firmware to Linux.

The boot firmware talks i2c to the device, does some stuff, writes it
to memory and then linux reads that stuff. I agree it seems crazy to
include a random physical address like that.

The linux,sml-* names appear to have been used by IBM for a long time
on their enterprise PPC platforms (see drivers/char/tpm/tpm_of.c), so
I've expected we have to keep them?

I asked Nayna to document this stuff IBM is doing so the rest of us
in TPM land can have a hope of maintaining it...

Jason

------------------------------------------------------------------------------

Re: [tpmdd-devel] [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Rob Herring]

On Fri, Sep 2, 2016 at 12:06 PM, Jason Gunthorpe
<jgunthorpe@obsidianresearch.com> wrote:
> On Fri, Sep 02, 2016 at 09:51:21AM -0500, Rob Herring wrote:
>> > +- linux,sml-base : base address of the Event Log. It is a physical address.
>> > +              sml stands for shared memory log.
>>
>> How is it a physical address on an i2c device? Why 2 cells (which needs
>> to be documented also)?
>
> To be clear, as I understand it, this mechanism is a hand off from the
> boot firmware to Linux.
>
> The boot firmware talks i2c to the device, does some stuff, writes it
> to memory and then linux reads that stuff. I agree it seems crazy to
> include a random physical address like that.

I'd put that in reserved-memory then if designing this from scratch...

Must not be completely random as somehow the kernel doesn't use that memory.

> The linux,sml-* names appear to have been used by IBM for a long time
> on their enterprise PPC platforms (see drivers/char/tpm/tpm_of.c), so
> I've expected we have to keep them?

Yes. I wasn't aware of that.

> I asked Nayna to document this stuff IBM is doing so the rest of us
> in TPM land can have a hope of maintaining it...
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [tpmdd-devel] [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Nayna]

On 09/02/2016 11:27 PM, Rob Herring wrote:
> On Fri, Sep 2, 2016 at 12:06 PM, Jason Gunthorpe
> <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
>> On Fri, Sep 02, 2016 at 09:51:21AM -0500, Rob Herring wrote:
>>>> +- linux,sml-base : base address of the Event Log. It is a physical address.
>>>> +              sml stands for shared memory log.
>>>
>>> How is it a physical address on an i2c device? Why 2 cells (which needs
>>> to be documented also)?
>>
>> To be clear, as I understand it, this mechanism is a hand off from the
>> boot firmware to Linux.
>>
>> The boot firmware talks i2c to the device, does some stuff, writes it
>> to memory and then linux reads that stuff. I agree it seems crazy to
>> include a random physical address like that.
>
> I'd put that in reserved-memory then if designing this from scratch...

Thanks for the review comments.

Yes, it is in reserved-memory. I modified the explanation for 
linux,sml-base property to be more descriptive now in my v2 version of 
the patch, posted just now.
>
> Must not be completely random as somehow the kernel doesn't use that memory.
>
>> The linux,sml-* names appear to have been used by IBM for a long time
>> on their enterprise PPC platforms (see drivers/char/tpm/tpm_of.c), so
>> I've expected we have to keep them?
>
> Yes. I wasn't aware of that.
>
>> I asked Nayna to document this stuff IBM is doing so the rest of us
>> in TPM land can have a hope of maintaining it...
>>
>> Jason
>> --
>> To unsubscribe from this list: send the line "unsubscribe devicetree" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [tpmdd-devel] [PATCH] Documentation: tpm: Adds the TPM device tree node documentation

[Nayna]

On 09/02/2016 10:36 PM, Jason Gunthorpe wrote:
> On Fri, Sep 02, 2016 at 09:51:21AM -0500, Rob Herring wrote:
>>> +- linux,sml-base : base address of the Event Log. It is a physical address.
>>> +		   sml stands for shared memory log.
>>
>> How is it a physical address on an i2c device? Why 2 cells (which needs
>> to be documented also)?
>
> To be clear, as I understand it, this mechanism is a hand off from the
> boot firmware to Linux.
>
> The boot firmware talks i2c to the device, does some stuff, writes it
> to memory and then linux reads that stuff. I agree it seems crazy to
> include a random physical address like that.
>
> The linux,sml-* names appear to have been used by IBM for a long time
> on their enterprise PPC platforms (see drivers/char/tpm/tpm_of.c), so
> I've expected we have to keep them?
>
> I asked Nayna to document this stuff IBM is doing so the rest of us
> in TPM land can have a hope of maintaining it...

Thanks Jason !!

In my v2 version for device tree documentation, I have posted the 
documentation for both vtpm and physical TPM.

>
> Jason
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html