All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Icenowy Zheng <icenowy@aosc.xyz>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel
Date: Tue, 6 Sep 2016 16:33:17 +0200	[thread overview]
Message-ID: <20160906143317.GG9040@lukather> (raw)
In-Reply-To: <20160906091224.GC15644@ulmo.ba.sec>

[-- Attachment #1: Type: text/plain, Size: 1546 bytes --]

On Tue, Sep 06, 2016 at 11:12:24AM +0200, Thierry Reding wrote:
> On Mon, Sep 05, 2016 at 10:02:48PM +0200, Maxime Ripard wrote:
> > Hi,
> > 
> > On Mon, Sep 05, 2016 at 01:03:03AM +0800, Icenowy Zheng wrote:
> > > Hi Everyone,
> > > 
> > > 01.09.2016, 23:40, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > > >  The SinA33 has an unidentified panel. Add the timings for it under a new
> > > >  compatible.
> > > 
> > > 
> > > 
> > > Excuse me...
> > > I will ask a question which is not fully related to the patch here...
> > > If I want to add a generic panel for Q8 tablets, what should it be called?
> > > "allwinner,q8-lcd-panel-800x480"?
> > 
> > I guess it's more of a question for Thierry, but it seems like the
> > trend is to put the diagonal rather than the resolution in the
> > compatibles.
> 
> Compatible strings should contain the model number of the panel. There
> is no such thing as a "generic panel for Q8 tablets".
> 
> Also, how is it that these panels are unidentified? Has nobody tried to
> open them up and look at the panel to find a model number?

It is not always possible without breaking the device apart. And I can
understand not a lot of people want to do that.

But on that particular patch, I had a bunch of spare ones, and ended
up doing just that. The reference is from an unknown brand, but at
least the part number shows up on Google, I'll use that.

Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel
Date: Tue, 6 Sep 2016 16:33:17 +0200	[thread overview]
Message-ID: <20160906143317.GG9040@lukather> (raw)
In-Reply-To: <20160906091224.GC15644@ulmo.ba.sec>

On Tue, Sep 06, 2016 at 11:12:24AM +0200, Thierry Reding wrote:
> On Mon, Sep 05, 2016 at 10:02:48PM +0200, Maxime Ripard wrote:
> > Hi,
> > 
> > On Mon, Sep 05, 2016 at 01:03:03AM +0800, Icenowy Zheng wrote:
> > > Hi Everyone,
> > > 
> > > 01.09.2016, 23:40, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > > > ?The SinA33 has an unidentified panel. Add the timings for it under a new
> > > > ?compatible.
> > > 
> > > 
> > > 
> > > Excuse me...
> > > I will ask a question which is not fully related to the patch here...
> > > If I want to add a generic panel for Q8 tablets, what should it be called?
> > > "allwinner,q8-lcd-panel-800x480"?
> > 
> > I guess it's more of a question for Thierry, but it seems like the
> > trend is to put the diagonal rather than the resolution in the
> > compatibles.
> 
> Compatible strings should contain the model number of the panel. There
> is no such thing as a "generic panel for Q8 tablets".
> 
> Also, how is it that these panels are unidentified? Has nobody tried to
> open them up and look at the panel to find a model number?

It is not always possible without breaking the device apart. And I can
understand not a lot of people want to do that.

But on that particular patch, I had a bunch of spare ones, and ended
up doing just that. The reference is from an unknown brand, but at
least the part number shows up on Google, I'll use that.

Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160906/dcec7aca/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>,
	Daniel Vetter
	<daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel
Date: Tue, 6 Sep 2016 16:33:17 +0200	[thread overview]
Message-ID: <20160906143317.GG9040@lukather> (raw)
In-Reply-To: <20160906091224.GC15644-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1901 bytes --]

On Tue, Sep 06, 2016 at 11:12:24AM +0200, Thierry Reding wrote:
> On Mon, Sep 05, 2016 at 10:02:48PM +0200, Maxime Ripard wrote:
> > Hi,
> > 
> > On Mon, Sep 05, 2016 at 01:03:03AM +0800, Icenowy Zheng wrote:
> > > Hi Everyone,
> > > 
> > > 01.09.2016, 23:40, "Maxime Ripard" <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>:
> > > >  The SinA33 has an unidentified panel. Add the timings for it under a new
> > > >  compatible.
> > > 
> > > 
> > > 
> > > Excuse me...
> > > I will ask a question which is not fully related to the patch here...
> > > If I want to add a generic panel for Q8 tablets, what should it be called?
> > > "allwinner,q8-lcd-panel-800x480"?
> > 
> > I guess it's more of a question for Thierry, but it seems like the
> > trend is to put the diagonal rather than the resolution in the
> > compatibles.
> 
> Compatible strings should contain the model number of the panel. There
> is no such thing as a "generic panel for Q8 tablets".
> 
> Also, how is it that these panels are unidentified? Has nobody tried to
> open them up and look at the panel to find a model number?

It is not always possible without breaking the device apart. And I can
understand not a lot of people want to do that.

But on that particular patch, I had a bunch of spare ones, and ended
up doing just that. The reference is from an unknown brand, but at
least the part number shows up on Google, I'll use that.

Maxime


-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-09-06 14:33 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 15:31 [PATCH 0/7] drm/sun4i: Introduce A33 display driver Maxime Ripard
2016-09-01 15:31 ` Maxime Ripard
2016-09-01 15:31 ` Maxime Ripard
2016-09-01 15:31 ` [PATCH 1/7] drm/sun4i: support TCONs without channel 1 Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-02  1:47   ` Chen-Yu Tsai
2016-09-02  1:47     ` Chen-Yu Tsai
2016-09-02  1:47     ` Chen-Yu Tsai
2016-09-01 15:31 ` [PATCH 2/7] drm/sun4i: support A33 tcon Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-02  6:02   ` Chen-Yu Tsai
2016-09-02  6:02     ` Chen-Yu Tsai
2016-09-02  6:02     ` Chen-Yu Tsai
2016-09-05 20:22     ` Maxime Ripard
2016-09-05 20:22       ` Maxime Ripard
2016-09-05 20:22       ` Maxime Ripard
2016-09-01 15:32 ` [PATCH 3/7] drm/sun4i: Add SAT and DRC drivers Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  6:45   ` Chen-Yu Tsai
2016-09-02  6:45     ` Chen-Yu Tsai
2016-09-02  6:45     ` Chen-Yu Tsai
2016-09-05 20:27     ` Maxime Ripard
2016-09-05 20:27       ` Maxime Ripard
2016-09-05 20:27       ` Maxime Ripard
2016-09-04 20:03   ` [linux-sunxi] " Peter Korsgaard
2016-09-04 20:03     ` Peter Korsgaard
2016-09-04 20:03     ` [linux-sunxi] " Peter Korsgaard
2016-09-06 13:59     ` Maxime Ripard
2016-09-06 13:59       ` Maxime Ripard
2016-09-06 13:59       ` [linux-sunxi] " Maxime Ripard
2016-09-01 15:32 ` [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  7:01   ` Chen-Yu Tsai
2016-09-02  7:01     ` Chen-Yu Tsai
2016-09-04 17:03   ` Icenowy Zheng
2016-09-04 17:03     ` Icenowy Zheng
2016-09-05 20:02     ` Maxime Ripard
2016-09-05 20:02       ` Maxime Ripard
2016-09-05 20:02       ` Maxime Ripard
2016-09-06  2:53       ` Chen-Yu Tsai
2016-09-06  2:53         ` Chen-Yu Tsai
2016-09-06  2:53         ` Chen-Yu Tsai
2016-09-06  9:12       ` Thierry Reding
2016-09-06  9:12         ` Thierry Reding
2016-09-06  9:12         ` Thierry Reding
2016-09-06 14:33         ` Maxime Ripard [this message]
2016-09-06 14:33           ` Maxime Ripard
2016-09-06 14:33           ` Maxime Ripard
2016-09-01 15:32 ` [PATCH 5/7] ARM: sun8i: a33: Add display pipeline Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  6:28   ` Chen-Yu Tsai
2016-09-02  6:28     ` Chen-Yu Tsai
2016-09-02  6:28     ` Chen-Yu Tsai
2016-09-05 20:21     ` Maxime Ripard
2016-09-05 20:21       ` Maxime Ripard
2016-09-05 20:21       ` Maxime Ripard
2016-09-06  2:51       ` Chen-Yu Tsai
2016-09-06  2:51         ` Chen-Yu Tsai
2016-09-06  2:51         ` Chen-Yu Tsai
2016-09-01 15:32 ` [PATCH 6/7] ARM: sun8i: a33: Add RGB666 pins Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  1:44   ` [linux-sunxi] " Chen-Yu Tsai
2016-09-02  1:44     ` Chen-Yu Tsai
2016-09-02  1:44     ` [linux-sunxi] " Chen-Yu Tsai
2016-09-01 15:32 ` [PATCH 7/7] ARM: sun8i: sina33: Enable display Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  1:30 ` [PATCH 0/7] drm/sun4i: Introduce A33 display driver Icenowy Zheng
2016-09-02  1:30   ` Icenowy Zheng
2016-09-02 19:06   ` Maxime Ripard
2016-09-02 19:06     ` Maxime Ripard
2016-09-02 19:06     ` Maxime Ripard
2016-09-03  1:43     ` Chen-Yu Tsai
2016-09-03  1:43       ` Chen-Yu Tsai
2016-09-03  1:43       ` Chen-Yu Tsai
2016-09-05 20:37       ` Maxime Ripard
2016-09-05 20:37         ` Maxime Ripard
2016-09-05 20:37         ` Maxime Ripard
2016-09-06  2:50         ` Chen-Yu Tsai
2016-09-06  2:50           ` Chen-Yu Tsai
2016-09-06  2:50           ` Chen-Yu Tsai
2016-09-06 18:54           ` Maxime Ripard
2016-09-06 18:54             ` Maxime Ripard
2016-09-06 18:54             ` Maxime Ripard
2016-09-07  4:49             ` Chen-Yu Tsai
2016-09-07  4:49               ` Chen-Yu Tsai
2016-09-07  4:49               ` Chen-Yu Tsai
2016-09-12  9:56               ` Maxime Ripard
2016-09-12  9:56                 ` Maxime Ripard
2016-09-12  9:56                 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906143317.GG9040@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hdegoede@redhat.com \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.