All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.xyz>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Thierry Reding <thierry.reding@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 0/7] drm/sun4i: Introduce A33 display driver
Date: Wed, 7 Sep 2016 12:49:58 +0800	[thread overview]
Message-ID: <CAGb2v660je7FAiXfeRb5Ynwtr8=fYDR1JHzrj2Hk+43_J0XRLg@mail.gmail.com> (raw)
In-Reply-To: <20160906185452.GI9040@lukather>

On Wed, Sep 7, 2016 at 2:54 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Sep 06, 2016 at 10:50:09AM +0800, Chen-Yu Tsai wrote:
>> >> The implementation might be along the lines of
>> >>
>> >>   1. having multiple output ports, each for a different interface type.
>> >>      (Some platforms go this route)
>> >>
>> >> Or
>> >>
>> >>   2. having a DT property describe what the output interface is.
>> >>
>> >> The RGB/TCON driver would then setup the registers accordingly.
>> >
>> > Hmmm, yeah, we would need to adjust the bindings too...
>> >
>> > I guess I'd prefer 1), but that would also be the most invasive
>> > solution. I'm not sure how the DT maintainers feel about that.
>>
>> I wonder if the TCON could use its 2 channels simultaneously?
>
> No, it's mutually exclusive.

I don't see how though. Are you referring to the IO_Map_Sel bit?
I assume that only controls the external output pins though.

>> Like output to one LCD, then mirror through HDMI/VGA?
>> The first option would be able to cover this better?
>
> Even if it wasn't exclusive, that wouldn't be possible
> unfortunately. Or rather, this would be possible if the LCD and the
> HDMI screen had the same timings, which is very unlikely.

What about an LCD-VGA bridge + HDMI in mirror mode on sun6i?
That should work.

>> And you still need to add outgoing endpoints for the HDMI block.
>
> Indeed.

On second thought, this particular one shouldn't affect the binding.

>
>> In addition we'll have to rework the TV encoder binding as well.
>>
>> The 2 TV encoders (on the A20) each have four DACs, which map
>> onto 4 external pins. The address space includes a not so easy
>> to use mux. More importantly, the binding needs to specify which
>> pin is used for what signal (RGB, YUV, S/Video, composite).
>> There seems to be an implicit rule that 1 pin is always used
>> for composite, and the 3 others RGB, though.
>
> I'm not sure why we would need to rework this one though. We have no
> way to detect whether the screen is connected or not on either
> connectors, and we can't have both output running at the same time for
> the same reason than mention above.

I would like to add connector nodes. At least we can specify stuff
like what DAC outputs are used for which connector, what type of
connector, and a ddc bus for VGA connectors. I haven't worked out
the details though.

Regards
ChenYu

WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/7] drm/sun4i: Introduce A33 display driver
Date: Wed, 7 Sep 2016 12:49:58 +0800	[thread overview]
Message-ID: <CAGb2v660je7FAiXfeRb5Ynwtr8=fYDR1JHzrj2Hk+43_J0XRLg@mail.gmail.com> (raw)
In-Reply-To: <20160906185452.GI9040@lukather>

On Wed, Sep 7, 2016 at 2:54 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Sep 06, 2016 at 10:50:09AM +0800, Chen-Yu Tsai wrote:
>> >> The implementation might be along the lines of
>> >>
>> >>   1. having multiple output ports, each for a different interface type.
>> >>      (Some platforms go this route)
>> >>
>> >> Or
>> >>
>> >>   2. having a DT property describe what the output interface is.
>> >>
>> >> The RGB/TCON driver would then setup the registers accordingly.
>> >
>> > Hmmm, yeah, we would need to adjust the bindings too...
>> >
>> > I guess I'd prefer 1), but that would also be the most invasive
>> > solution. I'm not sure how the DT maintainers feel about that.
>>
>> I wonder if the TCON could use its 2 channels simultaneously?
>
> No, it's mutually exclusive.

I don't see how though. Are you referring to the IO_Map_Sel bit?
I assume that only controls the external output pins though.

>> Like output to one LCD, then mirror through HDMI/VGA?
>> The first option would be able to cover this better?
>
> Even if it wasn't exclusive, that wouldn't be possible
> unfortunately. Or rather, this would be possible if the LCD and the
> HDMI screen had the same timings, which is very unlikely.

What about an LCD-VGA bridge + HDMI in mirror mode on sun6i?
That should work.

>> And you still need to add outgoing endpoints for the HDMI block.
>
> Indeed.

On second thought, this particular one shouldn't affect the binding.

>
>> In addition we'll have to rework the TV encoder binding as well.
>>
>> The 2 TV encoders (on the A20) each have four DACs, which map
>> onto 4 external pins. The address space includes a not so easy
>> to use mux. More importantly, the binding needs to specify which
>> pin is used for what signal (RGB, YUV, S/Video, composite).
>> There seems to be an implicit rule that 1 pin is always used
>> for composite, and the 3 others RGB, though.
>
> I'm not sure why we would need to rework this one though. We have no
> way to detect whether the screen is connected or not on either
> connectors, and we can't have both output running at the same time for
> the same reason than mention above.

I would like to add connector nodes. At least we can specify stuff
like what DAC outputs are used for which connector, what type of
connector, and a ddc bus for VGA connectors. I haven't worked out
the details though.

Regards
ChenYu

WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>,
	Daniel Vetter
	<daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Thomas Petazzoni
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 0/7] drm/sun4i: Introduce A33 display driver
Date: Wed, 7 Sep 2016 12:49:58 +0800	[thread overview]
Message-ID: <CAGb2v660je7FAiXfeRb5Ynwtr8=fYDR1JHzrj2Hk+43_J0XRLg@mail.gmail.com> (raw)
In-Reply-To: <20160906185452.GI9040@lukather>

On Wed, Sep 7, 2016 at 2:54 AM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> On Tue, Sep 06, 2016 at 10:50:09AM +0800, Chen-Yu Tsai wrote:
>> >> The implementation might be along the lines of
>> >>
>> >>   1. having multiple output ports, each for a different interface type.
>> >>      (Some platforms go this route)
>> >>
>> >> Or
>> >>
>> >>   2. having a DT property describe what the output interface is.
>> >>
>> >> The RGB/TCON driver would then setup the registers accordingly.
>> >
>> > Hmmm, yeah, we would need to adjust the bindings too...
>> >
>> > I guess I'd prefer 1), but that would also be the most invasive
>> > solution. I'm not sure how the DT maintainers feel about that.
>>
>> I wonder if the TCON could use its 2 channels simultaneously?
>
> No, it's mutually exclusive.

I don't see how though. Are you referring to the IO_Map_Sel bit?
I assume that only controls the external output pins though.

>> Like output to one LCD, then mirror through HDMI/VGA?
>> The first option would be able to cover this better?
>
> Even if it wasn't exclusive, that wouldn't be possible
> unfortunately. Or rather, this would be possible if the LCD and the
> HDMI screen had the same timings, which is very unlikely.

What about an LCD-VGA bridge + HDMI in mirror mode on sun6i?
That should work.

>> And you still need to add outgoing endpoints for the HDMI block.
>
> Indeed.

On second thought, this particular one shouldn't affect the binding.

>
>> In addition we'll have to rework the TV encoder binding as well.
>>
>> The 2 TV encoders (on the A20) each have four DACs, which map
>> onto 4 external pins. The address space includes a not so easy
>> to use mux. More importantly, the binding needs to specify which
>> pin is used for what signal (RGB, YUV, S/Video, composite).
>> There seems to be an implicit rule that 1 pin is always used
>> for composite, and the 3 others RGB, though.
>
> I'm not sure why we would need to rework this one though. We have no
> way to detect whether the screen is connected or not on either
> connectors, and we can't have both output running at the same time for
> the same reason than mention above.

I would like to add connector nodes. At least we can specify stuff
like what DAC outputs are used for which connector, what type of
connector, and a ddc bus for VGA connectors. I haven't worked out
the details though.

Regards
ChenYu

  reply	other threads:[~2016-09-07  4:51 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 15:31 [PATCH 0/7] drm/sun4i: Introduce A33 display driver Maxime Ripard
2016-09-01 15:31 ` Maxime Ripard
2016-09-01 15:31 ` Maxime Ripard
2016-09-01 15:31 ` [PATCH 1/7] drm/sun4i: support TCONs without channel 1 Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-02  1:47   ` Chen-Yu Tsai
2016-09-02  1:47     ` Chen-Yu Tsai
2016-09-02  1:47     ` Chen-Yu Tsai
2016-09-01 15:31 ` [PATCH 2/7] drm/sun4i: support A33 tcon Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-01 15:31   ` Maxime Ripard
2016-09-02  6:02   ` Chen-Yu Tsai
2016-09-02  6:02     ` Chen-Yu Tsai
2016-09-02  6:02     ` Chen-Yu Tsai
2016-09-05 20:22     ` Maxime Ripard
2016-09-05 20:22       ` Maxime Ripard
2016-09-05 20:22       ` Maxime Ripard
2016-09-01 15:32 ` [PATCH 3/7] drm/sun4i: Add SAT and DRC drivers Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  6:45   ` Chen-Yu Tsai
2016-09-02  6:45     ` Chen-Yu Tsai
2016-09-02  6:45     ` Chen-Yu Tsai
2016-09-05 20:27     ` Maxime Ripard
2016-09-05 20:27       ` Maxime Ripard
2016-09-05 20:27       ` Maxime Ripard
2016-09-04 20:03   ` [linux-sunxi] " Peter Korsgaard
2016-09-04 20:03     ` Peter Korsgaard
2016-09-04 20:03     ` [linux-sunxi] " Peter Korsgaard
2016-09-06 13:59     ` Maxime Ripard
2016-09-06 13:59       ` Maxime Ripard
2016-09-06 13:59       ` [linux-sunxi] " Maxime Ripard
2016-09-01 15:32 ` [PATCH 4/7] drm/panel: Add Sinlinx SinA33 7" panel Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  7:01   ` Chen-Yu Tsai
2016-09-02  7:01     ` Chen-Yu Tsai
2016-09-04 17:03   ` Icenowy Zheng
2016-09-04 17:03     ` Icenowy Zheng
2016-09-05 20:02     ` Maxime Ripard
2016-09-05 20:02       ` Maxime Ripard
2016-09-05 20:02       ` Maxime Ripard
2016-09-06  2:53       ` Chen-Yu Tsai
2016-09-06  2:53         ` Chen-Yu Tsai
2016-09-06  2:53         ` Chen-Yu Tsai
2016-09-06  9:12       ` Thierry Reding
2016-09-06  9:12         ` Thierry Reding
2016-09-06  9:12         ` Thierry Reding
2016-09-06 14:33         ` Maxime Ripard
2016-09-06 14:33           ` Maxime Ripard
2016-09-06 14:33           ` Maxime Ripard
2016-09-01 15:32 ` [PATCH 5/7] ARM: sun8i: a33: Add display pipeline Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  6:28   ` Chen-Yu Tsai
2016-09-02  6:28     ` Chen-Yu Tsai
2016-09-02  6:28     ` Chen-Yu Tsai
2016-09-05 20:21     ` Maxime Ripard
2016-09-05 20:21       ` Maxime Ripard
2016-09-05 20:21       ` Maxime Ripard
2016-09-06  2:51       ` Chen-Yu Tsai
2016-09-06  2:51         ` Chen-Yu Tsai
2016-09-06  2:51         ` Chen-Yu Tsai
2016-09-01 15:32 ` [PATCH 6/7] ARM: sun8i: a33: Add RGB666 pins Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  1:44   ` [linux-sunxi] " Chen-Yu Tsai
2016-09-02  1:44     ` Chen-Yu Tsai
2016-09-02  1:44     ` [linux-sunxi] " Chen-Yu Tsai
2016-09-01 15:32 ` [PATCH 7/7] ARM: sun8i: sina33: Enable display Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-01 15:32   ` Maxime Ripard
2016-09-02  1:30 ` [PATCH 0/7] drm/sun4i: Introduce A33 display driver Icenowy Zheng
2016-09-02  1:30   ` Icenowy Zheng
2016-09-02 19:06   ` Maxime Ripard
2016-09-02 19:06     ` Maxime Ripard
2016-09-02 19:06     ` Maxime Ripard
2016-09-03  1:43     ` Chen-Yu Tsai
2016-09-03  1:43       ` Chen-Yu Tsai
2016-09-03  1:43       ` Chen-Yu Tsai
2016-09-05 20:37       ` Maxime Ripard
2016-09-05 20:37         ` Maxime Ripard
2016-09-05 20:37         ` Maxime Ripard
2016-09-06  2:50         ` Chen-Yu Tsai
2016-09-06  2:50           ` Chen-Yu Tsai
2016-09-06  2:50           ` Chen-Yu Tsai
2016-09-06 18:54           ` Maxime Ripard
2016-09-06 18:54             ` Maxime Ripard
2016-09-06 18:54             ` Maxime Ripard
2016-09-07  4:49             ` Chen-Yu Tsai [this message]
2016-09-07  4:49               ` Chen-Yu Tsai
2016-09-07  4:49               ` Chen-Yu Tsai
2016-09-12  9:56               ` Maxime Ripard
2016-09-12  9:56                 ` Maxime Ripard
2016-09-12  9:56                 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGb2v660je7FAiXfeRb5Ynwtr8=fYDR1JHzrj2Hk+43_J0XRLg@mail.gmail.com' \
    --to=wens@csie.org \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.