From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
maxime.ripard@free-electrons.com, wens@csie.org,
linux@armlinux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver
Date: Fri, 9 Sep 2016 16:15:27 +0200 [thread overview]
Message-ID: <20160909141527.GE30871@lunn.ch> (raw)
In-Reply-To: <1473425117-18645-2-git-send-email-clabbe.montjoie@gmail.com>
Hi Corentin
> +static int sun8i_emac_mdio_register(struct net_device *ndev)
> +{
> + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> + struct mii_bus *bus;
> + int ret;
> +
> + bus = mdiobus_alloc();
You can use devm_mdiobus_alloc() which will simplify your error
handling and unregister code.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver
Date: Fri, 9 Sep 2016 16:15:27 +0200 [thread overview]
Message-ID: <20160909141527.GE30871@lunn.ch> (raw)
In-Reply-To: <1473425117-18645-2-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Hi Corentin
> +static int sun8i_emac_mdio_register(struct net_device *ndev)
> +{
> + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> + struct mii_bus *bus;
> + int ret;
> +
> + bus = mdiobus_alloc();
You can use devm_mdiobus_alloc() which will simplify your error
handling and unregister code.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/9] ethernet: add sun8i-emac driver
Date: Fri, 9 Sep 2016 16:15:27 +0200 [thread overview]
Message-ID: <20160909141527.GE30871@lunn.ch> (raw)
In-Reply-To: <1473425117-18645-2-git-send-email-clabbe.montjoie@gmail.com>
Hi Corentin
> +static int sun8i_emac_mdio_register(struct net_device *ndev)
> +{
> + struct sun8i_emac_priv *priv = netdev_priv(ndev);
> + struct mii_bus *bus;
> + int ret;
> +
> + bus = mdiobus_alloc();
You can use devm_mdiobus_alloc() which will simplify your error
handling and unregister code.
Andrew
next prev parent reply other threads:[~2016-09-09 14:16 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 12:45 [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 1/9] " Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 14:15 ` Andrew Lunn [this message]
2016-09-09 14:15 ` Andrew Lunn
2016-09-09 14:15 ` Andrew Lunn
2016-09-13 13:33 ` LABBE Corentin
2016-09-13 13:33 ` LABBE Corentin
2016-09-13 13:33 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 2/9] MAINTAINERS: Add myself as maintainer of sun8i-emac Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 14:04 ` Andrew Lunn
2016-09-09 14:04 ` Andrew Lunn
2016-09-09 14:04 ` Andrew Lunn
2016-09-12 15:01 ` LABBE Corentin
2016-09-12 15:01 ` LABBE Corentin
2016-09-12 15:15 ` Andrew Lunn
2016-09-12 15:15 ` Andrew Lunn
2016-09-09 14:17 ` Andrew Lunn
2016-09-09 14:17 ` Andrew Lunn
2016-09-13 13:34 ` LABBE Corentin
2016-09-13 13:34 ` LABBE Corentin
2016-09-13 14:12 ` Andrew Lunn
2016-09-13 14:12 ` Andrew Lunn
2016-09-09 12:45 ` [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:28 ` Maxime Ripard
2016-09-12 7:28 ` Maxime Ripard
2016-09-13 13:38 ` LABBE Corentin
2016-09-13 13:38 ` LABBE Corentin
2016-09-13 13:38 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:29 ` Maxime Ripard
2016-09-12 7:29 ` Maxime Ripard
2016-09-12 7:29 ` Maxime Ripard
2016-09-14 8:54 ` LABBE Corentin
2016-09-14 8:54 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 6/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 7/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:30 ` Maxime Ripard
2016-09-12 7:30 ` Maxime Ripard
2016-09-12 7:30 ` Maxime Ripard
2016-09-13 13:42 ` LABBE Corentin
2016-09-13 13:42 ` LABBE Corentin
2016-09-13 13:42 ` LABBE Corentin
2016-09-09 12:45 ` [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 20:44 ` Maxime Ripard
2016-09-12 20:44 ` Maxime Ripard
2016-09-14 14:03 ` LABBE Corentin
2016-09-14 14:03 ` LABBE Corentin
2016-09-14 14:03 ` LABBE Corentin
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 16:50 ` Florian Fainelli
2016-09-17 16:50 ` Florian Fainelli
2016-09-17 16:50 ` Florian Fainelli
2016-09-10 3:58 ` [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver David Miller
2016-09-10 3:58 ` David Miller
2016-09-10 3:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909141527.GE30871@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.