From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
linux@armlinux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module
Date: Mon, 12 Sep 2016 09:28:12 +0200 [thread overview]
Message-ID: <20160912072812.GB9449@lukather> (raw)
In-Reply-To: <1473425117-18645-5-git-send-email-clabbe.montjoie@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote:
> This patch add the dt node for the syscon register present on the
> Allwinner H3.
>
> Only two register are present in this syscon and the only one useful is
> the one dedicated to EMAC clock.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index fdf9fdb..a39da6f 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -140,6 +140,11 @@
> #size-cells = <1>;
> ranges;
>
> + syscon: syscon@01c00000 {
> + compatible = "syscon";
Having our compatible would be nice here. syscon doesn't mean anything
by itself.
> + reg = <0x01c00000 0x34>;
And the size of our system controller is 0x1000
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module
Date: Mon, 12 Sep 2016 09:28:12 +0200 [thread overview]
Message-ID: <20160912072812.GB9449@lukather> (raw)
In-Reply-To: <1473425117-18645-5-git-send-email-clabbe.montjoie@gmail.com>
On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote:
> This patch add the dt node for the syscon register present on the
> Allwinner H3.
>
> Only two register are present in this syscon and the only one useful is
> the one dedicated to EMAC clock.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index fdf9fdb..a39da6f 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -140,6 +140,11 @@
> #size-cells = <1>;
> ranges;
>
> + syscon: syscon at 01c00000 {
> + compatible = "syscon";
Having our compatible would be nice here. syscon doesn't mean anything
by itself.
> + reg = <0x01c00000 0x34>;
And the size of our system controller is 0x1000
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160912/b888ced4/attachment.sig>
next prev parent reply other threads:[~2016-09-12 7:28 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 12:45 [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 1/9] " Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 14:15 ` Andrew Lunn
2016-09-09 14:15 ` Andrew Lunn
2016-09-09 14:15 ` Andrew Lunn
2016-09-13 13:33 ` LABBE Corentin
2016-09-13 13:33 ` LABBE Corentin
2016-09-13 13:33 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 2/9] MAINTAINERS: Add myself as maintainer of sun8i-emac Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 14:04 ` Andrew Lunn
2016-09-09 14:04 ` Andrew Lunn
2016-09-09 14:04 ` Andrew Lunn
2016-09-12 15:01 ` LABBE Corentin
2016-09-12 15:01 ` LABBE Corentin
2016-09-12 15:15 ` Andrew Lunn
2016-09-12 15:15 ` Andrew Lunn
2016-09-09 14:17 ` Andrew Lunn
2016-09-09 14:17 ` Andrew Lunn
2016-09-13 13:34 ` LABBE Corentin
2016-09-13 13:34 ` LABBE Corentin
2016-09-13 14:12 ` Andrew Lunn
2016-09-13 14:12 ` Andrew Lunn
2016-09-09 12:45 ` [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:28 ` Maxime Ripard [this message]
2016-09-12 7:28 ` Maxime Ripard
2016-09-13 13:38 ` LABBE Corentin
2016-09-13 13:38 ` LABBE Corentin
2016-09-13 13:38 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:29 ` Maxime Ripard
2016-09-12 7:29 ` Maxime Ripard
2016-09-12 7:29 ` Maxime Ripard
2016-09-14 8:54 ` LABBE Corentin
2016-09-14 8:54 ` LABBE Corentin
2016-09-09 12:45 ` [PATCH v3 6/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 7/9] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI One Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-09 12:45 ` [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 7:30 ` Maxime Ripard
2016-09-12 7:30 ` Maxime Ripard
2016-09-12 7:30 ` Maxime Ripard
2016-09-13 13:42 ` LABBE Corentin
2016-09-13 13:42 ` LABBE Corentin
2016-09-13 13:42 ` LABBE Corentin
2016-09-09 12:45 ` [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support Corentin Labbe
2016-09-09 12:45 ` Corentin Labbe
2016-09-12 20:44 ` Maxime Ripard
2016-09-12 20:44 ` Maxime Ripard
2016-09-14 14:03 ` LABBE Corentin
2016-09-14 14:03 ` LABBE Corentin
2016-09-14 14:03 ` LABBE Corentin
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 13:40 ` Maxime Ripard
2016-09-17 16:50 ` Florian Fainelli
2016-09-17 16:50 ` Florian Fainelli
2016-09-17 16:50 ` Florian Fainelli
2016-09-10 3:58 ` [PATCH v3 0/9] net-next: ethernet: add sun8i-emac driver David Miller
2016-09-10 3:58 ` David Miller
2016-09-10 3:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912072812.GB9449@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.