* [PATCH] staging: emxx_udc: Remove unnecessary blank line
@ 2016-09-12 10:07 Rehas Sachdeva
2016-09-12 10:17 ` [Outreachy kernel] " Julia Lawall
2016-09-12 10:24 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Rehas Sachdeva @ 2016-09-12 10:07 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index f4d9000..f6233ec 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
reg_data = _nbu2ss_readl(
(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
-
}
spin_lock(&udc->lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Remove unnecessary blank line
2016-09-12 10:07 [PATCH] staging: emxx_udc: Remove unnecessary blank line Rehas Sachdeva
@ 2016-09-12 10:17 ` Julia Lawall
2016-09-12 10:24 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2016-09-12 10:17 UTC (permalink / raw)
To: Rehas Sachdeva; +Cc: outreachy-kernel
On Mon, 12 Sep 2016, Rehas Sachdeva wrote:
> This patch fixes the checkpatch.pl warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
> index f4d9000..f6233ec 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
> reg_data = _nbu2ss_readl(
> (u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
> dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
> -
> }
>
> spin_lock(&udc->lock);
This looks like a good start :)
For this round, however, you should also submit the patch to the
maintainers of the file, as described here:
https://kernelnewbies.org/FirstKernelPatch#submit_a_patch
The tutorial was just updated with this information yesterday, so you may
have missed it, if you got started before.
julia
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: emxx_udc: Remove unnecessary blank line
2016-09-12 10:07 [PATCH] staging: emxx_udc: Remove unnecessary blank line Rehas Sachdeva
2016-09-12 10:17 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-12 10:24 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-09-12 10:24 UTC (permalink / raw)
To: Rehas Sachdeva; +Cc: outreachy-kernel
On Mon, Sep 12, 2016 at 03:37:37PM +0530, Rehas Sachdeva wrote:
> This patch fixes the checkpatch.pl warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 1 -
> 1 file changed, 1 deletion(-)
Nice job, but you forgot to also cc: the maintainer of this file.
Oh, that's me, hm, nevermind...
now applied, nice work as the first submitted patch of the application
process, and also the first accepted one into the kernel tree :)
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: emxx_udc: Remove unnecessary blank line
2016-09-12 10:17 Rehas Sachdeva
@ 2016-09-12 10:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-12 10:30 UTC (permalink / raw)
To: Rehas Sachdeva; +Cc: devel, linux-kernel
On Mon, Sep 12, 2016 at 03:47:12PM +0530, Rehas Sachdeva wrote:
> This patch fixes the checkpatch.pl warning:
> Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 1 -
> 1 file changed, 1 deletion(-)
You just sent this patch earlier, why send it again?
confused,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: emxx_udc: Remove unnecessary blank line
@ 2016-09-12 10:17 Rehas Sachdeva
2016-09-12 10:30 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Rehas Sachdeva @ 2016-09-12 10:17 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel
This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index f4d9000..f6233ec 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
reg_data = _nbu2ss_readl(
(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
-
}
spin_lock(&udc->lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-12 10:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 10:07 [PATCH] staging: emxx_udc: Remove unnecessary blank line Rehas Sachdeva
2016-09-12 10:17 ` [Outreachy kernel] " Julia Lawall
2016-09-12 10:24 ` Greg KH
2016-09-12 10:17 Rehas Sachdeva
2016-09-12 10:30 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.