All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: speakup: Use x instead of x != NULL.
@ 2016-09-14  8:58 Sandhya Bankar
  2016-09-14  9:04 ` [Outreachy kernel] " Vaishali Thakkar
  0 siblings, 1 reply; 4+ messages in thread
From: Sandhya Bankar @ 2016-09-14  8:58 UTC (permalink / raw)
  To: outreachy-kernel

Use x instead of x != NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/speakup/fakekey.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
index 8f058b4..032b936 100644
--- a/drivers/staging/speakup/fakekey.c
+++ b/drivers/staging/speakup/fakekey.c
@@ -56,7 +56,7 @@ int speakup_add_virtual_keyboard(void)
 
 void speakup_remove_virtual_keyboard(void)
 {
-	if (virt_keyboard != NULL) {
+	if (virt_keyboard) {
 		input_unregister_device(virt_keyboard);
 		virt_keyboard = NULL;
 	}
-- 
1.8.2.3



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: speakup: Use x instead of x != NULL.
  2016-09-14  8:58 [PATCH] Staging: speakup: Use x instead of x != NULL Sandhya Bankar
@ 2016-09-14  9:04 ` Vaishali Thakkar
  2016-09-14  9:08   ` Sandhya Bankar
  0 siblings, 1 reply; 4+ messages in thread
From: Vaishali Thakkar @ 2016-09-14  9:04 UTC (permalink / raw)
  To: Sandhya Bankar; +Cc: outreachy-kernel

Hi,

On Wed, Sep 14, 2016 at 2:28 PM, Sandhya Bankar
<bankarsandhya512@gmail.com> wrote:
> Use x instead of x != NULL.

Commit log should contain the information about why doing this change is good
instead of what you are doing. Also, if you have used any tool for detecting or
solving the issue then probably writing something like 'Issue found using x'
would be useful. :)

Thanks

> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/speakup/fakekey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/fakekey.c b/drivers/staging/speakup/fakekey.c
> index 8f058b4..032b936 100644
> --- a/drivers/staging/speakup/fakekey.c
> +++ b/drivers/staging/speakup/fakekey.c
> @@ -56,7 +56,7 @@ int speakup_add_virtual_keyboard(void)
>
>  void speakup_remove_virtual_keyboard(void)
>  {
> -       if (virt_keyboard != NULL) {
> +       if (virt_keyboard) {
>                 input_unregister_device(virt_keyboard);
>                 virt_keyboard = NULL;
>         }
> --
> 1.8.2.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914085822.GA2558%40sandhya.
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali
http://vaishalithakkar.in/


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: speakup: Use x instead of x != NULL.
  2016-09-14  9:04 ` [Outreachy kernel] " Vaishali Thakkar
@ 2016-09-14  9:08   ` Sandhya Bankar
  2016-09-14  9:19     ` Vaishali Thakkar
  0 siblings, 1 reply; 4+ messages in thread
From: Sandhya Bankar @ 2016-09-14  9:08 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: bankarsandhya512


[-- Attachment #1.1: Type: text/plain, Size: 1961 bytes --]



Thank you for quick reply . Shall I send it with v2 with adding commit log 
information?




On Wednesday, September 14, 2016 at 2:34:07 PM UTC+5:30, Vaishali Thakkar 
wrote:
>
> Hi, 
>
> On Wed, Sep 14, 2016 at 2:28 PM, Sandhya Bankar 
> <bankarsa...@gmail.com <javascript:>> wrote: 
> > Use x instead of x != NULL. 
>
> Commit log should contain the information about why doing this change is 
> good 
> instead of what you are doing. Also, if you have used any tool for 
> detecting or 
> solving the issue then probably writing something like 'Issue found using 
> x' 
> would be useful. :) 
>
> Thanks 
>
> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/speakup/fakekey.c | 2 +- 
> >  1 file changed, 1 insertion(+), 1 deletion(-) 
> > 
> > diff --git a/drivers/staging/speakup/fakekey.c 
> b/drivers/staging/speakup/fakekey.c 
> > index 8f058b4..032b936 100644 
> > --- a/drivers/staging/speakup/fakekey.c 
> > +++ b/drivers/staging/speakup/fakekey.c 
> > @@ -56,7 +56,7 @@ int speakup_add_virtual_keyboard(void) 
> > 
> >  void speakup_remove_virtual_keyboard(void) 
> >  { 
> > -       if (virt_keyboard != NULL) { 
> > +       if (virt_keyboard) { 
> >                 input_unregister_device(virt_keyboard); 
> >                 virt_keyboard = NULL; 
> >         } 
> > -- 
> > 1.8.2.3 
> > 
> > -- 
> > You received this message because you are subscribed to the Google 
> Groups "outreachy-kernel" group. 
> > To unsubscribe from this group and stop receiving emails from it, send 
> an email to outreachy-kern...@googlegroups.com <javascript:>. 
> > To post to this group, send email to outreach...@googlegroups.com 
> <javascript:>. 
> > To view this discussion on the web visit 
> https://groups.google.com/d/msgid/outreachy-kernel/20160914085822.GA2558%40sandhya. 
>
> > For more options, visit https://groups.google.com/d/optout. 
>
>
>
> -- 
> Vaishali 
> http://vaishalithakkar.in/ 
>

[-- Attachment #1.2: Type: text/html, Size: 4252 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: speakup: Use x instead of x != NULL.
  2016-09-14  9:08   ` Sandhya Bankar
@ 2016-09-14  9:19     ` Vaishali Thakkar
  0 siblings, 0 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2016-09-14  9:19 UTC (permalink / raw)
  To: Sandhya Bankar; +Cc: outreachy-kernel

On Wed, Sep 14, 2016 at 2:38 PM, Sandhya Bankar
<bankarsandhya512@gmail.com> wrote:
>
>
> Thank you for quick reply . Shall I send it with v2 with adding commit log
> information?
>

Yes, please.

Also, do not top-post while replying to mails.

>
>
> On Wednesday, September 14, 2016 at 2:34:07 PM UTC+5:30, Vaishali Thakkar
> wrote:
>>
>> Hi,
>>
>> On Wed, Sep 14, 2016 at 2:28 PM, Sandhya Bankar
>> <bankarsa...@gmail.com> wrote:
>> > Use x instead of x != NULL.
>>
>> Commit log should contain the information about why doing this change is
>> good
>> instead of what you are doing. Also, if you have used any tool for
>> detecting or
>> solving the issue then probably writing something like 'Issue found using
>> x'
>> would be useful. :)
>>
>> Thanks
>>
>> > Signed-off-by: Sandhya Bankar <bankarsa...@gmail.com>
>> > ---
>> >  drivers/staging/speakup/fakekey.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/staging/speakup/fakekey.c
>> > b/drivers/staging/speakup/fakekey.c
>> > index 8f058b4..032b936 100644
>> > --- a/drivers/staging/speakup/fakekey.c
>> > +++ b/drivers/staging/speakup/fakekey.c
>> > @@ -56,7 +56,7 @@ int speakup_add_virtual_keyboard(void)
>> >
>> >  void speakup_remove_virtual_keyboard(void)
>> >  {
>> > -       if (virt_keyboard != NULL) {
>> > +       if (virt_keyboard) {
>> >                 input_unregister_device(virt_keyboard);
>> >                 virt_keyboard = NULL;
>> >         }
>> > --
>> > 1.8.2.3
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups "outreachy-kernel" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an email to outreachy-kern...@googlegroups.com.
>> > To post to this group, send email to outreach...@googlegroups.com.
>> > To view this discussion on the web visit
>> > https://groups.google.com/d/msgid/outreachy-kernel/20160914085822.GA2558%40sandhya.
>> > For more options, visit https://groups.google.com/d/optout.
>>
>>
>>
>> --
>> Vaishali
>> http://vaishalithakkar.in/
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/0475959f-954a-445b-a442-64a01d6348c0%40googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.



-- 
Vaishali
http://vaishalithakkar.in/


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-14  9:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  8:58 [PATCH] Staging: speakup: Use x instead of x != NULL Sandhya Bankar
2016-09-14  9:04 ` [Outreachy kernel] " Vaishali Thakkar
2016-09-14  9:08   ` Sandhya Bankar
2016-09-14  9:19     ` Vaishali Thakkar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.