All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
@ 2016-06-11 20:10 kbuild test robot
  2016-09-08 17:45 ` Tony Lindgren
  0 siblings, 1 reply; 8+ messages in thread
From: kbuild test robot @ 2016-06-11 20:10 UTC (permalink / raw)
  Cc: kbuild-all, linux-kernel, Felipe Balbi, Tony Lindgren

[-- Attachment #1: Type: text/plain, Size: 16695 bytes --]

Hi,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   45b00c94be33db5d00595046663163ce55cbbfb9
commit: d026e9c76aac3632af174cf02d5c94defa5e6026 usb: musb: Change end point selection to use new IO access
date:   1 year, 7 months ago
config: blackfin-allmodconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 4.6.3
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout d026e9c76aac3632af174cf02d5c94defa5e6026
        # save the attached .config to linux build tree
        make.cross ARCH=blackfin 

All errors (new ones prefixed by >>):

   drivers/usb/musb/tusb6010.c: In function 'tusb_get_revision':
   drivers/usb/musb/tusb6010.c:53:26: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:53:26: note: each undeclared identifier is reported only once for each function it appears in
   drivers/usb/musb/tusb6010.c:55:3: error: implicit declaration of function 'TUSB_DIDR1_HI_CHIP_REV' [-Werror=implicit-function-declaration]
   drivers/usb/musb/tusb6010.c:56:5: error: 'TUSB_DIDR1_HI' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:57:17: error: 'TUSB_DIDR1_HI_REV_31' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_print_revision':
   drivers/usb/musb/tusb6010.c:71:2: error: 'TUSB_PRCM_REV' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:71:2: error: 'TUSB_INT_CTRL_REV' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:71:2: error: 'TUSB_GPIO_REV' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:71:2: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:71:2: error: 'TUSB_DIDR1_HI' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_wbus_quirk':
   drivers/usb/musb/tusb6010.c:104:36: error: 'TUSB_PHY_OTG_CTRL' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:105:35: error: 'TUSB_PHY_OTG_CTRL_ENABLE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:106:9: error: 'TUSB_PHY_OTG_CTRL_WRPROTECT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:107:21: error: 'TUSB_PHY_OTG_CTRL_TESTM2' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:107:21: error: 'TUSB_PHY_OTG_CTRL_TESTM1' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:107:21: error: 'TUSB_PHY_OTG_CTRL_TESTM0' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_ep_select':
>> drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:142:21: error: 'USB_FADDR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_write_fifo':
   drivers/usb/musb/tusb6010.c:235:24: error: 'TUSB_EP_TX_OFFSET' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:236:4: error: implicit declaration of function 'TUSB_EP_CONFIG_XFR_SIZE' [-Werror=implicit-function-declaration]
   drivers/usb/musb/tusb6010.c:238:27: error: 'TUSB_EP0_CONFIG_DIR_TX' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:239:4: error: implicit declaration of function 'TUSB_EP0_CONFIG_XFR_SIZE' [-Werror=implicit-function-declaration]
   drivers/usb/musb/tusb6010.c: In function 'tusb_read_fifo':
   drivers/usb/musb/tusb6010.c:283:24: error: 'TUSB_EP_RX_OFFSET' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_draw_power':
   drivers/usb/musb/tusb6010.c:346:26: error: 'TUSB_PRCM_MNGMT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:349:10: error: 'TUSB_PRCM_MNGMT_15_SW_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:349:37: error: 'TUSB_PRCM_MNGMT_33_SW_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_set_clock_source':
   drivers/usb/musb/tusb6010.c:369:26: error: 'TUSB_PRCM_CONF' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:370:2: error: implicit declaration of function 'TUSB_PRCM_CONF_SYS_CLKSEL' [-Werror=implicit-function-declaration]
   drivers/usb/musb/tusb6010.c: In function 'tusb_allow_idle':
   drivers/usb/musb/tusb6010.c:396:24: error: 'TUSB_PRCM_WBUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:397:31: error: 'TUSB_REV_30' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:402:20: error: 'TUSB_PRCM_WNORCS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:403:21: error: 'TUSB_PRCM_WAKEUP_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:410:26: error: 'TUSB_PRCM_MNGMT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:413:10: error: 'TUSB_PRCM_MNGMT_OTG_VBUS_DET_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:414:11: error: 'TUSB_PRCM_MNGMT_OTG_SESS_END_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:419:9: error: 'TUSB_PRCM_MNGMT_PM_IDLE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:419:35: error: 'TUSB_PRCM_MNGMT_DEV_IDLE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_musb_vbus_status':
   drivers/usb/musb/tusb6010.c:434:31: error: 'TUSB_DEV_OTG_STAT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:435:33: error: 'TUSB_PRCM_MNGMT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:441:21: error: 'TUSB_PRCM_MNGMT_OTG_VBUS_DET_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:449:17: error: 'TUSB_DEV_OTG_STAT_VBUS_VALID' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'musb_do_idle':
   drivers/usb/musb/tusb6010.c:489:14: error: 'TUSB_PRCM_WHOSTDISCON' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:490:7: error: 'TUSB_PRCM_WBUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:491:8: error: 'TUSB_PRCM_WVBUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:492:15: error: 'TUSB_PRCM_WID' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_musb_set_vbus':
   drivers/usb/musb/tusb6010.c:566:27: error: 'TUSB_PRCM_MNGMT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:567:27: error: 'TUSB_DEV_CONF' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:568:35: error: 'USB_OTG_DEV_CTL' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:568:35: error: 'USB_FADDR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:571:3: error: implicit declaration of function 'TUSB_DEV_OTG_TIMER_VAL' [-Werror=implicit-function-declaration]
   drivers/usb/musb/tusb6010.c:571:11: error: 'TUSB_DEV_OTG_TIMER_ENABLE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:576:11: error: 'TUSB_DEV_CONF_USB_HOST_MODE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:584:32: error: 'TUSB_DEV_OTG_STAT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:585:20: error: 'TUSB_DEV_OTG_STAT_ID_STATUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:610:12: error: 'TUSB_PRCM_MNGMT_15_SW_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:610:39: error: 'TUSB_PRCM_MNGMT_33_SW_EN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:613:21: error: 'TUSB_DEV_OTG_TIMER' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_musb_set_mode':
   drivers/usb/musb/tusb6010.c:636:31: error: 'TUSB_DEV_OTG_STAT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:637:35: error: 'TUSB_PHY_OTG_CTRL' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:638:34: error: 'TUSB_PHY_OTG_CTRL_ENABLE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:639:31: error: 'TUSB_DEV_CONF' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:644:20: error: 'TUSB_PHY_OTG_CTRL_OTG_ID_PULLUP' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:646:15: error: 'TUSB_DEV_CONF_ID_SEL' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:647:16: error: 'TUSB_DEV_CONF_SOFT_ID' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:666:4: error: 'TUSB_PHY_OTG_CTRL_WRPROTECT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:673:16: error: 'TUSB_DEV_OTG_STAT_ID_STATUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_otg_ints':
   drivers/usb/musb/tusb6010.c:683:36: error: 'TUSB_DEV_OTG_STAT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:688:17: error: 'TUSB_INT_SRC_ID_STATUS_CHNG' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:691:28: error: 'TUSB_DEV_OTG_STAT_ID_STATUS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:702:16: error: 'TUSB_INT_SRC_VBUS_SENSE_CHNG' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:715:19: error: 'TUSB_DEV_OTG_STAT_SESS_END' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:776:16: error: 'TUSB_INT_SRC_OTG_TIMEOUT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:787:37: error: 'USB_OTG_DEV_CTL' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:787:37: error: 'USB_FADDR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:788:19: error: 'TUSB_DEV_OTG_STAT_VBUS_VALID' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_musb_interrupt':
   drivers/usb/musb/tusb6010.c:832:31: error: 'TUSB_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:833:37: error: 'TUSB_INT_MASK_RESERVED_BITS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:835:30: error: 'TUSB_INT_SRC' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:835:47: error: 'TUSB_INT_SRC_RESERVED_BITS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:841:16: error: 'TUSB_INT_SRC_DEV_WAKEUP' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:845:30: error: 'TUSB_REV_30' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:852:23: error: 'TUSB_SCRATCH_PAD' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:863:27: error: 'TUSB_PRCM_WAKEUP_SOURCE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:864:22: error: 'TUSB_PRCM_WAKEUP_CLEAR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:865:14: error: 'TUSB_PRCM_WNORCS' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:875:16: error: 'TUSB_INT_SRC_USB_IP_CONN' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:879:17: error: 'TUSB_INT_SRC_VBUS_SENSE_CHNG' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:880:7: error: 'TUSB_INT_SRC_OTG_TIMEOUT' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:881:7: error: 'TUSB_INT_SRC_ID_STATUS_CHNG' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:887:17: error: 'TUSB_INT_SRC_TXRX_DMA_DONE' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:888:35: error: 'TUSB_DMA_INT_SRC' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:889:40: error: 'TUSB_DMA_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:904:22: error: 'TUSB_DMA_INT_CLEAR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:908:17: error: 'TUSB_INT_SRC_USB_IP_TX' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:908:42: error: 'TUSB_INT_SRC_USB_IP_RX' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:909:36: error: 'TUSB_USBIP_INT_SRC' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:911:22: error: 'TUSB_USBIP_INT_CLEAR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:923:21: error: 'TUSB_INT_SRC_CLEAR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c: In function 'tusb_musb_enable':
   drivers/usb/musb/tusb6010.c:947:21: error: 'TUSB_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:947:36: error: 'TUSB_INT_SRC_USB_IP_SOF' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:950:21: error: 'TUSB_USBIP_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:951:21: error: 'TUSB_DMA_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:952:21: error: 'TUSB_GPIO_INT_MASK' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:955:21: error: 'TUSB_USBIP_INT_CLEAR' undeclared (first use in this function)
   drivers/usb/musb/tusb6010.c:956:21: error: 'TUSB_DMA_INT_CLEAR' undeclared (first use in this function)

vim +/USB_INDEX +142 drivers/usb/musb/tusb6010.c

    65	{
    66		void __iomem	*tbase = musb->ctrl_base;
    67		u8		rev;
    68	
    69		rev = musb->tusb_revision;
    70	
  > 71		pr_info("tusb: %s%i.%i %s%i.%i %s%i.%i %s%i.%i %s%i %s%i.%i\n",
    72			"prcm",
    73			TUSB_REV_MAJOR(musb_readl(tbase, TUSB_PRCM_REV)),
    74			TUSB_REV_MINOR(musb_readl(tbase, TUSB_PRCM_REV)),
    75			"int",
    76			TUSB_REV_MAJOR(musb_readl(tbase, TUSB_INT_CTRL_REV)),
    77			TUSB_REV_MINOR(musb_readl(tbase, TUSB_INT_CTRL_REV)),
    78			"gpio",
    79			TUSB_REV_MAJOR(musb_readl(tbase, TUSB_GPIO_REV)),
    80			TUSB_REV_MINOR(musb_readl(tbase, TUSB_GPIO_REV)),
    81			"dma",
    82			TUSB_REV_MAJOR(musb_readl(tbase, TUSB_DMA_CTRL_REV)),
    83			TUSB_REV_MINOR(musb_readl(tbase, TUSB_DMA_CTRL_REV)),
    84			"dieid",
    85			TUSB_DIDR1_HI_CHIP_REV(musb_readl(tbase, TUSB_DIDR1_HI)),
    86			"rev",
    87			TUSB_REV_MAJOR(rev), TUSB_REV_MINOR(rev));
    88	}
    89	
    90	#define WBUS_QUIRK_MASK	(TUSB_PHY_OTG_CTRL_TESTM2 | TUSB_PHY_OTG_CTRL_TESTM1 \
    91					| TUSB_PHY_OTG_CTRL_TESTM0)
    92	
    93	/*
    94	 * Workaround for spontaneous WBUS wake-up issue #2 for tusb3.0.
    95	 * Disables power detection in PHY for the duration of idle.
    96	 */
    97	static void tusb_wbus_quirk(struct musb *musb, int enabled)
    98	{
    99		void __iomem	*tbase = musb->ctrl_base;
   100		static u32	phy_otg_ctrl, phy_otg_ena;
   101		u32		tmp;
   102	
   103		if (enabled) {
   104			phy_otg_ctrl = musb_readl(tbase, TUSB_PHY_OTG_CTRL);
   105			phy_otg_ena = musb_readl(tbase, TUSB_PHY_OTG_CTRL_ENABLE);
   106			tmp = TUSB_PHY_OTG_CTRL_WRPROTECT
   107					| phy_otg_ena | WBUS_QUIRK_MASK;
   108			musb_writel(tbase, TUSB_PHY_OTG_CTRL, tmp);
   109			tmp = phy_otg_ena & ~WBUS_QUIRK_MASK;
   110			tmp |= TUSB_PHY_OTG_CTRL_WRPROTECT | TUSB_PHY_OTG_CTRL_TESTM2;
   111			musb_writel(tbase, TUSB_PHY_OTG_CTRL_ENABLE, tmp);
   112			dev_dbg(musb->controller, "Enabled tusb wbus quirk ctrl %08x ena %08x\n",
   113				musb_readl(tbase, TUSB_PHY_OTG_CTRL),
   114				musb_readl(tbase, TUSB_PHY_OTG_CTRL_ENABLE));
   115		} else if (musb_readl(tbase, TUSB_PHY_OTG_CTRL_ENABLE)
   116						& TUSB_PHY_OTG_CTRL_TESTM2) {
   117			tmp = TUSB_PHY_OTG_CTRL_WRPROTECT | phy_otg_ctrl;
   118			musb_writel(tbase, TUSB_PHY_OTG_CTRL, tmp);
   119			tmp = TUSB_PHY_OTG_CTRL_WRPROTECT | phy_otg_ena;
   120			musb_writel(tbase, TUSB_PHY_OTG_CTRL_ENABLE, tmp);
   121			dev_dbg(musb->controller, "Disabled tusb wbus quirk ctrl %08x ena %08x\n",
   122				musb_readl(tbase, TUSB_PHY_OTG_CTRL),
   123				musb_readl(tbase, TUSB_PHY_OTG_CTRL_ENABLE));
   124			phy_otg_ctrl = 0;
   125			phy_otg_ena = 0;
   126		}
   127	}
   128	
   129	static u32 tusb_fifo_offset(u8 epnum)
   130	{
   131		return 0x200 + (epnum * 0x20);
   132	}
   133	
   134	static u32 tusb_ep_offset(u8 epnum, u16 offset)
   135	{
   136		return 0x10 + offset;
   137	}
   138	
   139	/* TUSB mapping: "flat" plus ep0 special cases */
   140	static void tusb_ep_select(void __iomem *mbase, u8 epnum)
   141	{
 > 142		musb_writeb(mbase, MUSB_INDEX, epnum);
   143	}
   144	
   145	/*

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 34193 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-06-11 20:10 drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared kbuild test robot
@ 2016-09-08 17:45 ` Tony Lindgren
  2016-09-08 18:26   ` Bin Liu
  2016-09-14 13:37   ` Bin Liu
  0 siblings, 2 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-09-08 17:45 UTC (permalink / raw)
  To: kbuild test robot; +Cc: kbuild-all, linux-kernel, Felipe Balbi, Bin Liu

Hi,

Adding Bin to Cc.

* kbuild test robot <fengguang.wu@intel.com> [160611 13:27]:
> Hi,
> 
> FYI, the error/warning still remains.

Sorry just noticed this going through my inbox.. Please let me know
if there are other pending build errors I may have missed.

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   45b00c94be33db5d00595046663163ce55cbbfb9
> commit: d026e9c76aac3632af174cf02d5c94defa5e6026 usb: musb: Change end point selection to use new IO access
> date:   1 year, 7 months ago
> config: blackfin-allmodconfig (attached as .config)
> compiler: bfin-uclinux-gcc (GCC) 4.6.3
> reproduce:
>         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout d026e9c76aac3632af174cf02d5c94defa5e6026
>         # save the attached .config to linux build tree
>         make.cross ARCH=blackfin 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/usb/musb/tusb6010.c: In function 'tusb_get_revision':
>    drivers/usb/musb/tusb6010.c:53:26: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)

The patch below should fix this, I don't have any blackfin
machines or compilers here to test with though.

Regards,

Tony

8< ---------------------
From: Tony Lindgren <tony@atomide.com>
Date: Thu, 8 Sep 2016 10:36:47 -0700
Subject: [PATCH] usb: musb: Fix tusb6010 compile error on blackfin

We have CONFIG_BLACKFIN ifdef redefining all musb registers in
musb_regs.h and tusb6010.h is never included causing a build
error with blackfin-allmodconfig and COMPILE_TEST.

Let's fix the issue by not building tusb6010 if CONFIG_BLACKFIN
is selected.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
 config USB_MUSB_TUSB6010
 	tristate "TUSB6010"
 	depends on HAS_IOMEM
-	depends on ARCH_OMAP2PLUS || COMPILE_TEST
+	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
 	depends on NOP_USB_XCEIV = USB_MUSB_HDRC # both built-in or both modules
 
 config USB_MUSB_OMAP2PLUS

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-09-08 17:45 ` Tony Lindgren
@ 2016-09-08 18:26   ` Bin Liu
  2016-09-13 22:35     ` Tony Lindgren
  2016-09-14 13:37   ` Bin Liu
  1 sibling, 1 reply; 8+ messages in thread
From: Bin Liu @ 2016-09-08 18:26 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild test robot, kbuild-all, linux-kernel

Hi Tony,

On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> Hi,
> 
> Adding Bin to Cc.
> 
> * kbuild test robot <fengguang.wu@intel.com> [160611 13:27]:
> > Hi,
> > 
> > FYI, the error/warning still remains.
> 
> Sorry just noticed this going through my inbox.. Please let me know
> if there are other pending build errors I may have missed.
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   45b00c94be33db5d00595046663163ce55cbbfb9
> > commit: d026e9c76aac3632af174cf02d5c94defa5e6026 usb: musb: Change end point selection to use new IO access
> > date:   1 year, 7 months ago
> > config: blackfin-allmodconfig (attached as .config)
> > compiler: bfin-uclinux-gcc (GCC) 4.6.3
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout d026e9c76aac3632af174cf02d5c94defa5e6026
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=blackfin 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/usb/musb/tusb6010.c: In function 'tusb_get_revision':
> >    drivers/usb/musb/tusb6010.c:53:26: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)
> 
> The patch below should fix this, I don't have any blackfin
> machines or compilers here to test with though.
> 
> Regards,
> 
> Tony
> 
> 8< ---------------------
> From: Tony Lindgren <tony@atomide.com>
> Date: Thu, 8 Sep 2016 10:36:47 -0700
> Subject: [PATCH] usb: musb: Fix tusb6010 compile error on blackfin
> 
> We have CONFIG_BLACKFIN ifdef redefining all musb registers in
> musb_regs.h and tusb6010.h is never included causing a build
> error with blackfin-allmodconfig and COMPILE_TEST.
> 
> Let's fix the issue by not building tusb6010 if CONFIG_BLACKFIN
> is selected.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
>  config USB_MUSB_TUSB6010
>  	tristate "TUSB6010"
>  	depends on HAS_IOMEM
> -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN

Would this cause more issue later when trying to enable all glue drivers
in one build?

The macros defined in tusb6010.h are only used in tusb6010.c, so how
about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
instead? This gives flexibility to random config test, isn't it?

Regards,
-Bin.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-09-08 18:26   ` Bin Liu
@ 2016-09-13 22:35     ` Tony Lindgren
  2016-09-14 13:13         ` Bin Liu
  0 siblings, 1 reply; 8+ messages in thread
From: Tony Lindgren @ 2016-09-13 22:35 UTC (permalink / raw)
  To: Bin Liu; +Cc: kbuild test robot, kbuild-all, linux-kernel, linux-omap

* Bin Liu <b-liu@ti.com> [160908 11:26]:
> On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> >  config USB_MUSB_TUSB6010
> >  	tristate "TUSB6010"
> >  	depends on HAS_IOMEM
> > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> 
> Would this cause more issue later when trying to enable all glue drivers
> in one build?

Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
It completely redefines all the registers with ifdef else.

> The macros defined in tusb6010.h are only used in tusb6010.c, so how
> about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> instead? This gives flexibility to random config test, isn't it?

I'd like to see that but we have this in musb_core.c:

hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;

So the build would break there again on blackin with tusb6010..
Got any ideas on how to sort that out?

Regards,

Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-09-13 22:35     ` Tony Lindgren
@ 2016-09-14 13:13         ` Bin Liu
  0 siblings, 0 replies; 8+ messages in thread
From: Bin Liu @ 2016-09-14 13:13 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild test robot, kbuild-all, linux-kernel, linux-omap

On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > --- a/drivers/usb/musb/Kconfig
> > > +++ b/drivers/usb/musb/Kconfig
> > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > >  config USB_MUSB_TUSB6010
> > >  	tristate "TUSB6010"
> > >  	depends on HAS_IOMEM
> > > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > 
> > Would this cause more issue later when trying to enable all glue drivers
> > in one build?
> 
> Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> It completely redefines all the registers with ifdef else.
> 
> > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > instead? This gives flexibility to random config test, isn't it?
> 
> I'd like to see that but we have this in musb_core.c:
> 
> hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> 
> So the build would break there again on blackin with tusb6010..
> Got any ideas on how to sort that out?

Thanks for catching it. It appears that the glues require more work to
cleanup. I am taking your patch.

Regards,
-Bin.

> 
> Regards,
> 
> Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
@ 2016-09-14 13:13         ` Bin Liu
  0 siblings, 0 replies; 8+ messages in thread
From: Bin Liu @ 2016-09-14 13:13 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild test robot, kbuild-all, linux-kernel, linux-omap

On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > --- a/drivers/usb/musb/Kconfig
> > > +++ b/drivers/usb/musb/Kconfig
> > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > >  config USB_MUSB_TUSB6010
> > >  	tristate "TUSB6010"
> > >  	depends on HAS_IOMEM
> > > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > 
> > Would this cause more issue later when trying to enable all glue drivers
> > in one build?
> 
> Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> It completely redefines all the registers with ifdef else.
> 
> > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > instead? This gives flexibility to random config test, isn't it?
> 
> I'd like to see that but we have this in musb_core.c:
> 
> hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> 
> So the build would break there again on blackin with tusb6010..
> Got any ideas on how to sort that out?

Thanks for catching it. It appears that the glues require more work to
cleanup. I am taking your patch.

Regards,
-Bin.

> 
> Regards,
> 
> Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-09-08 17:45 ` Tony Lindgren
  2016-09-08 18:26   ` Bin Liu
@ 2016-09-14 13:37   ` Bin Liu
  1 sibling, 0 replies; 8+ messages in thread
From: Bin Liu @ 2016-09-14 13:37 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: kbuild test robot, kbuild-all, linux-kernel

On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> Hi,
> 
> Adding Bin to Cc.
> 
> * kbuild test robot <fengguang.wu@intel.com> [160611 13:27]:
> > Hi,
> > 
> > FYI, the error/warning still remains.
> 
> Sorry just noticed this going through my inbox.. Please let me know
> if there are other pending build errors I may have missed.
> 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   45b00c94be33db5d00595046663163ce55cbbfb9
> > commit: d026e9c76aac3632af174cf02d5c94defa5e6026 usb: musb: Change end point selection to use new IO access
> > date:   1 year, 7 months ago
> > config: blackfin-allmodconfig (attached as .config)
> > compiler: bfin-uclinux-gcc (GCC) 4.6.3
> > reproduce:
> >         wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         git checkout d026e9c76aac3632af174cf02d5c94defa5e6026
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=blackfin 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/usb/musb/tusb6010.c: In function 'tusb_get_revision':
> >    drivers/usb/musb/tusb6010.c:53:26: error: 'TUSB_DMA_CTRL_REV' undeclared (first use in this function)
> 
> The patch below should fix this, I don't have any blackfin
> machines or compilers here to test with though.
> 
> Regards,
> 
> Tony
> 
> 8< ---------------------
> From: Tony Lindgren <tony@atomide.com>
> Date: Thu, 8 Sep 2016 10:36:47 -0700
> Subject: [PATCH] usb: musb: Fix tusb6010 compile error on blackfin
> 
> We have CONFIG_BLACKFIN ifdef redefining all musb registers in
> musb_regs.h and tusb6010.h is never included causing a build
> error with blackfin-allmodconfig and COMPILE_TEST.
> 
> Let's fix the issue by not building tusb6010 if CONFIG_BLACKFIN
> is selected.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Signed-off-by: Bin Liu <b-liu@ti.com>

Regards,
-Bin.

> 
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
>  config USB_MUSB_TUSB6010
>  	tristate "TUSB6010"
>  	depends on HAS_IOMEM
> -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
>  	depends on NOP_USB_XCEIV = USB_MUSB_HDRC # both built-in or both modules
>  
>  config USB_MUSB_OMAP2PLUS

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared
  2016-09-14 13:13         ` Bin Liu
  (?)
@ 2016-09-14 14:35         ` Tony Lindgren
  -1 siblings, 0 replies; 8+ messages in thread
From: Tony Lindgren @ 2016-09-14 14:35 UTC (permalink / raw)
  To: Bin Liu, kbuild test robot, kbuild-all, linux-kernel, linux-omap

* Bin Liu <b-liu@ti.com> [160914 06:14]:
> On Tue, Sep 13, 2016 at 03:35:05PM -0700, Tony Lindgren wrote:
> > * Bin Liu <b-liu@ti.com> [160908 11:26]:
> > > On Thu, Sep 08, 2016 at 10:45:21AM -0700, Tony Lindgren wrote:
> > > > --- a/drivers/usb/musb/Kconfig
> > > > +++ b/drivers/usb/musb/Kconfig
> > > > @@ -87,7 +87,7 @@ config USB_MUSB_DA8XX
> > > >  config USB_MUSB_TUSB6010
> > > >  	tristate "TUSB6010"
> > > >  	depends on HAS_IOMEM
> > > > -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > > > +	depends on (ARCH_OMAP2PLUS || COMPILE_TEST) && !BLACKFIN
> > > 
> > > Would this cause more issue later when trying to enable all glue drivers
> > > in one build?
> > 
> > Yes but see what CONFIG_BLACKFIN is doing with musb_regs.h..
> > It completely redefines all the registers with ifdef else.
> > 
> > > The macros defined in tusb6010.h are only used in tusb6010.c, so how
> > > about move '#include "tusb6010.h"' from musb_regs.h to tusb6010.c
> > > instead? This gives flexibility to random config test, isn't it?
> > 
> > I'd like to see that but we have this in musb_core.c:
> > 
> > hw_ep->conf = mbase - 0x400 + TUSB_EP0_CONF;
> > 
> > So the build would break there again on blackin with tusb6010..
> > Got any ideas on how to sort that out?
> 
> Thanks for catching it. It appears that the glues require more work to
> cleanup. I am taking your patch.

OK thanks, yeah still more work needed for the glue layers for sure.

Regards,

Tony

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-09-14 14:35 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-11 20:10 drivers/usb/musb/tusb6010.c:142:21: error: 'USB_INDEX' undeclared kbuild test robot
2016-09-08 17:45 ` Tony Lindgren
2016-09-08 18:26   ` Bin Liu
2016-09-13 22:35     ` Tony Lindgren
2016-09-14 13:13       ` Bin Liu
2016-09-14 13:13         ` Bin Liu
2016-09-14 14:35         ` Tony Lindgren
2016-09-14 13:37   ` Bin Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.