All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "jgunthorpe@obsidianresearch.com"
	<jgunthorpe@obsidianresearch.com>,
	"tpmdd-devel@lists.sourceforge.net" 
	<tpmdd-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/4] tpm/tpm_crb: implement power management.
Date: Wed, 14 Sep 2016 19:06:55 +0300	[thread overview]
Message-ID: <20160914160652.GA12158@intel.com> (raw)
In-Reply-To: <20160914160602.GB11131@intel.com>

On Wed, Sep 14, 2016 at 07:06:02PM +0300, Jarkko Sakkinen wrote:
> On Wed, Sep 14, 2016 at 06:28:03AM +0000, Winkler, Tomas wrote:
> > On Mon, 2016-09-12 at 16:04 +0300, Tomas Winkler wrote:
> > > Te overall platform ability to enter a low power state is also
> > > conditioned on the ability of a tpm device to go to idle state.
> > > This series should provide this feature.
> > > 
> > > Unfortunately, there is a HW bug on Intel PTT devices on Skylake,
> > > Kabylake, and Broxton devices, where certain registers lost retention
> > > during TPM idle state. Hence this implementation takes this into
> > > consideration and implement the feature based only on access to
> > > registers that retain their state. This still conforms to the spec
> > > and should be correct also on non Intle devices.
> > > 
> > > V2: Utilize runtime_pm for driving tpm crb idle states.
> > > V3. fix lower case corruption in the first patch
> > > 
> > Jarkko, had you chance to test v3 series one on your side, is this okay
> > to go?
> 
> Opens for me are:
> 
> - pm_runtime_put_sync() is still used 
> - callback names
> - wait_for_tpm_stat

I also tested v3 and it works for me.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Winkler, Tomas" <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
	<tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 0/4] tpm/tpm_crb: implement power management.
Date: Wed, 14 Sep 2016 19:06:55 +0300	[thread overview]
Message-ID: <20160914160652.GA12158@intel.com> (raw)
In-Reply-To: <20160914160602.GB11131-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On Wed, Sep 14, 2016 at 07:06:02PM +0300, Jarkko Sakkinen wrote:
> On Wed, Sep 14, 2016 at 06:28:03AM +0000, Winkler, Tomas wrote:
> > On Mon, 2016-09-12 at 16:04 +0300, Tomas Winkler wrote:
> > > Te overall platform ability to enter a low power state is also
> > > conditioned on the ability of a tpm device to go to idle state.
> > > This series should provide this feature.
> > > 
> > > Unfortunately, there is a HW bug on Intel PTT devices on Skylake,
> > > Kabylake, and Broxton devices, where certain registers lost retention
> > > during TPM idle state. Hence this implementation takes this into
> > > consideration and implement the feature based only on access to
> > > registers that retain their state. This still conforms to the spec
> > > and should be correct also on non Intle devices.
> > > 
> > > V2: Utilize runtime_pm for driving tpm crb idle states.
> > > V3. fix lower case corruption in the first patch
> > > 
> > Jarkko, had you chance to test v3 series one on your side, is this okay
> > to go?
> 
> Opens for me are:
> 
> - pm_runtime_put_sync() is still used 
> - callback names
> - wait_for_tpm_stat

I also tested v3 and it works for me.

/Jarkko

------------------------------------------------------------------------------

  reply	other threads:[~2016-09-14 16:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 13:04 [PATCH v3 0/4] tpm/tpm_crb: implement power management Tomas Winkler
2016-09-12 13:04 ` Tomas Winkler
2016-09-12 13:04 ` [PATCH v3 1/4] tpm/tpm_crb: implement tpm crb idle state Tomas Winkler
2016-09-12 13:04   ` Tomas Winkler
2016-09-15  6:22   ` Jarkko Sakkinen
2016-09-15  6:22     ` Jarkko Sakkinen
2016-09-15  6:28     ` Winkler, Tomas
2016-09-15  6:28       ` Winkler, Tomas
2016-09-15  8:20       ` Jarkko Sakkinen
2016-09-15  8:20         ` Jarkko Sakkinen
2016-09-15  8:23         ` Winkler, Tomas
2016-09-15  8:23           ` Winkler, Tomas
2016-09-15 10:53           ` Jarkko Sakkinen
2016-09-15 10:53             ` Jarkko Sakkinen
2016-09-15 13:09             ` Winkler, Tomas
2016-09-15 13:09               ` Winkler, Tomas
2016-09-12 13:04 ` [PATCH v3 2/4] tmp/tpm_crb: fix Intel PTT hw bug during " Tomas Winkler
2016-09-12 13:04   ` Tomas Winkler
2016-09-15  6:23   ` Jarkko Sakkinen
2016-09-27  9:31     ` Jarkko Sakkinen
2016-09-27  9:31       ` Jarkko Sakkinen
2016-09-27  9:54       ` Winkler, Tomas
2016-09-27  9:54         ` Winkler, Tomas
2016-09-12 13:04 ` [PATCH v3 3/4] tpm/tpm_crb: open code the crb_init into acpi_add Tomas Winkler
2016-09-12 13:04   ` Tomas Winkler
2016-09-15  6:24   ` Jarkko Sakkinen
2016-09-12 13:04 ` [PATCH v4 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Tomas Winkler
2016-09-12 13:04   ` Tomas Winkler
2016-09-14  6:28 ` [PATCH v3 0/4] tpm/tpm_crb: implement power management Winkler, Tomas
2016-09-14  6:28   ` Winkler, Tomas
2016-09-14 16:06   ` Jarkko Sakkinen
2016-09-14 16:06     ` Jarkko Sakkinen
2016-09-14 16:06     ` Jarkko Sakkinen [this message]
2016-09-14 16:06       ` Jarkko Sakkinen
2016-09-14 18:25       ` Jarkko Sakkinen
2016-09-14 18:25         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914160652.GA12158@intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.