[PATCH] perf/x86: Use kmalloc_array() in merge_attr()

* [PATCH] perf/x86: Use kmalloc_array() in merge_attr()
@ 2016-09-04  9:00 ` SF Markus Elfring
  0 siblings, 0 replies; 10+ messages in thread
From: SF Markus Elfring @ 2016-09-04  9:00 UTC (permalink / raw)
  To: x86, Alexander Shishkin, Arnaldo Carvalho de Melo,
	H. Peter Anvin, Ingo Molnar, Peter Zijlstra, Thomas Gleixner
  Cc: LKML, kernel-janitors, Julia Lawall, Paolo Bonzini

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 4 Sep 2016 10:45:20 +0200

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/x86/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index 18a1acf..f7f3578 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -1618,7 +1618,7 @@ __init struct attribute **merge_attr(struct attribute **a, struct attribute **b)
 		j++;
 	j++;
 
-	new = kmalloc(sizeof(struct attribute *) * j, GFP_KERNEL);
+	new = kmalloc_array(j, sizeof(*new), GFP_KERNEL);
 	if (!new)
 		return NULL;
 
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread