All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: NeilBrown <neilb@suse.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	Felipe Balbi <balbi@kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	robh@kernel.org, Jun Li <jun.li@nxp.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Peter Chen <peter.chen@freescale.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	r.baldyga@samsung.com, grygorii.strashko@ti.com,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Lee Jones <lee.jones@linaro.org>,
	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com,
	Linux PM list <linux-pm@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	device-mainlining@lists.linuxfoundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	"Bird, Timothy" <Tim.Bird@am.sony.com>
Subject: Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation
Date: Wed, 14 Sep 2016 19:02:14 +0100	[thread overview]
Message-ID: <20160914180214.GI27974@sirena.org.uk> (raw)
In-Reply-To: <87oa3qz7zr.fsf@notabene.neil.brown.name>

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Wed, Sep 14, 2016 at 07:50:00PM +0200, NeilBrown wrote:
> On Wed, Sep 14 2016, Mark Brown wrote:

> Ah.... my mistake, sorry.
> When earlier you said:

> >                                                                 It's a
> > current limiter intended to sit in line with the USB power lines to

> I assumed that all it did was limit the current to number given.
> If it also limits the current to ensure that voltage doesn't drop
> unduly, then I agree with your assertion that it just needs to be told
> the upper limit.

Oh, I see the gap here - the USB specific bit is only a current limiter
but it works in concert with other bits of the system that try to stop
the voltage from whatever supply is in use from dropping and can't be
used independently of them.  That's why I wasn't clear in what I said!

> I hope you'll agree that other drivers might need to know the lower
> limit, so reporting both to all drivers is sensible.

Yes, absolutely.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: NeilBrown <neilb@suse.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
	Felipe Balbi <balbi@kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>,
	Sebastian Reichel <sre@kernel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	robh@kernel.org, Jun Li <jun.li@nxp.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Ruslan Bilovol <ruslan.bilovol@gmail.com>,
	Peter Chen <peter.chen@freescale.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	r.baldyga@samsung.com, grygorii.strashko@ti.com,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Lee Jones <lee.jones@linaro.org>,
	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com,
	Linux PM list <linux-pm@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	device-m
Subject: Re: [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation
Date: Wed, 14 Sep 2016 19:02:14 +0100	[thread overview]
Message-ID: <20160914180214.GI27974@sirena.org.uk> (raw)
In-Reply-To: <87oa3qz7zr.fsf@notabene.neil.brown.name>

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

On Wed, Sep 14, 2016 at 07:50:00PM +0200, NeilBrown wrote:
> On Wed, Sep 14 2016, Mark Brown wrote:

> Ah.... my mistake, sorry.
> When earlier you said:

> >                                                                 It's a
> > current limiter intended to sit in line with the USB power lines to

> I assumed that all it did was limit the current to number given.
> If it also limits the current to ensure that voltage doesn't drop
> unduly, then I agree with your assertion that it just needs to be told
> the upper limit.

Oh, I see the gap here - the USB specific bit is only a current limiter
but it works in concert with other bits of the system that try to stop
the voltage from whatever supply is in use from dropping and can't be
used independently of them.  That's why I wasn't clear in what I said!

> I hope you'll agree that other drivers might need to know the lower
> limit, so reporting both to all drivers is sensible.

Yes, absolutely.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-09-14 18:03 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-01  7:09 [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-08-01  7:09 ` [PATCH v16 1/4] usb: gadget: Introduce the usb charger framework Baolin Wang
2016-08-01  7:09 ` [PATCH v16 2/4] usb: gadget: Support for " Baolin Wang
2016-08-01  7:09 ` [PATCH v16 3/4] usb: gadget: Integrate with the usb gadget supporting for usb charger Baolin Wang
2016-08-01  7:09 ` [PATCH v16 4/4] power: wm831x_power: Support USB charger current limit management Baolin Wang
2016-08-11  3:14 ` [PATCH v16 0/4] Introduce usb charger framework to deal with the usb gadget power negotation Baolin Wang
2016-08-11  3:14   ` Baolin Wang
2016-08-29  9:02   ` Baolin Wang
2016-09-06  5:40     ` NeilBrown
2016-09-06  5:40       ` NeilBrown
2016-09-06  7:40       ` Felipe Balbi
2016-09-06  7:40         ` Felipe Balbi
2016-09-08  6:55       ` Baolin Wang
2016-09-08  6:55         ` Baolin Wang
2016-09-08  7:31         ` NeilBrown
2016-09-08  7:31           ` NeilBrown
2016-09-08  8:12           ` Baolin Wang
2016-09-08  8:12             ` Baolin Wang
2016-09-08 23:13             ` NeilBrown
2016-09-08 23:13               ` NeilBrown
2016-09-09  6:46               ` Baolin Wang
2016-09-09  6:46                 ` Baolin Wang
2016-09-09 21:19                 ` NeilBrown
2016-09-09 21:19                   ` NeilBrown
2016-09-18  9:39                   ` Baolin Wang
2016-09-18  9:39                     ` Baolin Wang
2016-10-05  7:26                     ` Baolin Wang
2016-10-05  7:26                       ` Baolin Wang
2016-10-05  7:47                       ` Felipe Balbi
2016-10-05  7:47                         ` Felipe Balbi
2016-10-05  7:57                         ` Baolin Wang
2016-10-05  7:57                           ` Baolin Wang
2016-10-05 10:44                         ` NeilBrown
2016-10-05 10:44                           ` NeilBrown
2016-10-08  3:18                           ` Baolin Wang
2016-10-08  3:18                             ` Baolin Wang
2016-09-09 11:07               ` Mark Brown
2016-09-09 11:07                 ` Mark Brown
2016-09-09 21:57                 ` NeilBrown
2016-09-09 21:57                   ` NeilBrown
2016-09-12 12:25                   ` Mark Brown
2016-09-12 12:25                     ` Mark Brown
2016-09-12 13:27                     ` NeilBrown
2016-09-12 13:27                       ` NeilBrown
2016-09-12 15:26                       ` Mark Brown
2016-09-12 15:26                         ` Mark Brown
2016-09-13  8:00                         ` NeilBrown
2016-09-13  8:00                           ` NeilBrown
2016-09-14 11:16                           ` Mark Brown
2016-09-14 11:16                             ` Mark Brown
2016-09-14 14:11                             ` NeilBrown
2016-09-14 14:11                               ` NeilBrown
2016-09-14 14:57                               ` Mark Brown
2016-09-14 14:57                                 ` Mark Brown
2016-09-14 17:50                                 ` NeilBrown
2016-09-14 17:50                                   ` NeilBrown
2016-09-14 18:02                                   ` Mark Brown [this message]
2016-09-14 18:02                                     ` Mark Brown
2016-09-15 10:33                           ` Pavel Machek
2016-09-15 10:33                             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914180214.GI27974@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Tim.Bird@am.sony.com \
    --cc=balbi@kernel.org \
    --cc=baolin.wang@linaro.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=dbaryshkov@gmail.com \
    --cc=device-mainlining@lists.linuxfoundation.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=jun.li@nxp.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=neilb@suse.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=peter.chen@freescale.com \
    --cc=r.baldyga@samsung.com \
    --cc=robh@kernel.org \
    --cc=ruslan.bilovol@gmail.com \
    --cc=sre@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.