All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: <linux-kernel@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
	"Bazhenov, Dmitry" <dmitry.bazhenov@auriga.com>
Subject: Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction
Date: Thu, 22 Sep 2016 18:08:32 +0200	[thread overview]
Message-ID: <20160922160832.GA2734@hardcore> (raw)
In-Reply-To: <20160921205540.GC1513@katana>

On Wed, Sep 21, 2016 at 10:55:41PM +0200, Wolfram Sang wrote:
> On Wed, Sep 21, 2016 at 08:51:05AM +0200, Jan Glauber wrote:
> > Add an additional status check before starting a transaction and,
> > if required, trigger the recovery if the check fails.
> > 
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> 
> Won't this break multi-master setups?
> 

I'm afraid yes. I don't have a multi-master setup, but agree that we
should not break it.

How about re-checking if the bus is idle until a timeout
(i2c->adap.timeout ?) happens and only then recover?

Additionaly we can check for arbitration loss as Dmitry did in his
original patch.

--Jan

WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	"Bazhenov, Dmitry" <dmitry.bazhenov@auriga.com>
Subject: Re: [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction
Date: Thu, 22 Sep 2016 18:08:32 +0200	[thread overview]
Message-ID: <20160922160832.GA2734@hardcore> (raw)
In-Reply-To: <20160921205540.GC1513@katana>

On Wed, Sep 21, 2016 at 10:55:41PM +0200, Wolfram Sang wrote:
> On Wed, Sep 21, 2016 at 08:51:05AM +0200, Jan Glauber wrote:
> > Add an additional status check before starting a transaction and,
> > if required, trigger the recovery if the check fails.
> > 
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> 
> Won't this break multi-master setups?
> 

I'm afraid yes. I don't have a multi-master setup, but agree that we
should not break it.

How about re-checking if the bus is idle until a timeout
(i2c->adap.timeout ?) happens and only then recover?

Additionaly we can check for arbitration loss as Dmitry did in his
original patch.

--Jan

  reply	other threads:[~2016-09-22 16:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  6:51 [PATCH 0/5] i2c: octeon,thunderx: Recovery fixes and improvements Jan Glauber
2016-09-21  6:51 ` [PATCH 1/5] i2c: octeon,thunderx: Fix set SCL recovery function Jan Glauber
2016-09-21 21:00   ` Wolfram Sang
2016-09-21  6:51 ` [PATCH 2/5] i2c: octeon,thunderx: Avoid sending STOP during recovery Jan Glauber
2016-09-21 21:00   ` Wolfram Sang
2016-09-21  6:51 ` [PATCH 3/5] i2c: octeon,thunderx: Fix high-level controller status check Jan Glauber
2016-09-21 21:01   ` Wolfram Sang
2016-09-21  6:51 ` [PATCH 4/5] i2c: octeon,thunderx: Check bus state before starting a transaction Jan Glauber
2016-09-21 20:55   ` Wolfram Sang
2016-09-22 16:08     ` Jan Glauber [this message]
2016-09-22 16:08       ` Jan Glauber
2016-09-21  6:51 ` [PATCH 5/5] i2c: octeon,thunderx: Limit register access retries Jan Glauber
2016-09-21 21:03   ` Wolfram Sang
2016-09-22 16:40     ` Jan Glauber
2016-09-22 16:40       ` Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160922160832.GA2734@hardcore \
    --to=jan.glauber@caviumnetworks.com \
    --cc=dmitry.bazhenov@auriga.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.