* [PATCH] staging:android:io: Fix multiple styling issues @ 2016-09-22 17:55 Yannis Damigos 2016-09-22 18:22 ` Markus Böhme 0 siblings, 1 reply; 23+ messages in thread From: Yannis Damigos @ 2016-09-22 17:55 UTC (permalink / raw) To: gregkh; +Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos This patch fixes 1 error, 1 warning and 14 checks found by checkpatch. Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 49 ++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..c930416 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -26,17 +26,17 @@ #include "ion_of.h" int ion_parse_dt_heap_common(struct device_node *heap_node, - struct ion_platform_heap *heap, - struct ion_of_heap *compatible) + struct ion_platform_heap *heap, + struct ion_of_heap *compatible) { int i; - for (i = 0; compatible[i].name != NULL; i++) { + for (i = 0; compatible[i].name; i++) { if (of_device_is_compatible(heap_node, compatible[i].compat)) break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; @@ -47,33 +47,33 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, /* Some kind of callback function pointer? */ pr_info("%s: id %d type %d name %s align %lx\n", __func__, - heap->id, heap->type, heap->name, heap->align); + heap->id, heap->type, heap->name, heap->align); return 0; } int ion_setup_heap_common(struct platform_device *parent, - struct device_node *heap_node, - struct ion_platform_heap *heap) + struct device_node *heap_node, + struct ion_platform_heap *heap) { int ret = 0; switch (heap->type) { - case ION_HEAP_TYPE_CARVEOUT: - case ION_HEAP_TYPE_CHUNK: - if (heap->base && heap->size) - return 0; - - ret = of_reserved_mem_device_init(heap->priv); - break; - default: - break; + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: + if (heap->base && heap->size) + return 0; + + ret = of_reserved_mem_device_init(heap->priv); + break; + default: + break; } return ret; } struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, - struct ion_of_heap *compatible) + struct ion_of_heap *compatible) { int num_heaps, ret; const struct device_node *dt_node = pdev->dev.of_node; @@ -88,13 +88,13 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(-EINVAL); heaps = devm_kzalloc(&pdev->dev, - sizeof(struct ion_platform_heap)*num_heaps, - GFP_KERNEL); + sizeof(struct ion_platform_heap) * num_heaps, + GFP_KERNEL); if (!heaps) return ERR_PTR(-ENOMEM); data = devm_kzalloc(&pdev->dev, sizeof(struct ion_platform_data), - GFP_KERNEL); + GFP_KERNEL); if (!data) return ERR_PTR(-ENOMEM); @@ -106,7 +106,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(ret); heap_pdev = of_platform_device_create(node, heaps[i].name, - &pdev->dev); + &pdev->dev); if (!pdev) return ERR_PTR(-ENOMEM); heap_pdev->dev.platform_data = &heaps[i]; @@ -119,7 +119,6 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, i++; } - data->heaps = heaps; data->nr = num_heaps; return data; @@ -155,14 +154,13 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) heap->base = rmem->base; heap->base = rmem->size; pr_debug("%s: heap %s base %pa size %pa dev %p\n", __func__, - heap->name, &rmem->base, &rmem->size, dev); + heap->name, &rmem->base, &rmem->size, dev); return 0; } static void rmem_ion_device_release(struct reserved_mem *rmem, - struct device *dev) + struct device *dev) { - return; } static const struct reserved_mem_ops rmem_dma_ops = { @@ -181,5 +179,6 @@ static int __init rmem_ion_setup(struct reserved_mem *rmem) rmem->ops = &rmem_dma_ops; return 0; } + RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); #endif -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH] staging:android:io: Fix multiple styling issues 2016-09-22 17:55 [PATCH] staging:android:io: Fix multiple styling issues Yannis Damigos @ 2016-09-22 18:22 ` Markus Böhme 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos 0 siblings, 1 reply; 23+ messages in thread From: Markus Böhme @ 2016-09-22 18:22 UTC (permalink / raw) To: Yannis Damigos, gregkh; +Cc: devel, arve, riandrews, linux-kernel Hello Yannis! There is a typo in your one-line description/subject ("ion"). On 09/22/2016 07:55 PM, Yannis Damigos wrote: > This patch fixes 1 error, 1 warning and 14 checks found by > checkpatch. Please be more specific in your commit message and mention what exactly you are doing to the code and why. > > Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> > --- > drivers/staging/android/ion/ion_of.c | 49 ++++++++++++++++++------------------ > 1 file changed, 24 insertions(+), 25 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index de0899a..c930416 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -26,17 +26,17 @@ > #include "ion_of.h" > > int ion_parse_dt_heap_common(struct device_node *heap_node, > - struct ion_platform_heap *heap, > - struct ion_of_heap *compatible) > + struct ion_platform_heap *heap, > + struct ion_of_heap *compatible) You are changing whitespace here, ... > { > int i; > > - for (i = 0; compatible[i].name != NULL; i++) { > + for (i = 0; compatible[i].name; i++) { ... and are making a different kind of change here. > (Rest of patch with yet other types of changes snipped.) It would be nice to have each kind of change in a separate patch with a more precise commit message. Thanks, Markus ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL 2016-09-22 18:22 ` Markus Böhme @ 2016-09-23 8:05 ` giannis.damigos 2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos ` (3 more replies) 0 siblings, 4 replies; 23+ messages in thread From: giannis.damigos @ 2016-09-23 8:05 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos From: Yannis Damigos <giannis.damigos@gmail.com> This patch fixes the following comparison with NULL issues: CHECK: Comparison to NULL could be written "compatible[i].name" + for (i = 0; compatible[i].name != NULL; i++) { CHECK: Comparison to NULL could be written "!compatible[i].name" + if (compatible[i].name == NULL) Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..b3da8d8 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -31,12 +31,12 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, { int i; - for (i = 0; compatible[i].name != NULL; i++) { + for (i = 0; compatible[i].name; i++) { if (of_device_is_compatible(heap_node, compatible[i].compat)) break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCHv2 2/5] staging:android:ion: Fix whitespace issues 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos @ 2016-09-23 8:05 ` giannis.damigos 2016-09-23 12:17 ` Greg KH 2016-09-23 8:05 ` [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos ` (2 subsequent siblings) 3 siblings, 1 reply; 23+ messages in thread From: giannis.damigos @ 2016-09-23 8:05 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos From: Yannis Damigos <giannis.damigos@gmail.com> This patch fixes the following whitespace issues: CHECK: Alignment should match open parenthesis +int ion_parse_dt_heap_common(struct device_node *heap_node, + struct ion_platform_heap *heap, CHECK: Alignment should match open parenthesis + pr_info("%s: id %d type %d name %s align %lx\n", __func__, + heap->id, heap->type, heap->name, heap->align); CHECK: Alignment should match open parenthesis +int ion_setup_heap_common(struct platform_device *parent, + struct device_node *heap_node, CHECK: Alignment should match open parenthesis +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, + struct ion_of_heap *compatible) CHECK: Alignment should match open parenthesis + heaps = devm_kzalloc(&pdev->dev, + sizeof(struct ion_platform_heap)*num_heaps, CHECK: spaces preferred around that '*' (ctx:VxV) + sizeof(struct ion_platform_heap)*num_heaps, CHECK: Alignment should match open parenthesis + data = devm_kzalloc(&pdev->dev, sizeof(struct ion_platform_data), + GFP_KERNEL); CHECK: Alignment should match open parenthesis + heap_pdev = of_platform_device_create(node, heaps[i].name, + &pdev->dev); CHECK: Alignment should match open parenthesis + pr_debug("%s: heap %s base %pa size %pa dev %p\n", __func__, + heap->name, &rmem->base, &rmem->size, dev); CHECK: Alignment should match open parenthesis +static void rmem_ion_device_release(struct reserved_mem *rmem, + struct device *dev) Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index b3da8d8..b7babc7 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -26,8 +26,8 @@ #include "ion_of.h" int ion_parse_dt_heap_common(struct device_node *heap_node, - struct ion_platform_heap *heap, - struct ion_of_heap *compatible) + struct ion_platform_heap *heap, + struct ion_of_heap *compatible) { int i; @@ -47,13 +47,13 @@ int ion_parse_dt_heap_common(struct device_node *heap_node, /* Some kind of callback function pointer? */ pr_info("%s: id %d type %d name %s align %lx\n", __func__, - heap->id, heap->type, heap->name, heap->align); + heap->id, heap->type, heap->name, heap->align); return 0; } int ion_setup_heap_common(struct platform_device *parent, - struct device_node *heap_node, - struct ion_platform_heap *heap) + struct device_node *heap_node, + struct ion_platform_heap *heap) { int ret = 0; @@ -73,7 +73,7 @@ int ion_setup_heap_common(struct platform_device *parent, } struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, - struct ion_of_heap *compatible) + struct ion_of_heap *compatible) { int num_heaps, ret; const struct device_node *dt_node = pdev->dev.of_node; @@ -88,13 +88,13 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(-EINVAL); heaps = devm_kzalloc(&pdev->dev, - sizeof(struct ion_platform_heap)*num_heaps, - GFP_KERNEL); + sizeof(struct ion_platform_heap) * num_heaps, + GFP_KERNEL); if (!heaps) return ERR_PTR(-ENOMEM); data = devm_kzalloc(&pdev->dev, sizeof(struct ion_platform_data), - GFP_KERNEL); + GFP_KERNEL); if (!data) return ERR_PTR(-ENOMEM); @@ -106,7 +106,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(ret); heap_pdev = of_platform_device_create(node, heaps[i].name, - &pdev->dev); + &pdev->dev); if (!pdev) return ERR_PTR(-ENOMEM); heap_pdev->dev.platform_data = &heaps[i]; @@ -155,12 +155,12 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) heap->base = rmem->base; heap->base = rmem->size; pr_debug("%s: heap %s base %pa size %pa dev %p\n", __func__, - heap->name, &rmem->base, &rmem->size, dev); + heap->name, &rmem->base, &rmem->size, dev); return 0; } static void rmem_ion_device_release(struct reserved_mem *rmem, - struct device *dev) + struct device *dev) { return; } -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCHv2 2/5] staging:android:ion: Fix whitespace issues 2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos @ 2016-09-23 12:17 ` Greg KH 0 siblings, 0 replies; 23+ messages in thread From: Greg KH @ 2016-09-23 12:17 UTC (permalink / raw) To: giannis.damigos; +Cc: markus.boehme, arve, riandrews, devel, linux-kernel On Fri, Sep 23, 2016 at 11:05:14AM +0300, giannis.damigos@gmail.com wrote: > From: Yannis Damigos <giannis.damigos@gmail.com> > > This patch fixes the following whitespace issues: > > CHECK: Alignment should match open parenthesis > +int ion_parse_dt_heap_common(struct device_node *heap_node, > + struct ion_platform_heap *heap, > > CHECK: Alignment should match open parenthesis > + pr_info("%s: id %d type %d name %s align %lx\n", __func__, > + heap->id, heap->type, heap->name, heap->align); > > CHECK: Alignment should match open parenthesis > +int ion_setup_heap_common(struct platform_device *parent, > + struct device_node *heap_node, > > CHECK: Alignment should match open parenthesis > +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, > + struct ion_of_heap *compatible) > > CHECK: Alignment should match open parenthesis > + heaps = devm_kzalloc(&pdev->dev, > + sizeof(struct > ion_platform_heap)*num_heaps, Why is your changelog text line-wrapped? > > CHECK: spaces preferred around that '*' (ctx:VxV) > + sizeof(struct > ion_platform_heap)*num_heaps, Same here. And don't mix different types of whitespace cleanup in the same patch please. thanks, greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCHv2 3/5] staging:android:ion: Fix blank line issues 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos 2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos @ 2016-09-23 8:05 ` giannis.damigos 2016-09-23 12:17 ` Greg KH 2016-09-23 8:05 ` [PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos 2016-09-23 8:05 ` [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos 3 siblings, 1 reply; 23+ messages in thread From: giannis.damigos @ 2016-09-23 8:05 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos From: Yannis Damigos <giannis.damigos@gmail.com> This patch fixes the following blank line issues: CHECK: Please don't use multiple blank lines + + CHECK: Please use a blank line after function/struct/union/enum declarations +} +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index b7babc7..23f51a3 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -119,7 +119,6 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, i++; } - data->heaps = heaps; data->nr = num_heaps; return data; @@ -181,5 +180,6 @@ static int __init rmem_ion_setup(struct reserved_mem *rmem) rmem->ops = &rmem_dma_ops; return 0; } + RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); #endif -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues 2016-09-23 8:05 ` [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos @ 2016-09-23 12:17 ` Greg KH 2016-09-23 13:26 ` Yannis Damigos 0 siblings, 1 reply; 23+ messages in thread From: Greg KH @ 2016-09-23 12:17 UTC (permalink / raw) To: giannis.damigos; +Cc: markus.boehme, arve, riandrews, devel, linux-kernel On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@gmail.com wrote: > From: Yannis Damigos <giannis.damigos@gmail.com> > > This patch fixes the following blank line issues: > > CHECK: Please don't use multiple blank lines > + > + What does that mean with the + + lines? > > CHECK: Please use a blank line after function/struct/union/enum > declarations > +} > +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); Linewrap :( thanks, greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues 2016-09-23 12:17 ` Greg KH @ 2016-09-23 13:26 ` Yannis Damigos 2016-09-23 15:06 ` Greg KH 0 siblings, 1 reply; 23+ messages in thread From: Yannis Damigos @ 2016-09-23 13:26 UTC (permalink / raw) To: Greg KH; +Cc: markus.boehme, arve, riandrews, devel, linux-kernel On Fri, Sep 23, 2016 at 3:17 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@gmail.com wrote: >> From: Yannis Damigos <giannis.damigos@gmail.com> >> >> This patch fixes the following blank line issues: >> >> CHECK: Please don't use multiple blank lines >> + >> + > > What does that mean with the + + lines? > >> >> CHECK: Please use a blank line after function/struct/union/enum >> declarations >> +} >> +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); > > Linewrap :( > If the line is not wrapped, I get the following warning: Possible unwrapped commit description (prefer a maximum 75 chars per line) Should I ignore it? Best regards, Yannis ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues 2016-09-23 13:26 ` Yannis Damigos @ 2016-09-23 15:06 ` Greg KH 0 siblings, 0 replies; 23+ messages in thread From: Greg KH @ 2016-09-23 15:06 UTC (permalink / raw) To: Yannis Damigos; +Cc: devel, arve, riandrews, linux-kernel On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote: > On Fri, Sep 23, 2016 at 3:17 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@gmail.com wrote: > >> From: Yannis Damigos <giannis.damigos@gmail.com> > >> > >> This patch fixes the following blank line issues: > >> > >> CHECK: Please don't use multiple blank lines > >> + > >> + > > > > What does that mean with the + + lines? > > > >> > >> CHECK: Please use a blank line after function/struct/union/enum > >> declarations > >> +} > >> +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); > > > > Linewrap :( > > > If the line is not wrapped, I get the following warning: > Possible unwrapped commit description (prefer a maximum 75 chars per line) > > Should I ignore it? Don't you think it makes sense to do so? :) ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCHv2 4/5] staging:android:ion: Fix switch case indentation 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos 2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos 2016-09-23 8:05 ` [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos @ 2016-09-23 8:05 ` giannis.damigos 2016-09-23 8:05 ` [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos 3 siblings, 0 replies; 23+ messages in thread From: giannis.damigos @ 2016-09-23 8:05 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos From: Yannis Damigos <giannis.damigos@gmail.com> This patch fixes the following switch statement indentation issue: ERROR: switch and case should be at the same indent + switch (heap->type) { + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: [...] + default: Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 23f51a3..49f052c 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -58,15 +58,15 @@ int ion_setup_heap_common(struct platform_device *parent, int ret = 0; switch (heap->type) { - case ION_HEAP_TYPE_CARVEOUT: - case ION_HEAP_TYPE_CHUNK: - if (heap->base && heap->size) - return 0; - - ret = of_reserved_mem_device_init(heap->priv); - break; - default: - break; + case ION_HEAP_TYPE_CARVEOUT: + case ION_HEAP_TYPE_CHUNK: + if (heap->base && heap->size) + return 0; + + ret = of_reserved_mem_device_init(heap->priv); + break; + default: + break; } return ret; -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCHv2 5/5] staging:android:ion: Fix void function return 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos ` (2 preceding siblings ...) 2016-09-23 8:05 ` [PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos @ 2016-09-23 8:05 ` giannis.damigos 2016-09-23 8:44 ` Greg KH 3 siblings, 1 reply; 23+ messages in thread From: giannis.damigos @ 2016-09-23 8:05 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos From: Yannis Damigos <giannis.damigos@gmail.com> This patch removes the return statement of void function WARNING: void function return statements are not generally useful + return; +} Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 49f052c..c930416 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -161,7 +161,6 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) static void rmem_ion_device_release(struct reserved_mem *rmem, struct device *dev) { - return; } static const struct reserved_mem_ops rmem_dma_ops = { -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCHv2 5/5] staging:android:ion: Fix void function return 2016-09-23 8:05 ` [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos @ 2016-09-23 8:44 ` Greg KH 2016-09-23 9:50 ` [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos 0 siblings, 1 reply; 23+ messages in thread From: Greg KH @ 2016-09-23 8:44 UTC (permalink / raw) To: giannis.damigos; +Cc: markus.boehme, arve, riandrews, devel, linux-kernel On Fri, Sep 23, 2016 at 11:05:17AM +0300, giannis.damigos@gmail.com wrote: > From: Yannis Damigos <giannis.damigos@gmail.com> > > This patch removes the return statement of void function > > WARNING: void function return statements are not generally useful > + return; > +} > > Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> > --- > drivers/staging/android/ion/ion_of.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index 49f052c..c930416 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -161,7 +161,6 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) > static void rmem_ion_device_release(struct reserved_mem *rmem, > struct device *dev) > { > - return; > } Why have an empty release function at all? If it can be empty, you should be able to drop the function entirely, right? thanks, greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-23 8:44 ` Greg KH @ 2016-09-23 9:50 ` Yannis Damigos 2016-09-23 12:06 ` Greg KH 2016-09-23 12:18 ` Greg KH 0 siblings, 2 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-23 9:50 UTC (permalink / raw) To: markus.boehme, gregkh Cc: arve, riandrews, devel, linux-kernel, Yannis Damigos This patch removes the empty function rmem_ion_device_release Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 49f052c..91c0642 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) return 0; } -static void rmem_ion_device_release(struct reserved_mem *rmem, - struct device *dev) -{ - return; -} - static const struct reserved_mem_ops rmem_dma_ops = { .device_init = rmem_ion_device_init, - .device_release = rmem_ion_device_release, }; static int __init rmem_ion_setup(struct reserved_mem *rmem) -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-23 9:50 ` [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos @ 2016-09-23 12:06 ` Greg KH 2016-09-23 13:50 ` Yannis Damigos 2016-09-26 10:11 ` Yannis Damigos 2016-09-23 12:18 ` Greg KH 1 sibling, 2 replies; 23+ messages in thread From: Greg KH @ 2016-09-23 12:06 UTC (permalink / raw) To: Yannis Damigos; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: > This patch removes the empty function rmem_ion_device_release > > Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> > --- > drivers/staging/android/ion/ion_of.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index 49f052c..91c0642 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) > return 0; > } > > -static void rmem_ion_device_release(struct reserved_mem *rmem, > - struct device *dev) > -{ > - return; > -} > - > static const struct reserved_mem_ops rmem_dma_ops = { > .device_init = rmem_ion_device_init, > - .device_release = rmem_ion_device_release, > }; > > static int __init rmem_ion_setup(struct reserved_mem *rmem) > -- > 2.10.0 Have you tested that this works? thanks, greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-23 12:06 ` Greg KH @ 2016-09-23 13:50 ` Yannis Damigos 2016-09-26 10:11 ` Yannis Damigos 1 sibling, 0 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-23 13:50 UTC (permalink / raw) To: Greg KH; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel I believed I tested it but I found out that the CONFIG_OF_RESERVED_MEM was not enabled in my config. So it was not properly tested. I will try to test it again. Sorry, Yannis On Fri, Sep 23, 2016 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: >> This patch removes the empty function rmem_ion_device_release >> >> Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> >> --- >> drivers/staging/android/ion/ion_of.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c >> index 49f052c..91c0642 100644 >> --- a/drivers/staging/android/ion/ion_of.c >> +++ b/drivers/staging/android/ion/ion_of.c >> @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) >> return 0; >> } >> >> -static void rmem_ion_device_release(struct reserved_mem *rmem, >> - struct device *dev) >> -{ >> - return; >> -} >> - >> static const struct reserved_mem_ops rmem_dma_ops = { >> .device_init = rmem_ion_device_init, >> - .device_release = rmem_ion_device_release, >> }; >> >> static int __init rmem_ion_setup(struct reserved_mem *rmem) >> -- >> 2.10.0 > > Have you tested that this works? > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-23 12:06 ` Greg KH 2016-09-23 13:50 ` Yannis Damigos @ 2016-09-26 10:11 ` Yannis Damigos 2016-09-26 10:24 ` Greg KH 1 sibling, 1 reply; 23+ messages in thread From: Yannis Damigos @ 2016-09-26 10:11 UTC (permalink / raw) To: Greg KH; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel Hi Greg, On Fri, Sep 23, 2016 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > Have you tested that this works? > In order to test the change I need a board with Hi6220 SoC. If I do not own the hardware to test the change, how should I proceed? thanks, Yannis ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-26 10:11 ` Yannis Damigos @ 2016-09-26 10:24 ` Greg KH 2016-09-26 10:30 ` Yannis Damigos 0 siblings, 1 reply; 23+ messages in thread From: Greg KH @ 2016-09-26 10:24 UTC (permalink / raw) To: Yannis Damigos; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote: > Hi Greg, > > On Fri, Sep 23, 2016 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > Have you tested that this works? > > > > In order to test the change I need a board with Hi6220 SoC. > If I do not own the hardware to test the change, how should I proceed? For something like this, that isn't really a trivial patch, I'd like to have someone that has the hardware be able to test it before accepting the patch, sorry. greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-26 10:24 ` Greg KH @ 2016-09-26 10:30 ` Yannis Damigos 0 siblings, 0 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-26 10:30 UTC (permalink / raw) To: Greg KH; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel On Mon, Sep 26, 2016 at 1:24 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Sep 26, 2016 at 01:11:50PM +0300, Yannis Damigos wrote: >> Hi Greg, >> >> On Fri, Sep 23, 2016 at 3:06 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > >> > Have you tested that this works? >> > >> >> In order to test the change I need a board with Hi6220 SoC. >> If I do not own the hardware to test the change, how should I proceed? > > For something like this, that isn't really a trivial patch, I'd like to > have someone that has the hardware be able to test it before accepting > the patch, sorry. Should I resend the other patches and exclude this one? thanks, Yannis ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function 2016-09-23 9:50 ` [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos 2016-09-23 12:06 ` Greg KH @ 2016-09-23 12:18 ` Greg KH 2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos 1 sibling, 1 reply; 23+ messages in thread From: Greg KH @ 2016-09-23 12:18 UTC (permalink / raw) To: Yannis Damigos; +Cc: markus.boehme, devel, arve, riandrews, linux-kernel On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote: > This patch removes the empty function rmem_ion_device_release > > Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> > --- > drivers/staging/android/ion/ion_of.c | 7 ------- > 1 file changed, 7 deletions(-) Please just resend the whole series for the next time you update these, it makes it easier to review, and apply. thanks, greg k-h ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL 2016-09-23 12:18 ` Greg KH @ 2016-09-27 7:38 ` Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos ` (2 more replies) 0 siblings, 3 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-27 7:38 UTC (permalink / raw) To: gregkh Cc: markus.boehme, arve, riandrews, devel, linux-kernel, Yannis Damigos This patch fixes the following comparison with NULL issues: CHECK: Comparison to NULL could be written "compatible[i].name" + for (i = 0; compatible[i].name != NULL; i++) { CHECK: Comparison to NULL could be written "!compatible[i].name" + if (compatible[i].name == NULL) Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 826e756..a8050c6 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -31,12 +31,12 @@ static int ion_parse_dt_heap_common(struct device_node *heap_node, { int i; - for (i = 0; compatible[i].name != NULL; i++) { + for (i = 0; compatible[i].name; i++) { if (of_device_is_compatible(heap_node, compatible[i].compat)) break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCHv4 2/4] staging:android:ion: Fix alignment issues 2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos @ 2016-09-27 7:38 ` Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos 2 siblings, 0 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-27 7:38 UTC (permalink / raw) To: gregkh Cc: markus.boehme, arve, riandrews, devel, linux-kernel, Yannis Damigos This patch fixes the following whitespace issues: CHECK: Alignment should match open parenthesis + pr_info("%s: id %d type %d name %s align %lx\n", __func__, + heap->id, heap->type, heap->name, heap->align); CHECK: Alignment should match open parenthesis +struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, + struct ion_of_heap *compatible) CHECK: Alignment should match open parenthesis + heaps = devm_kzalloc(&pdev->dev, + sizeof(struct ion_platform_heap)*num_heaps, CHECK: Alignment should match open parenthesis + data = devm_kzalloc(&pdev->dev, sizeof(struct ion_platform_data), + GFP_KERNEL); CHECK: Alignment should match open parenthesis + heap_pdev = of_platform_device_create(node, heaps[i].name, + &pdev->dev); CHECK: Alignment should match open parenthesis + pr_debug("%s: heap %s base %pa size %pa dev %p\n", __func__, + heap->name, &rmem->base, &rmem->size, dev); CHECK: Alignment should match open parenthesis +static void rmem_ion_device_release(struct reserved_mem *rmem, + struct device *dev) Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index a8050c6..d090c3a 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -47,7 +47,7 @@ static int ion_parse_dt_heap_common(struct device_node *heap_node, /* Some kind of callback function pointer? */ pr_info("%s: id %d type %d name %s align %lx\n", __func__, - heap->id, heap->type, heap->name, heap->align); + heap->id, heap->type, heap->name, heap->align); return 0; } @@ -73,7 +73,7 @@ static int ion_setup_heap_common(struct platform_device *parent, } struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, - struct ion_of_heap *compatible) + struct ion_of_heap *compatible) { int num_heaps, ret; const struct device_node *dt_node = pdev->dev.of_node; @@ -88,13 +88,13 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(-EINVAL); heaps = devm_kzalloc(&pdev->dev, - sizeof(struct ion_platform_heap)*num_heaps, - GFP_KERNEL); + sizeof(struct ion_platform_heap)*num_heaps, + GFP_KERNEL); if (!heaps) return ERR_PTR(-ENOMEM); data = devm_kzalloc(&pdev->dev, sizeof(struct ion_platform_data), - GFP_KERNEL); + GFP_KERNEL); if (!data) return ERR_PTR(-ENOMEM); @@ -106,7 +106,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(ret); heap_pdev = of_platform_device_create(node, heaps[i].name, - &pdev->dev); + &pdev->dev); if (!pdev) return ERR_PTR(-ENOMEM); heap_pdev->dev.platform_data = &heaps[i]; @@ -155,12 +155,12 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev) heap->base = rmem->base; heap->base = rmem->size; pr_debug("%s: heap %s base %pa size %pa dev %p\n", __func__, - heap->name, &rmem->base, &rmem->size, dev); + heap->name, &rmem->base, &rmem->size, dev); return 0; } static void rmem_ion_device_release(struct reserved_mem *rmem, - struct device *dev) + struct device *dev) { return; } -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCHv4 3/4] staging:android:ion: Fix blank line issues 2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos @ 2016-09-27 7:38 ` Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos 2 siblings, 0 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-27 7:38 UTC (permalink / raw) To: gregkh Cc: markus.boehme, arve, riandrews, devel, linux-kernel, Yannis Damigos This patch fixes the following blank line issues: CHECK: Please don't use multiple blank lines CHECK: Please use a blank line after function/struct/union/enum declarations +} +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index d090c3a..25f688c 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -119,7 +119,6 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, i++; } - data->heaps = heaps; data->nr = num_heaps; return data; @@ -181,5 +180,6 @@ static int __init rmem_ion_setup(struct reserved_mem *rmem) rmem->ops = &rmem_dma_ops; return 0; } + RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup); #endif -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCHv4 4/4] staging:android:ion: Fix whitespace issue 2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos @ 2016-09-27 7:38 ` Yannis Damigos 2 siblings, 0 replies; 23+ messages in thread From: Yannis Damigos @ 2016-09-27 7:38 UTC (permalink / raw) To: gregkh Cc: markus.boehme, arve, riandrews, devel, linux-kernel, Yannis Damigos This patch fixes the following whitespace issue: CHECK: spaces preferred around that '*' (ctx:VxV) FILE: drivers/staging/android/ion/ion_of.c:91: + sizeof(struct ion_platform_heap)*num_heaps, Signed-off-by: Yannis Damigos <giannis.damigos@gmail.com> --- drivers/staging/android/ion/ion_of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 25f688c..15bac92 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -88,7 +88,7 @@ struct ion_platform_data *ion_parse_dt(struct platform_device *pdev, return ERR_PTR(-EINVAL); heaps = devm_kzalloc(&pdev->dev, - sizeof(struct ion_platform_heap)*num_heaps, + sizeof(struct ion_platform_heap) * num_heaps, GFP_KERNEL); if (!heaps) return ERR_PTR(-ENOMEM); -- 2.10.0 ^ permalink raw reply related [flat|nested] 23+ messages in thread
end of thread, other threads:[~2016-09-27 7:40 UTC | newest] Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-09-22 17:55 [PATCH] staging:android:io: Fix multiple styling issues Yannis Damigos 2016-09-22 18:22 ` Markus Böhme 2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos 2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos 2016-09-23 12:17 ` Greg KH 2016-09-23 8:05 ` [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos 2016-09-23 12:17 ` Greg KH 2016-09-23 13:26 ` Yannis Damigos 2016-09-23 15:06 ` Greg KH 2016-09-23 8:05 ` [PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos 2016-09-23 8:05 ` [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos 2016-09-23 8:44 ` Greg KH 2016-09-23 9:50 ` [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos 2016-09-23 12:06 ` Greg KH 2016-09-23 13:50 ` Yannis Damigos 2016-09-26 10:11 ` Yannis Damigos 2016-09-26 10:24 ` Greg KH 2016-09-26 10:30 ` Yannis Damigos 2016-09-23 12:18 ` Greg KH 2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos 2016-09-27 7:38 ` [PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.