From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Ahern <dsa@cumulusnetworks.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 28 Sep 2016 13:17:26 +0300 [thread overview]
Message-ID: <20160928101726.GU1876@uranus.lan> (raw)
In-Reply-To: <caef7649-9d25-6429-eeab-96c027d6cbc2@mojatatu.com>
On Wed, Sep 28, 2016 at 06:08:00AM -0400, Jamal Hadi Salim wrote:
...
> > @@ -38,7 +38,10 @@ struct inet_diag_req_v2 {
> > __u8 sdiag_family;
> > __u8 sdiag_protocol;
> > __u8 idiag_ext;
> > - __u8 pad;
> > + union {
> > + __u8 pad;
> > + __u8 sdiag_raw_protocol; /* SOCK_RAW only, @pad for others */
> > + };
>
>
> Above looks funny. Why is it a union? pad is for exposing a byte-hole
> for padding/alignment reasons and i doubt anybody is using it.
Someone may have set it to zero explicitly on source level, and the
compilation will fail on new kernel then. So no, keeping the name
is reasonable.
> Should you not just rename it?
> Also I notice when things like __raw_v4_lookup() are claiming it is unsigned
> short instead of a u8?
The protocol is still up to 255 for a while, is it expected that IPPROTO_MAX
will be increased in more-less near future? Of course I can drop the idea
of using @pad here and switch to some extended reauest but prefer to stick
with simplier solution. Hm?
next prev parent reply other threads:[~2016-09-28 10:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:03 [PATCH v5] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov
2016-09-28 10:08 ` Jamal Hadi Salim
2016-09-28 10:17 ` Cyrill Gorcunov [this message]
2016-09-28 10:43 ` Jamal Hadi Salim
2016-09-28 10:51 ` Cyrill Gorcunov
2016-09-28 11:06 ` Jamal Hadi Salim
2016-09-28 11:27 ` Cyrill Gorcunov
2016-09-28 12:06 ` Jamal Hadi Salim
2016-09-28 12:09 ` David Miller
2016-09-28 12:21 ` Cyrill Gorcunov
2016-09-28 12:07 ` David Miller
2016-09-28 12:09 ` Jamal Hadi Salim
2016-09-28 12:16 ` David Miller
2016-09-28 12:27 ` Jamal Hadi Salim
2016-09-28 12:38 ` Jamal Hadi Salim
2016-09-28 12:45 ` Cyrill Gorcunov
2016-09-28 12:50 ` Jamal Hadi Salim
2016-09-28 12:57 ` Cyrill Gorcunov
2016-09-28 12:18 ` Cyrill Gorcunov
2016-09-28 12:57 ` Eric Dumazet
2016-09-28 13:02 ` Eric Dumazet
2016-09-28 13:09 ` Cyrill Gorcunov
2016-09-28 13:03 ` Cyrill Gorcunov
2016-09-28 13:29 ` Eric Dumazet
2016-09-28 13:43 ` Cyrill Gorcunov
2016-09-28 13:49 ` Eric Dumazet
2016-09-28 14:55 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928101726.GU1876@uranus.lan \
--to=gorcunov@gmail.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.