All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, dsa@cumulusnetworks.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 28 Sep 2016 15:45:20 +0300	[thread overview]
Message-ID: <20160928124520.GZ1876@uranus.lan> (raw)
In-Reply-To: <70b51ac5-a7d1-8b52-90c4-7f80ec8ad4d5@mojatatu.com>

On Wed, Sep 28, 2016 at 08:27:24AM -0400, Jamal Hadi Salim wrote:
> > 
> > They must initialize it to zero.
> > 
> 
> What if in the future actually meant to use 0 for
> something?;-> For example in Cyrill's case it means PROTO_IP
> Not sure if it useful to interpret or not but it is part of the
> enum for protocols.

It will be perfectly fine if we start using 0 here for something,
the main match key is @sdiag_proto (which will be IPPROTO_RAW for
my case). If someone is to use this field for something else the
main key selection remain the same, iow @sdiag_proto first and
then subprotocol if needed.

> Maybe we shouldnt be adding pad fields in these netlink
> structure definitions then one can liberally add new ones.

You know, I personally don't see much problem in defining union,
especially while anonymous uninons do work for us here.

> Note: inet_diag somewhere has a netlink structure that
> has a hole. I pointed it out to Eric D. and he said we cant
> add it now because it would break ABI.

Naming holes generated by a compiler for alignment sake should
not break abi (because alignments are abi by self), but I may
be missing something in context of where the structure you're
talking about is present. And what about non-x86 archs? They
might have different members alignment requirements.

> So where do we draw the line for future extensions?

  parent reply	other threads:[~2016-09-28 12:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28  9:03 [PATCH v5] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov
2016-09-28 10:08 ` Jamal Hadi Salim
2016-09-28 10:17   ` Cyrill Gorcunov
2016-09-28 10:43     ` Jamal Hadi Salim
2016-09-28 10:51       ` Cyrill Gorcunov
2016-09-28 11:06         ` Jamal Hadi Salim
2016-09-28 11:27           ` Cyrill Gorcunov
2016-09-28 12:06             ` Jamal Hadi Salim
2016-09-28 12:09               ` David Miller
2016-09-28 12:21               ` Cyrill Gorcunov
2016-09-28 12:07             ` David Miller
2016-09-28 12:09               ` Jamal Hadi Salim
2016-09-28 12:16                 ` David Miller
2016-09-28 12:27                   ` Jamal Hadi Salim
2016-09-28 12:38                     ` Jamal Hadi Salim
2016-09-28 12:45                     ` Cyrill Gorcunov [this message]
2016-09-28 12:50                       ` Jamal Hadi Salim
2016-09-28 12:57                         ` Cyrill Gorcunov
2016-09-28 12:18               ` Cyrill Gorcunov
2016-09-28 12:57             ` Eric Dumazet
2016-09-28 13:02               ` Eric Dumazet
2016-09-28 13:09                 ` Cyrill Gorcunov
2016-09-28 13:03               ` Cyrill Gorcunov
2016-09-28 13:29                 ` Eric Dumazet
2016-09-28 13:43                   ` Cyrill Gorcunov
2016-09-28 13:49                     ` Eric Dumazet
2016-09-28 14:55                       ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928124520.GZ1876@uranus.lan \
    --to=gorcunov@gmail.com \
    --cc=avagin@openvz.org \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.