From: Jamal Hadi Salim <jhs@mojatatu.com>
To: David Miller <davem@davemloft.net>
Cc: gorcunov@gmail.com, eric.dumazet@gmail.com,
dsa@cumulusnetworks.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
avagin@openvz.org, stephen@networkplumber.org
Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets
Date: Wed, 28 Sep 2016 08:38:26 -0400 [thread overview]
Message-ID: <df4fcadf-2442-7ad9-ca38-769842f7a7cb@mojatatu.com> (raw)
In-Reply-To: <70b51ac5-a7d1-8b52-90c4-7f80ec8ad4d5@mojatatu.com>
On 16-09-28 08:27 AM, Jamal Hadi Salim wrote:
> On 16-09-28 08:16 AM, David Miller wrote:
>> From: Jamal Hadi Salim <jhs@mojatatu.com>
>> Date: Wed, 28 Sep 2016 08:09:28 -0400
>>
>>> On 16-09-28 08:07 AM, David Miller wrote:
>>>
>>>> Right, it would be legal for an existing user to have code that
>>>> explicitly initializes every member of the structure, including 'pad'.
>>>> So we have to keep that member around, at a minimum, for their sake.
>>>>
>>>
>>> I think we need to start labelling any new pad fields added as
>>> "Not UAPI. Do not fsck fondle this".
>>
>> They must initialize it to zero.
>>
>
> What if in the future actually meant to use 0 for
> something?;-> For example in Cyrill's case it means PROTO_IP
> Not sure if it useful to interpret or not but it is part of the
> enum for protocols.
I just tested with: socket(AF_INET, SOCK_RAW, 0);
and got back: EPROTONOSUPPORT
So in this case doesnt matter. But my point stands i.e 0 could mean
something.
cheers,
jamal
next prev parent reply other threads:[~2016-09-28 12:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 9:03 [PATCH v5] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov
2016-09-28 10:08 ` Jamal Hadi Salim
2016-09-28 10:17 ` Cyrill Gorcunov
2016-09-28 10:43 ` Jamal Hadi Salim
2016-09-28 10:51 ` Cyrill Gorcunov
2016-09-28 11:06 ` Jamal Hadi Salim
2016-09-28 11:27 ` Cyrill Gorcunov
2016-09-28 12:06 ` Jamal Hadi Salim
2016-09-28 12:09 ` David Miller
2016-09-28 12:21 ` Cyrill Gorcunov
2016-09-28 12:07 ` David Miller
2016-09-28 12:09 ` Jamal Hadi Salim
2016-09-28 12:16 ` David Miller
2016-09-28 12:27 ` Jamal Hadi Salim
2016-09-28 12:38 ` Jamal Hadi Salim [this message]
2016-09-28 12:45 ` Cyrill Gorcunov
2016-09-28 12:50 ` Jamal Hadi Salim
2016-09-28 12:57 ` Cyrill Gorcunov
2016-09-28 12:18 ` Cyrill Gorcunov
2016-09-28 12:57 ` Eric Dumazet
2016-09-28 13:02 ` Eric Dumazet
2016-09-28 13:09 ` Cyrill Gorcunov
2016-09-28 13:03 ` Cyrill Gorcunov
2016-09-28 13:29 ` Eric Dumazet
2016-09-28 13:43 ` Cyrill Gorcunov
2016-09-28 13:49 ` Eric Dumazet
2016-09-28 14:55 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df4fcadf-2442-7ad9-ca38-769842f7a7cb@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=avagin@openvz.org \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=eric.dumazet@gmail.com \
--cc=gorcunov@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.