* [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check
@ 2016-09-28 3:44 Eryu Guan
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Eryu Guan @ 2016-09-28 3:44 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan
generic/052 was made generic from an xfs test, and generic functions
should be used not the xfs-specific ones.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/generic/052 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/generic/052 b/tests/generic/052
index a81885b..74cf5b6 100755
--- a/tests/generic/052
+++ b/tests/generic/052
@@ -72,7 +72,7 @@ _print_logstate
# curious if FS consistent at start
if false; then
- if _xfs_check $SCRATCH_DEV; then
+ if _check_scratch_fs; then
echo "*** checked ok ***"
fi
fi
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] xfs/287: fix wrong seq number in test
2016-09-28 3:44 [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Eryu Guan
@ 2016-09-28 3:44 ` Eryu Guan
2016-09-29 6:29 ` Dave Chinner
2016-09-29 6:28 ` [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Dave Chinner
2016-09-29 8:01 ` Zorro Lang
2 siblings, 1 reply; 5+ messages in thread
From: Eryu Guan @ 2016-09-28 3:44 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan
It's 287 not 285.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/xfs/287 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/287 b/tests/xfs/287
index aca410a..766c91e 100755
--- a/tests/xfs/287
+++ b/tests/xfs/287
@@ -1,5 +1,5 @@
#! /bin/bash
-# FS QA Test No. 285
+# FS QA Test No. 287
#
# Test to verify project quota xfs_admin, xfsdump/xfsrestore and
# xfs_db functionality
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check
2016-09-28 3:44 [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Eryu Guan
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
@ 2016-09-29 6:28 ` Dave Chinner
2016-09-29 8:01 ` Zorro Lang
2 siblings, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2016-09-29 6:28 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote:
> generic/052 was made generic from an xfs test, and generic functions
> should be used not the xfs-specific ones.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/generic/052 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/052 b/tests/generic/052
> index a81885b..74cf5b6 100755
> --- a/tests/generic/052
> +++ b/tests/generic/052
> @@ -72,7 +72,7 @@ _print_logstate
>
> # curious if FS consistent at start
> if false; then
> - if _xfs_check $SCRATCH_DEV; then
> + if _check_scratch_fs; then
> echo "*** checked ok ***"
> fi
> fi
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xfs/287: fix wrong seq number in test
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
@ 2016-09-29 6:29 ` Dave Chinner
0 siblings, 0 replies; 5+ messages in thread
From: Dave Chinner @ 2016-09-29 6:29 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Wed, Sep 28, 2016 at 11:44:10AM +0800, Eryu Guan wrote:
> It's 287 not 285.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Easy to miss when moving tests manually. Fix looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/xfs/287 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/287 b/tests/xfs/287
> index aca410a..766c91e 100755
> --- a/tests/xfs/287
> +++ b/tests/xfs/287
> @@ -1,5 +1,5 @@
> #! /bin/bash
> -# FS QA Test No. 285
> +# FS QA Test No. 287
> #
> # Test to verify project quota xfs_admin, xfsdump/xfsrestore and
> # xfs_db functionality
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check
2016-09-28 3:44 [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Eryu Guan
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
2016-09-29 6:28 ` [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Dave Chinner
@ 2016-09-29 8:01 ` Zorro Lang
2 siblings, 0 replies; 5+ messages in thread
From: Zorro Lang @ 2016-09-29 8:01 UTC (permalink / raw)
To: fstests
On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote:
> generic/052 was made generic from an xfs test, and generic functions
> should be used not the xfs-specific ones.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> tests/generic/052 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/052 b/tests/generic/052
> index a81885b..74cf5b6 100755
> --- a/tests/generic/052
> +++ b/tests/generic/052
> @@ -72,7 +72,7 @@ _print_logstate
>
> # curious if FS consistent at start
> if false; then
> - if _xfs_check $SCRATCH_DEV; then
> + if _check_scratch_fs; then
Looks good to me. Test passed on newest upstream kernel+xfsprogs and
RHEL-6.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> echo "*** checked ok ***"
> fi
> fi
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-29 8:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-28 3:44 [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Eryu Guan
2016-09-28 3:44 ` [PATCH 2/2] xfs/287: fix wrong seq number in test Eryu Guan
2016-09-29 6:29 ` Dave Chinner
2016-09-29 6:28 ` [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check Dave Chinner
2016-09-29 8:01 ` Zorro Lang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.