[PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check

[PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check

[Eryu Guan]

generic/052 was made generic from an xfs test, and generic functions
should be used not the xfs-specific ones.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 tests/generic/052 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/generic/052 b/tests/generic/052
index a81885b..74cf5b6 100755
--- a/tests/generic/052
+++ b/tests/generic/052
@@ -72,7 +72,7 @@ _print_logstate
 
 # curious if FS consistent at start
 if false; then
-    if _xfs_check $SCRATCH_DEV; then
+    if _check_scratch_fs; then
        echo "*** checked ok ***"
     fi
 fi
-- 
2.7.4

[PATCH 2/2] xfs/287: fix wrong seq number in test

[Eryu Guan]

It's 287 not 285.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
 tests/xfs/287 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/287 b/tests/xfs/287
index aca410a..766c91e 100755
--- a/tests/xfs/287
+++ b/tests/xfs/287
@@ -1,5 +1,5 @@
 #! /bin/bash
-# FS QA Test No. 285
+# FS QA Test No. 287
 #
 # Test to verify project quota xfs_admin, xfsdump/xfsrestore and
 # xfs_db functionality
-- 
2.7.4

Re: [PATCH 2/2] xfs/287: fix wrong seq number in test

[Dave Chinner]

On Wed, Sep 28, 2016 at 11:44:10AM +0800, Eryu Guan wrote:
> It's 287 not 285.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>

Easy to miss when moving tests manually. Fix looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

> ---
>  tests/xfs/287 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/287 b/tests/xfs/287
> index aca410a..766c91e 100755
> --- a/tests/xfs/287
> +++ b/tests/xfs/287
> @@ -1,5 +1,5 @@
>  #! /bin/bash
> -# FS QA Test No. 285
> +# FS QA Test No. 287
>  #
>  # Test to verify project quota xfs_admin, xfsdump/xfsrestore and
>  # xfs_db functionality
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check

[Dave Chinner]

On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote:
> generic/052 was made generic from an xfs test, and generic functions
> should be used not the xfs-specific ones.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

> ---
>  tests/generic/052 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/052 b/tests/generic/052
> index a81885b..74cf5b6 100755
> --- a/tests/generic/052
> +++ b/tests/generic/052
> @@ -72,7 +72,7 @@ _print_logstate
>  
>  # curious if FS consistent at start
>  if false; then
> -    if _xfs_check $SCRATCH_DEV; then
> +    if _check_scratch_fs; then
>         echo "*** checked ok ***"
>      fi
>  fi
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH 1/2] generic/052: use _check_scratch_fs not _xfs_check

[Zorro Lang]

On Wed, Sep 28, 2016 at 11:44:09AM +0800, Eryu Guan wrote:
> generic/052 was made generic from an xfs test, and generic functions
> should be used not the xfs-specific ones.
> 
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
>  tests/generic/052 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/052 b/tests/generic/052
> index a81885b..74cf5b6 100755
> --- a/tests/generic/052
> +++ b/tests/generic/052
> @@ -72,7 +72,7 @@ _print_logstate
>  
>  # curious if FS consistent at start
>  if false; then
> -    if _xfs_check $SCRATCH_DEV; then
> +    if _check_scratch_fs; then

Looks good to me. Test passed on newest upstream kernel+xfsprogs and
RHEL-6.

Reviewed-by: Zorro Lang <zlang@redhat.com>

>         echo "*** checked ok ***"
>      fi
>  fi
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html