All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
	stefanha@redhat.com, mst@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com, dan.j.williams@intel.com,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 4/8] nvdimm acpi: implement Read FIT function
Date: Fri, 30 Sep 2016 15:17:22 +0200	[thread overview]
Message-ID: <20160930151722.07dd827c@nial.brq.redhat.com> (raw)
In-Reply-To: <1470984850-66891-5-git-send-email-guangrong.xiao@linux.intel.com>

On Fri, 12 Aug 2016 14:54:06 +0800
Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:

> Read FIT whose function index is 0xFFFFFFFF is reserved by QEMU to read
> the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for
> detailed info

Pls, squash this patch into 3/8

> 
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> ---
>  hw/acpi/nvdimm.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
> 
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index 4bbd1e7..f6f8413 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -466,6 +466,22 @@ typedef struct NvdimmFuncSetLabelDataIn NvdimmFuncSetLabelDataIn;
>  QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncSetLabelDataIn) +
>                    offsetof(NvdimmDsmIn, arg3) > 4096);
>  
> +struct NvdimmFuncReadFITIn {
> +    uint32_t offset; /* the offset of FIT buffer. */
> +} QEMU_PACKED;
> +typedef struct NvdimmFuncReadFITIn NvdimmFuncReadFITIn;
> +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncReadFITIn) +
> +                  offsetof(NvdimmDsmIn, arg3) > 4096);
> +
> +struct NvdimmFuncReadFITOut {
> +    /* the size of buffer filled by QEMU. */
> +    uint32_t len;
> +    uint32_t func_ret_status; /* return status code. */
> +    uint8_t fit[0]; /* the FIT data. */
> +} QEMU_PACKED;
> +typedef struct NvdimmFuncReadFITOut NvdimmFuncReadFITOut;
> +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncReadFITOut) > 4096);
> +
>  static void
>  nvdimm_dsm_function0(uint32_t supported_func, hwaddr dsm_mem_addr)
>  {
> @@ -486,6 +502,46 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr)
>      cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out));
>  }
>  
> +/* Read FIT data, defined in docs/specs/acpi_nvdimm.txt. */
> +static void nvdimm_dsm_func_read_fit(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
> +{
> +    NvdimmFuncReadFITIn *read_fit;
> +    NvdimmFuncReadFITOut *read_fit_out;
> +    GSList *device_list = nvdimm_get_plugged_device_list();
> +    GArray *fit = nvdimm_build_device_structure(device_list);
> +    uint32_t read_len = 0, func_ret_status;
> +    int size;
> +
> +    read_fit = (NvdimmFuncReadFITIn *)in->arg3;
> +    le32_to_cpus(&read_fit->offset);
> +
> +    nvdimm_debug("Read FIT: offset %#x FIT size %#x.\n", read_fit->offset,
> +                 fit->len);
> +
> +    if (read_fit->offset > fit->len) {
> +        func_ret_status = 3 /* Invalid Input Parameters */;
> +        goto build_out;
> +    }
> +
> +    func_ret_status = 0 /* Success */;
> +    read_len = MIN(fit->len - read_fit->offset,
> +                   4096 - sizeof(NvdimmFuncReadFITOut));
> +
> +build_out:
> +    size = sizeof(NvdimmFuncReadFITOut) + read_len;
> +    read_fit_out = g_malloc(size);
> +
> +    read_fit_out->len = cpu_to_le32(size);
> +    read_fit_out->func_ret_status = cpu_to_le32(func_ret_status);
> +    memcpy(read_fit_out->fit, fit->data + read_fit->offset, read_len);
> +
> +    cpu_physical_memory_write(dsm_mem_addr, read_fit_out, size);
> +
> +    g_slist_free(device_list);
> +    g_array_free(fit, true);
> +    g_free(read_fit_out);
> +}
> +
>  static void nvdimm_dsm_root(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
>  {
>      /*
> @@ -498,6 +554,11 @@ static void nvdimm_dsm_root(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
>          return;
>      }
>  
> +    if (in->function == 0xFFFFFFFF /* Read FIT */) {
> +        nvdimm_dsm_func_read_fit(in, dsm_mem_addr);
> +        return;
> +    }
> +
>      /* No function except function 0 is supported yet. */
>      nvdimm_dsm_no_payload(1 /* Not Supported */, dsm_mem_addr);
>  }


WARNING: multiple messages have this Message-ID (diff)
From: Igor Mammedov <imammedo@redhat.com>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
	stefanha@redhat.com, mst@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com, dan.j.williams@intel.com,
	kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/8] nvdimm acpi: implement Read FIT function
Date: Fri, 30 Sep 2016 15:17:22 +0200	[thread overview]
Message-ID: <20160930151722.07dd827c@nial.brq.redhat.com> (raw)
In-Reply-To: <1470984850-66891-5-git-send-email-guangrong.xiao@linux.intel.com>

On Fri, 12 Aug 2016 14:54:06 +0800
Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:

> Read FIT whose function index is 0xFFFFFFFF is reserved by QEMU to read
> the piece of FIT buffer. Please refer to docs/specs/acpi_nvdimm.txt for
> detailed info

Pls, squash this patch into 3/8

> 
> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> ---
>  hw/acpi/nvdimm.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
> 
> diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
> index 4bbd1e7..f6f8413 100644
> --- a/hw/acpi/nvdimm.c
> +++ b/hw/acpi/nvdimm.c
> @@ -466,6 +466,22 @@ typedef struct NvdimmFuncSetLabelDataIn NvdimmFuncSetLabelDataIn;
>  QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncSetLabelDataIn) +
>                    offsetof(NvdimmDsmIn, arg3) > 4096);
>  
> +struct NvdimmFuncReadFITIn {
> +    uint32_t offset; /* the offset of FIT buffer. */
> +} QEMU_PACKED;
> +typedef struct NvdimmFuncReadFITIn NvdimmFuncReadFITIn;
> +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncReadFITIn) +
> +                  offsetof(NvdimmDsmIn, arg3) > 4096);
> +
> +struct NvdimmFuncReadFITOut {
> +    /* the size of buffer filled by QEMU. */
> +    uint32_t len;
> +    uint32_t func_ret_status; /* return status code. */
> +    uint8_t fit[0]; /* the FIT data. */
> +} QEMU_PACKED;
> +typedef struct NvdimmFuncReadFITOut NvdimmFuncReadFITOut;
> +QEMU_BUILD_BUG_ON(sizeof(NvdimmFuncReadFITOut) > 4096);
> +
>  static void
>  nvdimm_dsm_function0(uint32_t supported_func, hwaddr dsm_mem_addr)
>  {
> @@ -486,6 +502,46 @@ nvdimm_dsm_no_payload(uint32_t func_ret_status, hwaddr dsm_mem_addr)
>      cpu_physical_memory_write(dsm_mem_addr, &out, sizeof(out));
>  }
>  
> +/* Read FIT data, defined in docs/specs/acpi_nvdimm.txt. */
> +static void nvdimm_dsm_func_read_fit(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
> +{
> +    NvdimmFuncReadFITIn *read_fit;
> +    NvdimmFuncReadFITOut *read_fit_out;
> +    GSList *device_list = nvdimm_get_plugged_device_list();
> +    GArray *fit = nvdimm_build_device_structure(device_list);
> +    uint32_t read_len = 0, func_ret_status;
> +    int size;
> +
> +    read_fit = (NvdimmFuncReadFITIn *)in->arg3;
> +    le32_to_cpus(&read_fit->offset);
> +
> +    nvdimm_debug("Read FIT: offset %#x FIT size %#x.\n", read_fit->offset,
> +                 fit->len);
> +
> +    if (read_fit->offset > fit->len) {
> +        func_ret_status = 3 /* Invalid Input Parameters */;
> +        goto build_out;
> +    }
> +
> +    func_ret_status = 0 /* Success */;
> +    read_len = MIN(fit->len - read_fit->offset,
> +                   4096 - sizeof(NvdimmFuncReadFITOut));
> +
> +build_out:
> +    size = sizeof(NvdimmFuncReadFITOut) + read_len;
> +    read_fit_out = g_malloc(size);
> +
> +    read_fit_out->len = cpu_to_le32(size);
> +    read_fit_out->func_ret_status = cpu_to_le32(func_ret_status);
> +    memcpy(read_fit_out->fit, fit->data + read_fit->offset, read_len);
> +
> +    cpu_physical_memory_write(dsm_mem_addr, read_fit_out, size);
> +
> +    g_slist_free(device_list);
> +    g_array_free(fit, true);
> +    g_free(read_fit_out);
> +}
> +
>  static void nvdimm_dsm_root(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
>  {
>      /*
> @@ -498,6 +554,11 @@ static void nvdimm_dsm_root(NvdimmDsmIn *in, hwaddr dsm_mem_addr)
>          return;
>      }
>  
> +    if (in->function == 0xFFFFFFFF /* Read FIT */) {
> +        nvdimm_dsm_func_read_fit(in, dsm_mem_addr);
> +        return;
> +    }
> +
>      /* No function except function 0 is supported yet. */
>      nvdimm_dsm_no_payload(1 /* Not Supported */, dsm_mem_addr);
>  }

  reply	other threads:[~2016-09-30 13:17 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  6:54 [PATCH v2 0/8] nvdimm: hotplug support Xiao Guangrong
2016-08-12  6:54 ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-09-20 14:07   ` Igor Mammedov
2016-09-20 14:07     ` [Qemu-devel] " Igor Mammedov
2016-09-20 15:14     ` Michael S. Tsirkin
2016-09-20 15:14       ` [Qemu-devel] " Michael S. Tsirkin
2016-09-20 16:23       ` Igor Mammedov
2016-09-21  5:30     ` Xiao Guangrong
2016-09-21  5:30       ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 2/8] nvdimm acpi: prebuild nvdimm devices for available slots Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-09-21 11:48   ` Igor Mammedov
2016-09-21 11:48     ` [Qemu-devel] " Igor Mammedov
2016-09-22  2:43     ` Xiao Guangrong
2016-09-22  2:43       ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 3/8] nvdimm acpi: introduce _FIT Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-09-30 13:14   ` Igor Mammedov
2016-09-30 13:14     ` [Qemu-devel] " Igor Mammedov
2016-10-08  7:17     ` Xiao Guangrong
2016-10-08  7:17       ` [Qemu-devel] " Xiao Guangrong
2016-10-10 12:51       ` Igor Mammedov
2016-10-10 12:51         ` [Qemu-devel] " Igor Mammedov
2016-10-10 13:09         ` Xiao Guangrong
2016-10-10 13:09           ` [Qemu-devel] " Xiao Guangrong
2016-10-11 11:49           ` Igor Mammedov
2016-10-11 11:49             ` [Qemu-devel] " Igor Mammedov
2016-10-12  8:20             ` Xiao Guangrong
2016-10-12  8:20               ` [Qemu-devel] " Xiao Guangrong
2016-10-13 13:33               ` Igor Mammedov
2016-10-14  7:43                 ` Xiao Guangrong
2016-10-14 11:59                   ` Igor Mammedov
2016-08-12  6:54 ` [PATCH v2 4/8] nvdimm acpi: implement Read FIT function Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-09-30 13:17   ` Igor Mammedov [this message]
2016-09-30 13:17     ` Igor Mammedov
2016-10-08  7:17     ` Xiao Guangrong
2016-10-08  7:17       ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-10-03  9:45   ` Igor Mammedov
2016-10-03  9:45     ` [Qemu-devel] " Igor Mammedov
2016-10-08  7:20     ` Xiao Guangrong
2016-10-08  7:20       ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-10-03 13:21   ` Igor Mammedov
2016-10-03 13:21     ` [Qemu-devel] " Igor Mammedov
2016-10-08  7:42     ` Xiao Guangrong
2016-10-08  7:42       ` [Qemu-devel] " Xiao Guangrong
2016-10-10 12:47       ` Igor Mammedov
2016-10-10 12:47         ` [Qemu-devel] " Igor Mammedov
2016-10-10 13:10         ` Xiao Guangrong
2016-10-10 13:10           ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 7/8] pc: acpi: memhp: nvdimm hotplug support Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-08-12  6:54 ` [PATCH v2 8/8] nvdimm docs: add nvdimm Read FIT function Xiao Guangrong
2016-08-12  6:54   ` [Qemu-devel] " Xiao Guangrong
2016-09-30 14:03   ` Igor Mammedov
2016-09-30 14:03     ` [Qemu-devel] " Igor Mammedov
2016-10-08  7:18     ` Xiao Guangrong
2016-10-08  7:18       ` [Qemu-devel] " Xiao Guangrong
2016-08-12  8:35 ` [PATCH v2 0/8] nvdimm: hotplug support Stefan Hajnoczi
2016-08-12  8:35   ` [Qemu-devel] " Stefan Hajnoczi
2016-08-12 15:13   ` Igor Mammedov
2016-08-12 15:13     ` [Qemu-devel] " Igor Mammedov
2016-09-12  7:33     ` Xiao Guangrong
2016-09-12  7:33       ` [Qemu-devel] " Xiao Guangrong
2016-09-12 12:22       ` Igor Mammedov
2016-08-18 17:47 ` Dan Williams
2016-08-18 17:47   ` [Qemu-devel] " Dan Williams
2016-08-18 18:54   ` Vishal Verma
2016-08-18 18:54     ` [Qemu-devel] " Vishal Verma
2016-08-19  3:40     ` Xiao Guangrong
2016-08-19  3:40       ` [Qemu-devel] " Xiao Guangrong
2016-08-19  3:46       ` Xiao Guangrong
2016-08-19  3:46         ` [Qemu-devel] " Xiao Guangrong
2016-08-19  5:14         ` Dan Williams
2016-08-19  5:14           ` [Qemu-devel] " Dan Williams
2016-10-03 13:48 ` Igor Mammedov
2016-10-08  8:34   ` Xiao Guangrong
2016-10-10 12:59     ` Igor Mammedov
2016-10-10 13:57       ` Xiao Guangrong
2016-10-11 12:32         ` Igor Mammedov
2016-10-12 10:19           ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160930151722.07dd827c@nial.brq.redhat.com \
    --to=imammedo@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.