From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
stefanha@redhat.com, mst@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback
Date: Sat, 8 Oct 2016 15:20:30 +0800 [thread overview]
Message-ID: <16d62eea-19cc-56aa-7b2c-0bf6484ae1bf@linux.intel.com> (raw)
In-Reply-To: <20161003114517.3fd0ab61@nial.brq.redhat.com>
On 10/03/2016 05:45 PM, Igor Mammedov wrote:
> On Fri, 12 Aug 2016 14:54:07 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> We should let nvdimm acpi know which nvdimm device is being unplugged
>> before QEMU interrupts the guest so that nvdimm acpi can update its
>> FIT properly
>>
>> prepare_unplug() callback is introduced exactly for this purpose then
>> the being removed device is skipped when guest reads FIT
> Hot-unplug for NVDIMMs isn't mentinoned in spec so I'd would drop it for now.
Okay. Then i will stop hot-unplug and generate a error message if nvdimm device
is being un-plugged:
"NVDIMM hot-unplug has not been supported yet."
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
stefanha@redhat.com, mst@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, dan.j.williams@intel.com,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback
Date: Sat, 8 Oct 2016 15:20:30 +0800 [thread overview]
Message-ID: <16d62eea-19cc-56aa-7b2c-0bf6484ae1bf@linux.intel.com> (raw)
In-Reply-To: <20161003114517.3fd0ab61@nial.brq.redhat.com>
On 10/03/2016 05:45 PM, Igor Mammedov wrote:
> On Fri, 12 Aug 2016 14:54:07 +0800
> Xiao Guangrong <guangrong.xiao@linux.intel.com> wrote:
>
>> We should let nvdimm acpi know which nvdimm device is being unplugged
>> before QEMU interrupts the guest so that nvdimm acpi can update its
>> FIT properly
>>
>> prepare_unplug() callback is introduced exactly for this purpose then
>> the being removed device is skipped when guest reads FIT
> Hot-unplug for NVDIMMs isn't mentinoned in spec so I'd would drop it for now.
Okay. Then i will stop hot-unplug and generate a error message if nvdimm device
is being un-plugged:
"NVDIMM hot-unplug has not been supported yet."
next prev parent reply other threads:[~2016-10-08 7:27 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 6:54 [PATCH v2 0/8] nvdimm: hotplug support Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 1/8] acpi nvdimm: fix wrong buffer size returned by DSM method Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-09-20 14:07 ` Igor Mammedov
2016-09-20 14:07 ` [Qemu-devel] " Igor Mammedov
2016-09-20 15:14 ` Michael S. Tsirkin
2016-09-20 15:14 ` [Qemu-devel] " Michael S. Tsirkin
2016-09-20 16:23 ` Igor Mammedov
2016-09-21 5:30 ` Xiao Guangrong
2016-09-21 5:30 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 2/8] nvdimm acpi: prebuild nvdimm devices for available slots Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-09-21 11:48 ` Igor Mammedov
2016-09-21 11:48 ` [Qemu-devel] " Igor Mammedov
2016-09-22 2:43 ` Xiao Guangrong
2016-09-22 2:43 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 3/8] nvdimm acpi: introduce _FIT Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-09-30 13:14 ` Igor Mammedov
2016-09-30 13:14 ` [Qemu-devel] " Igor Mammedov
2016-10-08 7:17 ` Xiao Guangrong
2016-10-08 7:17 ` [Qemu-devel] " Xiao Guangrong
2016-10-10 12:51 ` Igor Mammedov
2016-10-10 12:51 ` [Qemu-devel] " Igor Mammedov
2016-10-10 13:09 ` Xiao Guangrong
2016-10-10 13:09 ` [Qemu-devel] " Xiao Guangrong
2016-10-11 11:49 ` Igor Mammedov
2016-10-11 11:49 ` [Qemu-devel] " Igor Mammedov
2016-10-12 8:20 ` Xiao Guangrong
2016-10-12 8:20 ` [Qemu-devel] " Xiao Guangrong
2016-10-13 13:33 ` Igor Mammedov
2016-10-14 7:43 ` Xiao Guangrong
2016-10-14 11:59 ` Igor Mammedov
2016-08-12 6:54 ` [PATCH v2 4/8] nvdimm acpi: implement Read FIT function Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-09-30 13:17 ` Igor Mammedov
2016-09-30 13:17 ` [Qemu-devel] " Igor Mammedov
2016-10-08 7:17 ` Xiao Guangrong
2016-10-08 7:17 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 5/8] pc-dimm: introduce prepare_unplug() callback Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-10-03 9:45 ` Igor Mammedov
2016-10-03 9:45 ` [Qemu-devel] " Igor Mammedov
2016-10-08 7:20 ` Xiao Guangrong [this message]
2016-10-08 7:20 ` Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 6/8] pc: memhp: do not export nvdimm's memory via _CRS Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-10-03 13:21 ` Igor Mammedov
2016-10-03 13:21 ` [Qemu-devel] " Igor Mammedov
2016-10-08 7:42 ` Xiao Guangrong
2016-10-08 7:42 ` [Qemu-devel] " Xiao Guangrong
2016-10-10 12:47 ` Igor Mammedov
2016-10-10 12:47 ` [Qemu-devel] " Igor Mammedov
2016-10-10 13:10 ` Xiao Guangrong
2016-10-10 13:10 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 7/8] pc: acpi: memhp: nvdimm hotplug support Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 6:54 ` [PATCH v2 8/8] nvdimm docs: add nvdimm Read FIT function Xiao Guangrong
2016-08-12 6:54 ` [Qemu-devel] " Xiao Guangrong
2016-09-30 14:03 ` Igor Mammedov
2016-09-30 14:03 ` [Qemu-devel] " Igor Mammedov
2016-10-08 7:18 ` Xiao Guangrong
2016-10-08 7:18 ` [Qemu-devel] " Xiao Guangrong
2016-08-12 8:35 ` [PATCH v2 0/8] nvdimm: hotplug support Stefan Hajnoczi
2016-08-12 8:35 ` [Qemu-devel] " Stefan Hajnoczi
2016-08-12 15:13 ` Igor Mammedov
2016-08-12 15:13 ` [Qemu-devel] " Igor Mammedov
2016-09-12 7:33 ` Xiao Guangrong
2016-09-12 7:33 ` [Qemu-devel] " Xiao Guangrong
2016-09-12 12:22 ` Igor Mammedov
2016-08-18 17:47 ` Dan Williams
2016-08-18 17:47 ` [Qemu-devel] " Dan Williams
2016-08-18 18:54 ` Vishal Verma
2016-08-18 18:54 ` [Qemu-devel] " Vishal Verma
2016-08-19 3:40 ` Xiao Guangrong
2016-08-19 3:40 ` [Qemu-devel] " Xiao Guangrong
2016-08-19 3:46 ` Xiao Guangrong
2016-08-19 3:46 ` [Qemu-devel] " Xiao Guangrong
2016-08-19 5:14 ` Dan Williams
2016-08-19 5:14 ` [Qemu-devel] " Dan Williams
2016-10-03 13:48 ` Igor Mammedov
2016-10-08 8:34 ` Xiao Guangrong
2016-10-10 12:59 ` Igor Mammedov
2016-10-10 13:57 ` Xiao Guangrong
2016-10-11 12:32 ` Igor Mammedov
2016-10-12 10:19 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d62eea-19cc-56aa-7b2c-0bf6484ae1bf@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.