From: Alex Williamson <alex.williamson@redhat.com> To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> Cc: Kirti Wankhede <kwankhede@nvidia.com>, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework. Date: Tue, 18 Oct 2016 11:17:19 -0600 [thread overview] Message-ID: <20161018111719.141fcdaa@t450s.home> (raw) In-Reply-To: <20161018025411.GA22572@bjsdjshi@linux.vnet.ibm.com> On Tue, 18 Oct 2016 10:54:11 +0800 Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote: > * Kirti Wankhede <kwankhede@nvidia.com> [2016-10-18 02:52:12 +0530]: > > ...snip... > > > +static ssize_t mdev_access(struct mdev_device *mdev, char *buf, > > + size_t count, loff_t pos, bool is_write) > > +{ > > + struct mdev_state *mdev_state; > > + unsigned int index; > > + loff_t offset; > > + int ret = 0; > > + > > + if (!mdev || !buf) > > + return -EINVAL; > > + > > + mdev_state = mdev_get_drvdata(mdev); > > + if (!mdev_state) { > > + pr_err("%s mdev_state not found\n", __func__); > > + return -EINVAL; > > + } > > + > > + mutex_lock(&mdev_state->ops_lock); > > + > > + index = MTTY_VFIO_PCI_OFFSET_TO_INDEX(pos); > > + offset = pos & MTTY_VFIO_PCI_OFFSET_MASK; > > + switch (index) { > > + case VFIO_PCI_CONFIG_REGION_INDEX: > > + > > +#if defined(DEBUG) > > + pr_info("%s: PCI config space %s at offset 0x%llx\n", > > + __func__, is_write ? "write" : "read", offset); > > +#endif > > + if (is_write) { > > + dump_buffer(buf, count); > > + handle_pci_cfg_write(mdev_state, offset, buf, count); > > + } else { > > + memcpy(buf, (mdev_state->vconfig + offset), count); > > + dump_buffer(buf, count); > Dear Kirti: > > Shouldn't we use copy_from_user instead of memcpy on @buf here? And I'm > wondering if dump_buffer could really work since it tries to dereference > a *__user* marked pointor. I agree, the __user attribute is getting lost here and we're operating on user buffers as if they were kernel buffers. That's a bug. Thanks, Alex > Otherwise, this is a good example driver. Thanks! > > > + } > > + > > + break; > > + > > + case VFIO_PCI_BAR0_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX: > > + if (!mdev_state->region_info[index].start) > > + mdev_read_base(mdev_state); > > + > > + if (is_write) { > > + dump_buffer(buf, count); > > + > > +#if defined(DEBUG_REGS) > > + pr_info("%s: BAR%d WR @0x%llx %s val:0x%02x dlab:%d\n", > > + __func__, index, offset, wr_reg[offset], > > + (u8)*buf, mdev_state->s[index].dlab); > > +#endif > > + handle_bar_write(index, mdev_state, offset, buf, count); > > + } else { > > + handle_bar_read(index, mdev_state, offset, buf, count); > > + dump_buffer(buf, count); > > + > > +#if defined(DEBUG_REGS) > > + pr_info("%s: BAR%d RD @0x%llx %s val:0x%02x dlab:%d\n", > > + __func__, index, offset, rd_reg[offset], > > + (u8)*buf, mdev_state->s[index].dlab); > > +#endif > > + } > > + break; > > + > > + default: > > + ret = -1; > > + goto accessfailed; > > + } > > + > > + ret = count; > > + > > + > > +accessfailed: > > + mutex_unlock(&mdev_state->ops_lock); > > + > > + return ret; > > +} > > + > ...snip... > > > +ssize_t mtty_read(struct mdev_device *mdev, char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + return mdev_access(mdev, buf, count, *ppos, false); > > +} > > + > > +ssize_t mtty_write(struct mdev_device *mdev, const char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + return mdev_access(mdev, (char *)buf, count, *ppos, true); > > +} > > + > ...snip... >
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com> To: Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> Cc: Kirti Wankhede <kwankhede@nvidia.com>, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, linux-kernel@vger.kernel.org Subject: Re: [Qemu-devel] [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework. Date: Tue, 18 Oct 2016 11:17:19 -0600 [thread overview] Message-ID: <20161018111719.141fcdaa@t450s.home> (raw) In-Reply-To: <20161018025411.GA22572@bjsdjshi@linux.vnet.ibm.com> On Tue, 18 Oct 2016 10:54:11 +0800 Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com> wrote: > * Kirti Wankhede <kwankhede@nvidia.com> [2016-10-18 02:52:12 +0530]: > > ...snip... > > > +static ssize_t mdev_access(struct mdev_device *mdev, char *buf, > > + size_t count, loff_t pos, bool is_write) > > +{ > > + struct mdev_state *mdev_state; > > + unsigned int index; > > + loff_t offset; > > + int ret = 0; > > + > > + if (!mdev || !buf) > > + return -EINVAL; > > + > > + mdev_state = mdev_get_drvdata(mdev); > > + if (!mdev_state) { > > + pr_err("%s mdev_state not found\n", __func__); > > + return -EINVAL; > > + } > > + > > + mutex_lock(&mdev_state->ops_lock); > > + > > + index = MTTY_VFIO_PCI_OFFSET_TO_INDEX(pos); > > + offset = pos & MTTY_VFIO_PCI_OFFSET_MASK; > > + switch (index) { > > + case VFIO_PCI_CONFIG_REGION_INDEX: > > + > > +#if defined(DEBUG) > > + pr_info("%s: PCI config space %s at offset 0x%llx\n", > > + __func__, is_write ? "write" : "read", offset); > > +#endif > > + if (is_write) { > > + dump_buffer(buf, count); > > + handle_pci_cfg_write(mdev_state, offset, buf, count); > > + } else { > > + memcpy(buf, (mdev_state->vconfig + offset), count); > > + dump_buffer(buf, count); > Dear Kirti: > > Shouldn't we use copy_from_user instead of memcpy on @buf here? And I'm > wondering if dump_buffer could really work since it tries to dereference > a *__user* marked pointor. I agree, the __user attribute is getting lost here and we're operating on user buffers as if they were kernel buffers. That's a bug. Thanks, Alex > Otherwise, this is a good example driver. Thanks! > > > + } > > + > > + break; > > + > > + case VFIO_PCI_BAR0_REGION_INDEX ... VFIO_PCI_BAR5_REGION_INDEX: > > + if (!mdev_state->region_info[index].start) > > + mdev_read_base(mdev_state); > > + > > + if (is_write) { > > + dump_buffer(buf, count); > > + > > +#if defined(DEBUG_REGS) > > + pr_info("%s: BAR%d WR @0x%llx %s val:0x%02x dlab:%d\n", > > + __func__, index, offset, wr_reg[offset], > > + (u8)*buf, mdev_state->s[index].dlab); > > +#endif > > + handle_bar_write(index, mdev_state, offset, buf, count); > > + } else { > > + handle_bar_read(index, mdev_state, offset, buf, count); > > + dump_buffer(buf, count); > > + > > +#if defined(DEBUG_REGS) > > + pr_info("%s: BAR%d RD @0x%llx %s val:0x%02x dlab:%d\n", > > + __func__, index, offset, rd_reg[offset], > > + (u8)*buf, mdev_state->s[index].dlab); > > +#endif > > + } > > + break; > > + > > + default: > > + ret = -1; > > + goto accessfailed; > > + } > > + > > + ret = count; > > + > > + > > +accessfailed: > > + mutex_unlock(&mdev_state->ops_lock); > > + > > + return ret; > > +} > > + > ...snip... > > > +ssize_t mtty_read(struct mdev_device *mdev, char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + return mdev_access(mdev, buf, count, *ppos, false); > > +} > > + > > +ssize_t mtty_write(struct mdev_device *mdev, const char __user *buf, > > + size_t count, loff_t *ppos) > > +{ > > + return mdev_access(mdev, (char *)buf, count, *ppos, true); > > +} > > + > ...snip... >
next prev parent reply other threads:[~2016-10-18 17:17 UTC|newest] Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-17 21:22 [PATCH v9 00/12] Add Mediated device support Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 01/12] vfio: Mediated device Core driver Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-18 23:16 ` Alex Williamson 2016-10-18 23:16 ` [Qemu-devel] " Alex Williamson 2016-10-19 19:16 ` Kirti Wankhede 2016-10-19 19:16 ` [Qemu-devel] " Kirti Wankhede 2016-10-19 22:20 ` Alex Williamson 2016-10-19 22:20 ` [Qemu-devel] " Alex Williamson 2016-10-19 22:20 ` Alex Williamson 2016-10-20 7:23 ` Jike Song 2016-10-20 7:23 ` [Qemu-devel] " Jike Song 2016-10-20 17:12 ` Alex Williamson 2016-10-20 17:12 ` [Qemu-devel] " Alex Williamson 2016-10-21 2:41 ` Jike Song 2016-10-21 2:41 ` [Qemu-devel] " Jike Song 2016-10-27 5:56 ` Jike Song 2016-10-27 5:56 ` [Qemu-devel] " Jike Song 2016-10-26 6:52 ` Tian, Kevin 2016-10-26 6:52 ` [Qemu-devel] " Tian, Kevin 2016-10-26 14:58 ` Kirti Wankhede 2016-10-26 14:58 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 02/12] vfio: VFIO based driver for Mediated devices Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-26 6:57 ` Tian, Kevin 2016-10-26 6:57 ` [Qemu-devel] " Tian, Kevin 2016-10-26 15:01 ` Kirti Wankhede 2016-10-26 15:01 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 03/12] vfio: Rearrange functions to get vfio_group from dev Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-19 17:26 ` Alex Williamson 2016-10-19 17:26 ` [Qemu-devel] " Alex Williamson 2016-10-17 21:22 ` [PATCH v9 04/12] vfio iommu: Add support for mediated devices Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` Kirti Wankhede 2016-10-19 21:02 ` Alex Williamson 2016-10-19 21:02 ` [Qemu-devel] " Alex Williamson 2016-10-20 20:17 ` Kirti Wankhede 2016-10-20 20:17 ` [Qemu-devel] " Kirti Wankhede 2016-10-24 2:32 ` Alex Williamson 2016-10-24 2:32 ` [Qemu-devel] " Alex Williamson 2016-10-26 7:19 ` Tian, Kevin 2016-10-26 7:19 ` [Qemu-devel] " Tian, Kevin 2016-10-26 15:06 ` Kirti Wankhede 2016-10-26 15:06 ` [Qemu-devel] " Kirti Wankhede 2016-10-26 7:53 ` Tian, Kevin 2016-10-26 7:53 ` [Qemu-devel] " Tian, Kevin 2016-10-26 15:16 ` Alex Williamson 2016-10-26 15:16 ` [Qemu-devel] " Alex Williamson 2016-10-26 7:54 ` Tian, Kevin 2016-10-26 7:54 ` [Qemu-devel] " Tian, Kevin 2016-10-26 15:19 ` Alex Williamson 2016-10-26 15:19 ` [Qemu-devel] " Alex Williamson 2016-10-21 7:49 ` Jike Song 2016-10-21 7:49 ` [Qemu-devel] " Jike Song 2016-10-21 14:36 ` Alex Williamson 2016-10-21 14:36 ` [Qemu-devel] " Alex Williamson 2016-10-24 10:35 ` Kirti Wankhede 2016-10-24 10:35 ` [Qemu-devel] " Kirti Wankhede 2016-10-27 7:20 ` Alexey Kardashevskiy 2016-10-27 12:31 ` Kirti Wankhede 2016-10-27 12:31 ` Kirti Wankhede 2016-10-27 12:31 ` Kirti Wankhede 2016-10-27 14:30 ` [Qemu-devel] " Alex Williamson 2016-10-27 14:30 ` Alex Williamson 2016-10-27 14:30 ` Alex Williamson 2016-10-27 15:59 ` [Qemu-devel] " Kirti Wankhede 2016-10-27 15:59 ` Kirti Wankhede 2016-10-28 2:18 ` Alexey Kardashevskiy 2016-11-01 14:01 ` Kirti Wankhede 2016-11-01 14:01 ` Kirti Wankhede 2016-11-02 1:24 ` Alexey Kardashevskiy 2016-11-02 3:29 ` Kirti Wankhede 2016-11-02 3:29 ` Kirti Wankhede 2016-11-02 4:09 ` Alexey Kardashevskiy 2016-11-02 12:21 ` Jike Song 2016-11-02 12:21 ` Jike Song 2016-11-02 12:41 ` [Qemu-devel] " Kirti Wankhede 2016-11-02 12:41 ` Kirti Wankhede 2016-11-02 13:00 ` Jike Song 2016-11-02 13:18 ` Kirti Wankhede 2016-11-02 13:18 ` Kirti Wankhede 2016-11-02 13:35 ` Jike Song 2016-11-02 13:35 ` Jike Song 2016-11-03 4:29 ` [Qemu-devel] " Alexey Kardashevskiy 2016-11-03 4:29 ` Alexey Kardashevskiy 2016-10-17 21:22 ` [PATCH v9 05/12] vfio: Introduce common function to add capabilities Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-20 19:24 ` Alex Williamson 2016-10-20 19:24 ` [Qemu-devel] " Alex Williamson 2016-10-24 21:27 ` Kirti Wankhede 2016-10-24 21:27 ` [Qemu-devel] " Kirti Wankhede 2016-10-24 21:39 ` Alex Williamson 2016-10-24 21:39 ` [Qemu-devel] " Alex Williamson 2016-10-17 21:22 ` [PATCH v9 06/12] vfio_pci: Update vfio_pci to use vfio_info_add_capability() Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-20 19:24 ` Alex Williamson 2016-10-20 19:24 ` [Qemu-devel] " Alex Williamson 2016-10-24 21:22 ` Kirti Wankhede 2016-10-24 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-24 21:37 ` Alex Williamson 2016-10-24 21:37 ` [Qemu-devel] " Alex Williamson 2016-10-17 21:22 ` [PATCH v9 07/12] vfio: Introduce vfio_set_irqs_validate_and_prepare() Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 08/12] vfio_pci: Updated to use vfio_set_irqs_validate_and_prepare() Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 09/12] vfio_platform: " Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-17 21:22 ` [PATCH v9 10/12] vfio: Add function to get device_api string from vfio_device_info.flags Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-20 19:34 ` Alex Williamson 2016-10-20 19:34 ` [Qemu-devel] " Alex Williamson 2016-10-20 20:29 ` Kirti Wankhede 2016-10-20 20:29 ` [Qemu-devel] " Kirti Wankhede 2016-10-20 21:05 ` Alex Williamson 2016-10-20 21:05 ` [Qemu-devel] " Alex Williamson 2016-10-20 21:14 ` Kirti Wankhede 2016-10-20 21:14 ` [Qemu-devel] " Kirti Wankhede 2016-10-20 21:22 ` Alex Williamson 2016-10-20 21:22 ` [Qemu-devel] " Alex Williamson 2016-10-21 3:00 ` Kirti Wankhede 2016-10-21 3:00 ` [Qemu-devel] " Kirti Wankhede 2016-10-21 3:20 ` Alex Williamson 2016-10-21 3:20 ` [Qemu-devel] " Alex Williamson 2016-10-17 21:22 ` [PATCH v9 11/12] docs: Add Documentation for Mediated devices Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-25 16:17 ` Alex Williamson 2016-10-25 16:17 ` [Qemu-devel] " Alex Williamson 2016-10-17 21:22 ` [PATCH v9 12/12] docs: Sample driver to demonstrate how to use Mediated device framework Kirti Wankhede 2016-10-17 21:22 ` [Qemu-devel] " Kirti Wankhede 2016-10-18 2:54 ` Dong Jia Shi 2016-10-18 17:17 ` Alex Williamson [this message] 2016-10-18 17:17 ` Alex Williamson 2016-10-19 19:19 ` Kirti Wankhede 2016-10-19 19:19 ` [Qemu-devel] " Kirti Wankhede 2016-10-18 2:54 ` Dong Jia Shi 2016-10-17 21:41 ` [PATCH v9 00/12] Add Mediated device support Alex Williamson 2016-10-17 21:41 ` [Qemu-devel] " Alex Williamson 2016-10-24 7:07 ` Jike Song 2016-10-24 7:07 ` [Qemu-devel] " Jike Song 2016-12-05 17:44 ` Gerd Hoffmann 2016-12-05 17:44 ` [Qemu-devel] " Gerd Hoffmann 2016-12-05 17:44 ` Gerd Hoffmann 2016-12-06 2:24 ` Jike Song 2016-12-06 2:24 ` [Qemu-devel] " Jike Song 2016-12-07 14:40 ` Gerd Hoffmann 2016-12-07 14:40 ` [Qemu-devel] " Gerd Hoffmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161018111719.141fcdaa@t450s.home \ --to=alex.williamson@redhat.com \ --cc=bjsdjshi@linux.vnet.ibm.com \ --cc=cjia@nvidia.com \ --cc=jike.song@intel.com \ --cc=kevin.tian@intel.com \ --cc=kraxel@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=kwankhede@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.