From: Jean-Francois Moine <moinejf@free.fr> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Chen-Yu Tsai <wens@csie.org>, linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Date: Thu, 20 Oct 2016 17:38:48 +0200 [thread overview] Message-ID: <20161020173848.be9cf97854f8933b3ce90d55@free.fr> (raw) In-Reply-To: <42e249454ccf6b14e9ec266cb8d42a24f6d71d7b.1476971126.git-series.maxime.ripard@free-electrons.com> On Thu, 20 Oct 2016 15:49:06 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The allwinner,pull property set to NO_PULL was really considered our > default (and wasn't even changing the default value in the code). > > Remove these properties to make it obvious that we do not set anything in > such a case. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > arch/arm/boot/dts/ntc-gr8-evb.dts | 4 +- > arch/arm/boot/dts/ntc-gr8.dtsi | 14 +----- > arch/arm/boot/dts/sun4i-a10-a1000.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 4 +- > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-hackberry.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-inet1.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-mk802.dts | 3 +- > arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino2.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 3 +- > arch/arm/boot/dts/sun4i-a10.dtsi | 24 +-------- > arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts | 1 +- > arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-mk802.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s.dtsi | 7 +-- > arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 1 +- > arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 3 +- > arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 2 +- > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 1 +- > arch/arm/boot/dts/sun5i-a13.dtsi | 3 +- > arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +- > arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun5i.dtsi | 7 +-- > arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-colombus.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-i7.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-m9.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 2 +- > arch/arm/boot/dts/sun6i-a31.dtsi | 13 +---- > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-bananapro.dts | 5 +-- > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 +-- > arch/arm/boot/dts/sun7i-a20-hummingbird.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-m3.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-mk808c.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-orangepi.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 1 +- > arch/arm/boot/dts/sun7i-a20.dtsi | 37 +------------ > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 10 +--- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 1 +- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-olinuxino.dts | 3 +- > arch/arm/boot/dts/sun8i-a33.dtsi | 1 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 3 +- > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 2 +- > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 4 +- > arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 1 +- > arch/arm/boot/dts/sun8i-h3.dtsi | 12 +---- > arch/arm/boot/dts/sun8i-r16-parrot.dts | 3 +- > arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 1 +- > arch/arm/boot/dts/sun9i-a80-optimus.dts | 4 +- > arch/arm/boot/dts/sun9i-a80.dtsi | 6 +-- > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 4 +- > 85 files changed, 0 insertions(+), 302 deletions(-) [snip] Is it really usefull to change all these files while in a previous patch you were writing: > The generic pin configuration and multiplexing should be preferred now, > even though we still support the old one. ? -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
WARNING: multiple messages have this Message-ID (diff)
From: moinejf@free.fr (Jean-Francois Moine) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Date: Thu, 20 Oct 2016 17:38:48 +0200 [thread overview] Message-ID: <20161020173848.be9cf97854f8933b3ce90d55@free.fr> (raw) In-Reply-To: <42e249454ccf6b14e9ec266cb8d42a24f6d71d7b.1476971126.git-series.maxime.ripard@free-electrons.com> On Thu, 20 Oct 2016 15:49:06 +0200 Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > The allwinner,pull property set to NO_PULL was really considered our > default (and wasn't even changing the default value in the code). > > Remove these properties to make it obvious that we do not set anything in > such a case. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Chen-Yu Tsai <wens@csie.org> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > --- > arch/arm/boot/dts/ntc-gr8-evb.dts | 4 +- > arch/arm/boot/dts/ntc-gr8.dtsi | 14 +----- > arch/arm/boot/dts/sun4i-a10-a1000.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-cubieboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts | 4 +- > arch/arm/boot/dts/sun4i-a10-gemei-g9.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-hackberry.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-inet1.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-marsboard.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-mk802.dts | 3 +- > arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino.dts | 2 +- > arch/arm/boot/dts/sun4i-a10-pcduino2.dts | 1 +- > arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts | 3 +- > arch/arm/boot/dts/sun4i-a10.dtsi | 24 +-------- > arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts | 1 +- > arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-mk802.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-r7-tv-dongle.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s-wobo-i5.dts | 2 +- > arch/arm/boot/dts/sun5i-a10s.dtsi | 7 +-- > arch/arm/boot/dts/sun5i-a13-hsg-h702.dts | 1 +- > arch/arm/boot/dts/sun5i-a13-olinuxino-micro.dts | 3 +- > arch/arm/boot/dts/sun5i-a13-olinuxino.dts | 2 +- > arch/arm/boot/dts/sun5i-a13-utoo-p66.dts | 1 +- > arch/arm/boot/dts/sun5i-a13.dtsi | 3 +- > arch/arm/boot/dts/sun5i-r8-chip.dts | 2 +- > arch/arm/boot/dts/sun5i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun5i.dtsi | 7 +-- > arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-colombus.dts | 1 +- > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-i7.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-m9.dts | 2 +- > arch/arm/boot/dts/sun6i-a31-mele-a1000g-quad.dts | 2 +- > arch/arm/boot/dts/sun6i-a31.dtsi | 13 +---- > arch/arm/boot/dts/sun6i-a31s-primo81.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sina31s.dts | 1 +- > arch/arm/boot/dts/sun6i-a31s-sinovoip-bpi-m2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-bananapro.dts | 5 +-- > arch/arm/boot/dts/sun7i-a20-cubieboard2.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 +-- > arch/arm/boot/dts/sun7i-a20-hummingbird.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-i12-tvbox.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-lamobo-r1.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-m3.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-mk808c.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olimex-som-evb.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 1 +- > arch/arm/boot/dts/sun7i-a20-orangepi-mini.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-orangepi.dts | 4 +- > arch/arm/boot/dts/sun7i-a20-pcduino3-nano.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 2 +- > arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 3 +- > arch/arm/boot/dts/sun7i-a20-wits-pro-a20-dkt.dts | 1 +- > arch/arm/boot/dts/sun7i-a20.dtsi | 37 +------------ > arch/arm/boot/dts/sun8i-a23-a33.dtsi | 10 +--- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 1 +- > arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 1 +- > arch/arm/boot/dts/sun8i-a33-olinuxino.dts | 3 +- > arch/arm/boot/dts/sun8i-a33.dtsi | 1 +- > arch/arm/boot/dts/sun8i-a83t.dtsi | 3 +- > arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-nanopi-neo.dts | 2 +- > arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 4 +- > arch/arm/boot/dts/sun8i-h3-orangepi-lite.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 3 +- > arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 1 +- > arch/arm/boot/dts/sun8i-h3.dtsi | 12 +---- > arch/arm/boot/dts/sun8i-r16-parrot.dts | 3 +- > arch/arm/boot/dts/sun8i-reference-design-tablet.dtsi | 2 +- > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 1 +- > arch/arm/boot/dts/sun9i-a80-optimus.dts | 4 +- > arch/arm/boot/dts/sun9i-a80.dtsi | 6 +-- > arch/arm/boot/dts/sunxi-common-regulators.dtsi | 4 +- > 85 files changed, 0 insertions(+), 302 deletions(-) [snip] Is it really usefull to change all these files while in a previous patch you were writing: > The generic pin configuration and multiplexing should be preferred now, > even though we still support the old one. ? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2016-10-20 15:38 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-20 13:49 [PATCH v3 0/6] pinctrl: sunxi: Generic bindings rework Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-20 13:49 ` [PATCH v3 1/6] pinctrl: sunxi: Deal with configless pins Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-29 9:08 ` Linus Walleij 2016-10-29 9:08 ` Linus Walleij 2016-10-29 9:08 ` Linus Walleij 2016-10-20 13:49 ` [PATCH v3 2/6] pinctrl: sunxi: Support generic binding Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-24 0:02 ` Linus Walleij 2016-10-24 0:02 ` Linus Walleij 2016-10-24 0:02 ` Linus Walleij 2016-10-20 13:49 ` [PATCH v3 3/6] dt-bindings: pinctrl: Deprecate sunxi pinctrl bindings Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-24 0:03 ` Linus Walleij 2016-10-24 0:03 ` Linus Walleij 2016-10-24 0:03 ` Linus Walleij [not found] ` <CACRpkdb7zs7Nhs3i1o=WUt787vJCuePre3Tj3wLu++qwpO0atQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-24 19:49 ` Maxime Ripard 2016-10-24 19:49 ` Maxime Ripard 2016-10-24 19:49 ` Maxime Ripard 2016-10-25 12:07 ` Linus Walleij 2016-10-25 12:07 ` Linus Walleij 2016-10-25 12:07 ` Linus Walleij 2016-10-25 13:41 ` Maxime Ripard 2016-10-25 13:41 ` Maxime Ripard 2016-10-25 13:41 ` Maxime Ripard 2016-10-20 13:49 ` [PATCH v3 4/6] ARM: sunxi: Remove useless allwinner,drive property Maxime Ripard 2016-10-20 13:49 ` [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Maxime Ripard 2016-10-20 13:49 ` Maxime Ripard 2016-10-20 15:38 ` Jean-Francois Moine [this message] 2016-10-20 15:38 ` Jean-Francois Moine [not found] ` <20161020173848.be9cf97854f8933b3ce90d55-GANU6spQydw@public.gmane.org> 2016-10-21 10:40 ` Maxime Ripard 2016-10-21 10:40 ` [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner, pull property Maxime Ripard 2016-10-21 10:40 ` [PATCH v3 5/6] ARM: sunxi: Remove useless allwinner,pull property Maxime Ripard 2016-10-20 13:49 ` [PATCH v3 6/6] ARM: sunxi: Convert pinctrl nodes to generic bindings Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161020173848.be9cf97854f8933b3ce90d55@free.fr \ --to=moinejf@free.fr \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maxime.ripard@free-electrons.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.