All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Tiffany Lin <tiffany.lin@mediatek.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	<daniel.thompson@linaro.org>, Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Pawel Osciak <posciak@chromium.org>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <PoChun.Lin@mediatek.com>
Subject: Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date: Fri, 21 Oct 2016 11:08:09 -0200	[thread overview]
Message-ID: <20161021110809.269fd70d@vento.lan> (raw)
In-Reply-To: <20161021110104.5733240e@vento.lan>

Em Fri, 21 Oct 2016 11:01:04 -0200
Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu:

> Em Fri, 2 Sep 2016 20:19:54 +0800
> Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
> 
> > Add v4l2 layer decoder driver for MT8173
> > 
> > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>  
> 
> > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc)
> > +{
> > +	int ret = 0;
> > +
> > +	switch (fourcc) {
> > +	case V4L2_PIX_FMT_H264:
> > +	case V4L2_PIX_FMT_VP8:
> > +	default:
> > +		return -EINVAL;
> > +	}  
> 
> Did you ever test this driver? The above code will *always* return
> -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail!
> 
> I suspect that what you wanted to do, instead, is:
> 
> 	switch (fourcc) {
> 	case V4L2_PIX_FMT_H264:
> 	case V4L2_PIX_FMT_VP8:
> 		break;
> 	default:
> 		return -EINVAL;

Yeah, a latter patch in this series added a break there.

Thanks,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@s-opensource.com>
To: Tiffany Lin <tiffany.lin@mediatek.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>,
	daniel.thompson@linaro.org, Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Pawel Osciak <posciak@chromium.org>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Yingjoe Chen <yingjoe.chen@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
	PoChun.Lin@mediatek.com
Subject: Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date: Fri, 21 Oct 2016 11:08:09 -0200	[thread overview]
Message-ID: <20161021110809.269fd70d@vento.lan> (raw)
In-Reply-To: <20161021110104.5733240e@vento.lan>

Em Fri, 21 Oct 2016 11:01:04 -0200
Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu:

> Em Fri, 2 Sep 2016 20:19:54 +0800
> Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
> 
> > Add v4l2 layer decoder driver for MT8173
> > 
> > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>  
> 
> > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc)
> > +{
> > +	int ret = 0;
> > +
> > +	switch (fourcc) {
> > +	case V4L2_PIX_FMT_H264:
> > +	case V4L2_PIX_FMT_VP8:
> > +	default:
> > +		return -EINVAL;
> > +	}  
> 
> Did you ever test this driver? The above code will *always* return
> -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail!
> 
> I suspect that what you wanted to do, instead, is:
> 
> 	switch (fourcc) {
> 	case V4L2_PIX_FMT_H264:
> 	case V4L2_PIX_FMT_VP8:
> 		break;
> 	default:
> 		return -EINVAL;

Yeah, a latter patch in this series added a break there.

Thanks,
Mauro

WARNING: multiple messages have this Message-ID (diff)
From: mchehab@s-opensource.com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date: Fri, 21 Oct 2016 11:08:09 -0200	[thread overview]
Message-ID: <20161021110809.269fd70d@vento.lan> (raw)
In-Reply-To: <20161021110104.5733240e@vento.lan>

Em Fri, 21 Oct 2016 11:01:04 -0200
Mauro Carvalho Chehab <mchehab@osg.samsung.com> escreveu:

> Em Fri, 2 Sep 2016 20:19:54 +0800
> Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
> 
> > Add v4l2 layer decoder driver for MT8173
> > 
> > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>  
> 
> > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc)
> > +{
> > +	int ret = 0;
> > +
> > +	switch (fourcc) {
> > +	case V4L2_PIX_FMT_H264:
> > +	case V4L2_PIX_FMT_VP8:
> > +	default:
> > +		return -EINVAL;
> > +	}  
> 
> Did you ever test this driver? The above code will *always* return
> -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail!
> 
> I suspect that what you wanted to do, instead, is:
> 
> 	switch (fourcc) {
> 	case V4L2_PIX_FMT_H264:
> 	case V4L2_PIX_FMT_VP8:
> 		break;
> 	default:
> 		return -EINVAL;

Yeah, a latter patch in this series added a break there.

Thanks,
Mauro

  reply	other threads:[~2016-10-21 13:08 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 12:19 [PATCH v5 0/9] Add MT8173 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 1/9] VPU: mediatek: Add decode support Tiffany Lin
2016-09-02 12:19   ` Tiffany Lin
2016-09-02 12:19   ` Tiffany Lin
2016-09-02 12:19   ` [PATCH v5 2/9] dt-bindings: Add a binding for Mediatek Video Decoder Tiffany Lin
2016-09-02 12:19     ` Tiffany Lin
2016-09-02 12:19     ` Tiffany Lin
2016-09-02 12:19     ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Tiffany Lin
2016-09-02 12:19       ` Tiffany Lin
2016-09-02 12:19       ` Tiffany Lin
2016-09-02 12:19       ` [PATCH v5 4/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Drive Tiffany Lin
2016-09-02 12:19         ` Tiffany Lin
2016-09-02 12:19         ` Tiffany Lin
2016-09-02 12:19         ` [PATCH v5 5/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver Tiffany Lin
2016-09-02 12:19           ` Tiffany Lin
2016-09-02 12:19           ` Tiffany Lin
2016-09-02 12:19           ` [PATCH v5 6/9] videodev2.h: add V4L2_PIX_FMT_VP9 format Tiffany Lin
2016-09-02 12:19             ` Tiffany Lin
2016-09-02 12:19             ` Tiffany Lin
2016-09-02 12:19             ` [PATCH v5 7/9] v4l2-ioctl: add VP9 format description Tiffany Lin
2016-09-02 12:19               ` Tiffany Lin
2016-09-02 12:19               ` Tiffany Lin
2016-09-02 12:19               ` [PATCH v5 8/9] Add documentation for V4L2_PIX_FMT_VP9 Tiffany Lin
2016-09-02 12:19                 ` Tiffany Lin
2016-09-02 12:19                 ` Tiffany Lin
2016-09-02 12:20                 ` [PATCH v5 9/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver Tiffany Lin
2016-09-02 12:20                   ` Tiffany Lin
2016-09-02 12:20                   ` Tiffany Lin
2016-10-21 13:01       ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 " Mauro Carvalho Chehab
2016-10-21 13:01         ` Mauro Carvalho Chehab
2016-10-21 13:01         ` Mauro Carvalho Chehab
2016-10-21 13:08         ` Mauro Carvalho Chehab [this message]
2016-10-21 13:08           ` Mauro Carvalho Chehab
2016-10-21 13:08           ` Mauro Carvalho Chehab
2016-10-24  3:22         ` Tiffany Lin
2016-10-24  3:22           ` Tiffany Lin
2016-10-24  3:22           ` Tiffany Lin
2016-10-24  9:05           ` Mauro Carvalho Chehab
2016-10-24  9:05             ` Mauro Carvalho Chehab
2016-10-24  9:05             ` Mauro Carvalho Chehab
2016-10-24 10:49             ` Tiffany Lin
2016-10-24 10:49               ` Tiffany Lin
2016-10-24 10:49               ` Tiffany Lin
2016-09-05  9:33 ` [PATCH v5 0/9] Add MT8173 " Hans Verkuil
2016-09-05  9:33   ` Hans Verkuil
2016-09-05  9:33   ` Hans Verkuil
2016-09-05  9:50   ` Tiffany Lin
2016-09-05  9:50     ` Tiffany Lin
2016-09-05  9:50     ` Tiffany Lin
2016-09-05  9:53     ` Hans Verkuil
2016-09-05  9:53       ` Hans Verkuil
2016-09-05 10:09       ` Hans Verkuil
2016-09-05 10:09         ` Hans Verkuil
2016-09-05 10:52         ` Tiffany Lin
2016-09-05 10:52           ` Tiffany Lin
2016-09-05 10:52           ` Tiffany Lin
2016-09-05 11:26           ` Hans Verkuil
2016-09-05 11:26             ` Hans Verkuil
2016-09-05 11:30             ` Tiffany Lin
2016-09-05 11:30               ` Tiffany Lin
2016-09-05 11:30               ` Tiffany Lin
2016-09-05 11:32               ` Hans Verkuil
2016-09-05 11:32                 ` Hans Verkuil
2016-09-05 11:32                 ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161021110809.269fd70d@vento.lan \
    --to=mchehab@s-opensource.com \
    --cc=PoChun.Lin@mediatek.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=eddie.huang@mediatek.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=posciak@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=tiffany.lin@mediatek.com \
    --cc=yingjoe.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.