From: Hans Verkuil <hverkuil@xs4all.nl>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
daniel.thompson@linaro.org, Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Pawel Osciak <posciak@chromium.org>
Cc: Eddie Huang <eddie.huang@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org,
PoChun.Lin@mediatek.com
Subject: Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver
Date: Mon, 5 Sep 2016 11:33:57 +0200 [thread overview]
Message-ID: <616d95a4-e6f3-5c42-d435-eb73795bd82c@xs4all.nl> (raw)
In-Reply-To: <1472818800-22558-1-git-send-email-tiffany.lin@mediatek.com>
On 09/02/2016 02:19 PM, Tiffany Lin wrote:
> ==============
> Introduction
> ==============
>
> The purpose of this series is to add the driver for video codec hw embedded in the Mediatek's MT8173 SoCs.
> Mediatek Video Codec is able to handle video decoding and encoding of in a range of formats.
>
> This patch series rely on MTK VPU driver that have been merged in v4.8-rc1.
> Mediatek Video Decoder driver rely on VPU driver to load, communicate with VPU.
>
> Internally the driver uses videobuf2 framework, and MTK IOMMU and MTK SMI both have been merged in v4.6-rc1.
>
> [1]https://chromium-review.googlesource.com/#/c/245241/
This patch series fails to apply to the media_tree master (patch 3/9). Can you rebase and repost?
I'm ready to make a pull request for this, so I hope you can fix this soon.
Thanks!
Hans
>
> ==================
> Device interface
> ==================
>
> In principle the driver bases on v4l2 memory-to-memory framework:
> it provides a single video node and each opened file handle gets its own private context with separate buffer queues. Each context consist of 2 buffer
> queues: OUTPUT (for source buffers, i.e. bitstream) and CAPTURE (for destination buffers, i.e. decoded video frames).
> OUTPUT and CAPTURE buffer could be MMAP or DMABUF memory type.
>
> Change in v5:
> 1. Merge wucheng's V4L2_PIX_FMT_VP9 series to this series
> V4L: add VP9 format documentation
> v4l2-ioctl: add VP9 format description.
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> 2. Remove V4L2_PIX_FMT_MT21C to another series
>
> Change in v4:
> 1.Change V4L2_PIX_FMT_MT21 to v4l2_PIX_FMT_MT21C
> 2.Fix g/s_selection implementation
> 3.Refine code according to review comments and pass V4l2-compliance test
>
> -/bin/sh: v4l2: not found
> # v4l2-compliance -d /dev/video0
> v4l2-compliance SHA : fc45cdc502065bc1dfb4ef9ceb9a822bb9877bce
>
> Driver Info:
> Driver name : mtk-vcodec-dec
> Card type : platform:mt8173
> Bus info : platform:mt8173
> Driver version: 4.8.0
> Capabilities : 0x84204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Device Capabilities
> Device Caps : 0x04204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
>
> Compliance test for device /dev/video0 (not using libv4l2):
>
> Required ioctls:
> test VIDIOC_QUERYCAP: OK
>
> Allow for multiple opens:
> test second video open: OK
> test VIDIOC_QUERYCAP: OK
> test VIDIOC_G/S_PRIORITY: OK
> test for unlimited opens: OK
>
> Debug ioctls:
> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> test VIDIOC_LOG_STATUS: OK (Not Supported)
>
> Input ioctls:
> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> test VIDIOC_ENUMAUDIO: OK (Not Supported)
> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDIO: OK (Not Supported)
> Inputs: 0 Audio Inputs: 0 Tuners: 0
>
> Output ioctls:
> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> Outputs: 0 Audio Outputs: 0 Modulators: 0
>
> Input/Output configuration ioctls:
> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> test VIDIOC_G/S_EDID: OK (Not Supported)
>
> Control ioctls:
> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> test VIDIOC_QUERYCTRL: OK
> test VIDIOC_G/S_CTRL: OK
> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> Standard Controls: 2 Private Controls: 0
>
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> test VIDIOC_G/S_PARM: OK (Not Supported)
> test VIDIOC_G_FBUF: OK (Not Supported)
> test VIDIOC_G_FMT: OK
> test VIDIOC_TRY_FMT: OK
> test VIDIOC_S_FMT: OK
> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> test Cropping: OK (Not Supported)
> test Composing: OK
> test Scaling: OK
>
> Codec ioctls:
> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>
> Buffer ioctls:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> test VIDIOC_EXPBUF: OK
>
> Test input 0:
>
> Total: 43, Succeeded: 43, Failed: 0, Warnings: 0
>
>
> Change in v3:
> 1. Refine vdec hw clock setting
> 2. Refine vp9 codec driver
> 3. Refine v4l2 codec driver
>
> Change in v2:
> 1. Add documentation for V4L2_PIX_FMT_MT21 2. Remove DRM_FORMAT_MT21 2. Refine code according to review comments
>
>
> Andrew-CT Chen (1):
> VPU: mediatek: Add decode support
>
> Tiffany Lin (10):
> dt-bindings: Add a binding for Mediatek Video Decoder
> vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
> vcodec: mediatek: Add Mediatek H264 Video Decoder Drive
> vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver
> Add documentation for V4L2_PIX_FMT_VP9.
> vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver
> v4l: add Mediatek compressed video block format
> docs-rst: Add compressed video formats used on MT8173 codec driver
> vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder
> arm64: dts: mediatek: Add Video Decoder for MT8173
>
> Wu-Cheng Li (2):
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> v4l2-ioctl: add VP9 format description.
>
> .../devicetree/bindings/media/mediatek-vcodec.txt | 57 +-
> Documentation/media/uapi/v4l/pixfmt-013.rst | 8 +
> Documentation/media/uapi/v4l/pixfmt-reserved.rst | 6 +
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 +
> drivers/media/platform/mtk-vcodec/Makefile | 15 +-
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1448 ++++++++++++++++++++
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 88 ++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 394 ++++++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 205 +++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 28 +
> drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 62 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_intr.c | 3 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.c | 33 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.h | 5 +
> .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 506 +++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 633 +++++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 +++++++++++++
> drivers/media/platform/mtk-vcodec/vdec_drv_base.h | 56 +
> drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 122 ++
> drivers/media/platform/mtk-vcodec/vdec_drv_if.h | 101 ++
> drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h | 103 ++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.c | 168 +++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.h | 96 ++
> drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 +
> drivers/media/platform/mtk-vpu/mtk_vpu.h | 27 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +
> include/uapi/linux/videodev2.h | 2 +
> 28 files changed, 5173 insertions(+), 26 deletions(-)
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_base.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.h
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org>
To: Tiffany Lin <tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Hans Verkuil
<hans.verkuil-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mauro Carvalho Chehab
<mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Pawel Osciak <posciak-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: Eddie Huang <eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Yingjoe Chen
<yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
PoChun.Lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver
Date: Mon, 5 Sep 2016 11:33:57 +0200 [thread overview]
Message-ID: <616d95a4-e6f3-5c42-d435-eb73795bd82c@xs4all.nl> (raw)
In-Reply-To: <1472818800-22558-1-git-send-email-tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On 09/02/2016 02:19 PM, Tiffany Lin wrote:
> ==============
> Introduction
> ==============
>
> The purpose of this series is to add the driver for video codec hw embedded in the Mediatek's MT8173 SoCs.
> Mediatek Video Codec is able to handle video decoding and encoding of in a range of formats.
>
> This patch series rely on MTK VPU driver that have been merged in v4.8-rc1.
> Mediatek Video Decoder driver rely on VPU driver to load, communicate with VPU.
>
> Internally the driver uses videobuf2 framework, and MTK IOMMU and MTK SMI both have been merged in v4.6-rc1.
>
> [1]https://chromium-review.googlesource.com/#/c/245241/
This patch series fails to apply to the media_tree master (patch 3/9). Can you rebase and repost?
I'm ready to make a pull request for this, so I hope you can fix this soon.
Thanks!
Hans
>
> ==================
> Device interface
> ==================
>
> In principle the driver bases on v4l2 memory-to-memory framework:
> it provides a single video node and each opened file handle gets its own private context with separate buffer queues. Each context consist of 2 buffer
> queues: OUTPUT (for source buffers, i.e. bitstream) and CAPTURE (for destination buffers, i.e. decoded video frames).
> OUTPUT and CAPTURE buffer could be MMAP or DMABUF memory type.
>
> Change in v5:
> 1. Merge wucheng's V4L2_PIX_FMT_VP9 series to this series
> V4L: add VP9 format documentation
> v4l2-ioctl: add VP9 format description.
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> 2. Remove V4L2_PIX_FMT_MT21C to another series
>
> Change in v4:
> 1.Change V4L2_PIX_FMT_MT21 to v4l2_PIX_FMT_MT21C
> 2.Fix g/s_selection implementation
> 3.Refine code according to review comments and pass V4l2-compliance test
>
> -/bin/sh: v4l2: not found
> # v4l2-compliance -d /dev/video0
> v4l2-compliance SHA : fc45cdc502065bc1dfb4ef9ceb9a822bb9877bce
>
> Driver Info:
> Driver name : mtk-vcodec-dec
> Card type : platform:mt8173
> Bus info : platform:mt8173
> Driver version: 4.8.0
> Capabilities : 0x84204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Device Capabilities
> Device Caps : 0x04204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
>
> Compliance test for device /dev/video0 (not using libv4l2):
>
> Required ioctls:
> test VIDIOC_QUERYCAP: OK
>
> Allow for multiple opens:
> test second video open: OK
> test VIDIOC_QUERYCAP: OK
> test VIDIOC_G/S_PRIORITY: OK
> test for unlimited opens: OK
>
> Debug ioctls:
> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> test VIDIOC_LOG_STATUS: OK (Not Supported)
>
> Input ioctls:
> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> test VIDIOC_ENUMAUDIO: OK (Not Supported)
> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDIO: OK (Not Supported)
> Inputs: 0 Audio Inputs: 0 Tuners: 0
>
> Output ioctls:
> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> Outputs: 0 Audio Outputs: 0 Modulators: 0
>
> Input/Output configuration ioctls:
> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> test VIDIOC_G/S_EDID: OK (Not Supported)
>
> Control ioctls:
> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> test VIDIOC_QUERYCTRL: OK
> test VIDIOC_G/S_CTRL: OK
> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> Standard Controls: 2 Private Controls: 0
>
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> test VIDIOC_G/S_PARM: OK (Not Supported)
> test VIDIOC_G_FBUF: OK (Not Supported)
> test VIDIOC_G_FMT: OK
> test VIDIOC_TRY_FMT: OK
> test VIDIOC_S_FMT: OK
> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> test Cropping: OK (Not Supported)
> test Composing: OK
> test Scaling: OK
>
> Codec ioctls:
> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>
> Buffer ioctls:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> test VIDIOC_EXPBUF: OK
>
> Test input 0:
>
> Total: 43, Succeeded: 43, Failed: 0, Warnings: 0
>
>
> Change in v3:
> 1. Refine vdec hw clock setting
> 2. Refine vp9 codec driver
> 3. Refine v4l2 codec driver
>
> Change in v2:
> 1. Add documentation for V4L2_PIX_FMT_MT21 2. Remove DRM_FORMAT_MT21 2. Refine code according to review comments
>
>
> Andrew-CT Chen (1):
> VPU: mediatek: Add decode support
>
> Tiffany Lin (10):
> dt-bindings: Add a binding for Mediatek Video Decoder
> vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
> vcodec: mediatek: Add Mediatek H264 Video Decoder Drive
> vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver
> Add documentation for V4L2_PIX_FMT_VP9.
> vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver
> v4l: add Mediatek compressed video block format
> docs-rst: Add compressed video formats used on MT8173 codec driver
> vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder
> arm64: dts: mediatek: Add Video Decoder for MT8173
>
> Wu-Cheng Li (2):
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> v4l2-ioctl: add VP9 format description.
>
> .../devicetree/bindings/media/mediatek-vcodec.txt | 57 +-
> Documentation/media/uapi/v4l/pixfmt-013.rst | 8 +
> Documentation/media/uapi/v4l/pixfmt-reserved.rst | 6 +
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 +
> drivers/media/platform/mtk-vcodec/Makefile | 15 +-
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1448 ++++++++++++++++++++
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 88 ++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 394 ++++++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 205 +++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 28 +
> drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 62 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_intr.c | 3 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.c | 33 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.h | 5 +
> .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 506 +++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 633 +++++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 +++++++++++++
> drivers/media/platform/mtk-vcodec/vdec_drv_base.h | 56 +
> drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 122 ++
> drivers/media/platform/mtk-vcodec/vdec_drv_if.h | 101 ++
> drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h | 103 ++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.c | 168 +++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.h | 96 ++
> drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 +
> drivers/media/platform/mtk-vpu/mtk_vpu.h | 27 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +
> include/uapi/linux/videodev2.h | 2 +
> 28 files changed, 5173 insertions(+), 26 deletions(-)
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_base.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.h
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/9] Add MT8173 Video Decoder Driver
Date: Mon, 5 Sep 2016 11:33:57 +0200 [thread overview]
Message-ID: <616d95a4-e6f3-5c42-d435-eb73795bd82c@xs4all.nl> (raw)
In-Reply-To: <1472818800-22558-1-git-send-email-tiffany.lin@mediatek.com>
On 09/02/2016 02:19 PM, Tiffany Lin wrote:
> ==============
> Introduction
> ==============
>
> The purpose of this series is to add the driver for video codec hw embedded in the Mediatek's MT8173 SoCs.
> Mediatek Video Codec is able to handle video decoding and encoding of in a range of formats.
>
> This patch series rely on MTK VPU driver that have been merged in v4.8-rc1.
> Mediatek Video Decoder driver rely on VPU driver to load, communicate with VPU.
>
> Internally the driver uses videobuf2 framework, and MTK IOMMU and MTK SMI both have been merged in v4.6-rc1.
>
> [1]https://chromium-review.googlesource.com/#/c/245241/
This patch series fails to apply to the media_tree master (patch 3/9). Can you rebase and repost?
I'm ready to make a pull request for this, so I hope you can fix this soon.
Thanks!
Hans
>
> ==================
> Device interface
> ==================
>
> In principle the driver bases on v4l2 memory-to-memory framework:
> it provides a single video node and each opened file handle gets its own private context with separate buffer queues. Each context consist of 2 buffer
> queues: OUTPUT (for source buffers, i.e. bitstream) and CAPTURE (for destination buffers, i.e. decoded video frames).
> OUTPUT and CAPTURE buffer could be MMAP or DMABUF memory type.
>
> Change in v5:
> 1. Merge wucheng's V4L2_PIX_FMT_VP9 series to this series
> V4L: add VP9 format documentation
> v4l2-ioctl: add VP9 format description.
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> 2. Remove V4L2_PIX_FMT_MT21C to another series
>
> Change in v4:
> 1.Change V4L2_PIX_FMT_MT21 to v4l2_PIX_FMT_MT21C
> 2.Fix g/s_selection implementation
> 3.Refine code according to review comments and pass V4l2-compliance test
>
> -/bin/sh: v4l2: not found
> # v4l2-compliance -d /dev/video0
> v4l2-compliance SHA : fc45cdc502065bc1dfb4ef9ceb9a822bb9877bce
>
> Driver Info:
> Driver name : mtk-vcodec-dec
> Card type : platform:mt8173
> Bus info : platform:mt8173
> Driver version: 4.8.0
> Capabilities : 0x84204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
> Device Capabilities
> Device Caps : 0x04204000
> Video Memory-to-Memory Multiplanar
> Streaming
> Extended Pix Format
>
> Compliance test for device /dev/video0 (not using libv4l2):
>
> Required ioctls:
> test VIDIOC_QUERYCAP: OK
>
> Allow for multiple opens:
> test second video open: OK
> test VIDIOC_QUERYCAP: OK
> test VIDIOC_G/S_PRIORITY: OK
> test for unlimited opens: OK
>
> Debug ioctls:
> test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
> test VIDIOC_LOG_STATUS: OK (Not Supported)
>
> Input ioctls:
> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
> test VIDIOC_ENUMAUDIO: OK (Not Supported)
> test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDIO: OK (Not Supported)
> Inputs: 0 Audio Inputs: 0 Tuners: 0
>
> Output ioctls:
> test VIDIOC_G/S_MODULATOR: OK (Not Supported)
> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
> test VIDIOC_ENUMAUDOUT: OK (Not Supported)
> test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
> test VIDIOC_G/S_AUDOUT: OK (Not Supported)
> Outputs: 0 Audio Outputs: 0 Modulators: 0
>
> Input/Output configuration ioctls:
> test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
> test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
> test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
> test VIDIOC_G/S_EDID: OK (Not Supported)
>
> Control ioctls:
> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
> test VIDIOC_QUERYCTRL: OK
> test VIDIOC_G/S_CTRL: OK
> test VIDIOC_G/S/TRY_EXT_CTRLS: OK
> test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
> test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
> Standard Controls: 2 Private Controls: 0
>
> Format ioctls:
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
> test VIDIOC_G/S_PARM: OK (Not Supported)
> test VIDIOC_G_FBUF: OK (Not Supported)
> test VIDIOC_G_FMT: OK
> test VIDIOC_TRY_FMT: OK
> test VIDIOC_S_FMT: OK
> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
> test Cropping: OK (Not Supported)
> test Composing: OK
> test Scaling: OK
>
> Codec ioctls:
> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
> test VIDIOC_G_ENC_INDEX: OK (Not Supported)
> test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>
> Buffer ioctls:
> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> test VIDIOC_EXPBUF: OK
>
> Test input 0:
>
> Total: 43, Succeeded: 43, Failed: 0, Warnings: 0
>
>
> Change in v3:
> 1. Refine vdec hw clock setting
> 2. Refine vp9 codec driver
> 3. Refine v4l2 codec driver
>
> Change in v2:
> 1. Add documentation for V4L2_PIX_FMT_MT21 2. Remove DRM_FORMAT_MT21 2. Refine code according to review comments
>
>
> Andrew-CT Chen (1):
> VPU: mediatek: Add decode support
>
> Tiffany Lin (10):
> dt-bindings: Add a binding for Mediatek Video Decoder
> vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
> vcodec: mediatek: Add Mediatek H264 Video Decoder Drive
> vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver
> Add documentation for V4L2_PIX_FMT_VP9.
> vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver
> v4l: add Mediatek compressed video block format
> docs-rst: Add compressed video formats used on MT8173 codec driver
> vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder
> arm64: dts: mediatek: Add Video Decoder for MT8173
>
> Wu-Cheng Li (2):
> videodev2.h: add V4L2_PIX_FMT_VP9 format.
> v4l2-ioctl: add VP9 format description.
>
> .../devicetree/bindings/media/mediatek-vcodec.txt | 57 +-
> Documentation/media/uapi/v4l/pixfmt-013.rst | 8 +
> Documentation/media/uapi/v4l/pixfmt-reserved.rst | 6 +
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 +
> drivers/media/platform/mtk-vcodec/Makefile | 15 +-
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1448 ++++++++++++++++++++
> drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 88 ++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 394 ++++++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 205 +++
> .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h | 28 +
> drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h | 62 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 8 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_intr.c | 3 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.c | 33 +-
> .../media/platform/mtk-vcodec/mtk_vcodec_util.h | 5 +
> .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 506 +++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 633 +++++++++
> .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 +++++++++++++
> drivers/media/platform/mtk-vcodec/vdec_drv_base.h | 56 +
> drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 122 ++
> drivers/media/platform/mtk-vcodec/vdec_drv_if.h | 101 ++
> drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h | 103 ++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.c | 168 +++
> drivers/media/platform/mtk-vcodec/vdec_vpu_if.h | 96 ++
> drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 +
> drivers/media/platform/mtk-vpu/mtk_vpu.h | 27 +
> drivers/media/v4l2-core/v4l2-ioctl.c | 2 +
> include/uapi/linux/videodev2.h | 2 +
> 28 files changed, 5173 insertions(+), 26 deletions(-)
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c
> create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec/vdec_vp9_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_base.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_drv_if.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_ipi_msg.h
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.c
> create mode 100644 drivers/media/platform/mtk-vcodec/vdec_vpu_if.h
>
next prev parent reply other threads:[~2016-09-05 9:34 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 12:19 [PATCH v5 0/9] Add MT8173 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 1/9] VPU: mediatek: Add decode support Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 2/9] dt-bindings: Add a binding for Mediatek Video Decoder Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 4/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Drive Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 5/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 6/9] videodev2.h: add V4L2_PIX_FMT_VP9 format Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 7/9] v4l2-ioctl: add VP9 format description Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 8/9] Add documentation for V4L2_PIX_FMT_VP9 Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:19 ` Tiffany Lin
2016-09-02 12:20 ` [PATCH v5 9/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver Tiffany Lin
2016-09-02 12:20 ` Tiffany Lin
2016-09-02 12:20 ` Tiffany Lin
2016-10-21 13:01 ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 " Mauro Carvalho Chehab
2016-10-21 13:01 ` Mauro Carvalho Chehab
2016-10-21 13:01 ` Mauro Carvalho Chehab
2016-10-21 13:08 ` Mauro Carvalho Chehab
2016-10-21 13:08 ` Mauro Carvalho Chehab
2016-10-21 13:08 ` Mauro Carvalho Chehab
2016-10-24 3:22 ` Tiffany Lin
2016-10-24 3:22 ` Tiffany Lin
2016-10-24 3:22 ` Tiffany Lin
2016-10-24 9:05 ` Mauro Carvalho Chehab
2016-10-24 9:05 ` Mauro Carvalho Chehab
2016-10-24 9:05 ` Mauro Carvalho Chehab
2016-10-24 10:49 ` Tiffany Lin
2016-10-24 10:49 ` Tiffany Lin
2016-10-24 10:49 ` Tiffany Lin
2016-09-05 9:33 ` Hans Verkuil [this message]
2016-09-05 9:33 ` [PATCH v5 0/9] Add MT8173 " Hans Verkuil
2016-09-05 9:33 ` Hans Verkuil
2016-09-05 9:50 ` Tiffany Lin
2016-09-05 9:50 ` Tiffany Lin
2016-09-05 9:50 ` Tiffany Lin
2016-09-05 9:53 ` Hans Verkuil
2016-09-05 9:53 ` Hans Verkuil
2016-09-05 10:09 ` Hans Verkuil
2016-09-05 10:09 ` Hans Verkuil
2016-09-05 10:52 ` Tiffany Lin
2016-09-05 10:52 ` Tiffany Lin
2016-09-05 10:52 ` Tiffany Lin
2016-09-05 11:26 ` Hans Verkuil
2016-09-05 11:26 ` Hans Verkuil
2016-09-05 11:30 ` Tiffany Lin
2016-09-05 11:30 ` Tiffany Lin
2016-09-05 11:30 ` Tiffany Lin
2016-09-05 11:32 ` Hans Verkuil
2016-09-05 11:32 ` Hans Verkuil
2016-09-05 11:32 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=616d95a4-e6f3-5c42-d435-eb73795bd82c@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=PoChun.Lin@mediatek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=posciak@chromium.org \
--cc=robh+dt@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.