* [PATCH 1/5] fs: exofs: print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
@ 2016-10-26 12:56 ` Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 2/5] block: DAC960: " Uwe Kleine-König
` (5 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-26 12:56 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Boaz Harrosh, Benny Halevy
Cc: kernel, Andy Whitcroft, Joe Perches, osd-dev
It makes the message hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
fs/exofs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/exofs/dir.c b/fs/exofs/dir.c
index 79101651fe9e..42f9a0a0c4ca 100644
--- a/fs/exofs/dir.c
+++ b/fs/exofs/dir.c
@@ -137,7 +137,7 @@ static bool exofs_check_page(struct page *page)
bad_entry:
EXOFS_ERR(
"ERROR [exofs_check_page]: bad entry in directory(0x%lx): %s - "
- "offset=%lu, inode=0x%llu, rec_len=%d, name_len=%d\n",
+ "offset=%lu, inode=0x%llx, rec_len=%d, name_len=%d\n",
dir->i_ino, error, (page->index<<PAGE_SHIFT)+offs,
_LLU(le64_to_cpu(p->inode_no)),
rec_len, p->name_len);
--
2.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/5] block: DAC960: print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 1/5] fs: exofs: " Uwe Kleine-König
@ 2016-10-26 12:56 ` Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 3/5] ipack: " Uwe Kleine-König
` (4 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-26 12:56 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: kernel, Andy Whitcroft, Joe Perches
It makes the message hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hello,
get_maintainer.pl didn't give me a maintainer, so I assumed it's akpm :-)
Uwe
drivers/block/DAC960.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
index 811e11c82f32..0809cda93cc0 100644
--- a/drivers/block/DAC960.c
+++ b/drivers/block/DAC960.c
@@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
case DAC960_PD_Controller:
if (!request_region(Controller->IO_Address, 0x80,
Controller->FullModelName)) {
- DAC960_Error("IO port 0x%d busy for Controller at\n",
+ DAC960_Error("IO port 0x%lx busy for Controller at\n",
Controller, Controller->IO_Address);
goto Failure;
}
@@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
case DAC960_P_Controller:
if (!request_region(Controller->IO_Address, 0x80,
Controller->FullModelName)){
- DAC960_Error("IO port 0x%d busy for Controller at\n",
+ DAC960_Error("IO port 0x%lx busy for Controller at\n",
Controller, Controller->IO_Address);
goto Failure;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/5] ipack: print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 1/5] fs: exofs: " Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 2/5] block: DAC960: " Uwe Kleine-König
@ 2016-10-26 12:56 ` Uwe Kleine-König
2016-10-26 12:56 ` [PATCH 4/5] misc: sgi-gru: " Uwe Kleine-König
` (3 subsequent siblings)
6 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-26 12:56 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Samuel Iglesias Gonsalvez,
Jens Taprogge, Greg Kroah-Hartman
Cc: kernel, Andy Whitcroft, Joe Perches, industrypack-devel
It makes the result hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/ipack/ipack.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index c0e7b624ce54..12102448fddd 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -178,7 +178,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
idev->id_vendor, idev->id_device);
}
-ipack_device_attr(id_format, "0x%hhu\n");
+ipack_device_attr(id_format, "0x%hhx\n");
static DEVICE_ATTR_RO(id);
static DEVICE_ATTR_RO(id_device);
--
2.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
` (2 preceding siblings ...)
2016-10-26 12:56 ` [PATCH 3/5] ipack: " Uwe Kleine-König
@ 2016-10-26 12:56 ` Uwe Kleine-König
2016-10-26 13:47 ` Dimitri Sivanich
2016-10-26 12:56 ` [PATCH 5/5] cris/arch-v32: cryptocop: " Uwe Kleine-König
` (2 subsequent siblings)
6 siblings, 1 reply; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-26 12:56 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Dimitri Sivanich
Cc: kernel, Andy Whitcroft, Joe Perches
It makes the result hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/misc/sgi-gru/grumain.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index 1525870f460a..cd9c1210a845 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,8 +283,9 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
spin_lock(&gru->gs_asid_lock);
BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
asids->mt_ctxbitmap ^= ctxbitmap;
- gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
- gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
+ gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n",
+ gru->gs_gid, gts, gms, (unsigned)gts->ts_ctxnum,
+ gms->ms_asidmap[0]);
spin_unlock(&gru->gs_asid_lock);
spin_unlock(&gms->ms_asid_lock);
}
--
2.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix
2016-10-26 12:56 ` [PATCH 4/5] misc: sgi-gru: " Uwe Kleine-König
@ 2016-10-26 13:47 ` Dimitri Sivanich
2016-10-27 6:05 ` Uwe Kleine-König
0 siblings, 1 reply; 11+ messages in thread
From: Dimitri Sivanich @ 2016-10-26 13:47 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Andrew Morton, linux-kernel, kernel, Andy Whitcroft, Joe Perches
On Wed, Oct 26, 2016 at 02:56:57PM +0200, Uwe Kleine-König wrote:
> It makes the result hard to interpret correctly if a base 10 number is
> prefixed by 0x. So change to a hex number.
>
Would like to have this be a decimal number.
Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
---
drivers/misc/sgi-gru/grumain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c
index 1525870..33741ad 100644
--- a/drivers/misc/sgi-gru/grumain.c
+++ b/drivers/misc/sgi-gru/grumain.c
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,
spin_lock(&gru->gs_asid_lock);
BUG_ON((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap);
asids->mt_ctxbitmap ^= ctxbitmap;
- gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n",
+ gru_dbg(grudev, "gid %d, gts %p, gms %p, ctxnum %d, asidmap 0x%lx\n",
gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0]);
spin_unlock(&gru->gs_asid_lock);
spin_unlock(&gms->ms_asid_lock);
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 4/5] misc: sgi-gru: print a hex number after a 0x prefix
2016-10-26 13:47 ` Dimitri Sivanich
@ 2016-10-27 6:05 ` Uwe Kleine-König
0 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-27 6:05 UTC (permalink / raw)
To: Dimitri Sivanich
Cc: Andy Whitcroft, Joe Perches, Andrew Morton, linux-kernel, kernel
On Wed, Oct 26, 2016 at 08:47:46AM -0500, Dimitri Sivanich wrote:
> On Wed, Oct 26, 2016 at 02:56:57PM +0200, Uwe Kleine-König wrote:
> > It makes the result hard to interpret correctly if a base 10 number is
> > prefixed by 0x. So change to a hex number.
> >
>
> Would like to have this be a decimal number.
Then I assume you will care yourself for this patch and akpm will drop
it from his queue.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 5/5] cris/arch-v32: cryptocop: print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
` (3 preceding siblings ...)
2016-10-26 12:56 ` [PATCH 4/5] misc: sgi-gru: " Uwe Kleine-König
@ 2016-10-26 12:56 ` Uwe Kleine-König
2016-10-26 19:50 ` [PATCH 0/5] " Andrew Morton
2016-10-26 23:35 ` Joe Perches
6 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-26 12:56 UTC (permalink / raw)
To: Andrew Morton, linux-kernel, Mikael Starvik, Jesper Nilsson
Cc: kernel, Andy Whitcroft, Joe Perches, linux-cris-kernel
It makes the result hard to interpret correctly if a base 10 number is
prefixed by 0x. So change to a hex number.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/cris/arch-v32/drivers/cryptocop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c
index b5698c876fcc..91e3be5853e5 100644
--- a/arch/cris/arch-v32/drivers/cryptocop.c
+++ b/arch/cris/arch-v32/drivers/cryptocop.c
@@ -3151,7 +3151,7 @@ static void print_dma_descriptors(struct cryptocop_int_operation *iop)
printk("print_dma_descriptors start\n");
printk("iop:\n");
- printk("\tsid: 0x%lld\n", iop->sid);
+ printk("\tsid: 0x%llx\n", iop->sid);
printk("\tcdesc_out: 0x%p\n", iop->cdesc_out);
printk("\tcdesc_in: 0x%p\n", iop->cdesc_in);
--
2.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 0/5] print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
` (4 preceding siblings ...)
2016-10-26 12:56 ` [PATCH 5/5] cris/arch-v32: cryptocop: " Uwe Kleine-König
@ 2016-10-26 19:50 ` Andrew Morton
2016-10-26 23:35 ` Joe Perches
6 siblings, 0 replies; 11+ messages in thread
From: Andrew Morton @ 2016-10-26 19:50 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-kernel, kernel, Andy Whitcroft, Joe Perches, Boaz Harrosh,
Benny Halevy, Samuel Iglesias Gonsalvez, Jens Taprogge,
Greg Kroah-Hartman, Dimitri Sivanich, Mikael Starvik,
Jesper Nilsson
On Wed, 26 Oct 2016 14:56:53 +0200 Uwe Kleine-K__nig <u.kleine-koenig@pengutronix.de> wrote:
> Hello,
>
> these were found by
>
> git grep -i 0x%[lh]*[du]
>
> Maybe it would make sense to catch this type of unconvenience in
> checkpatch?
>
> Best regards
> Uwe
>
> Uwe Kleine-K__nig (5):
> fs: exofs: print a hex number after a 0x prefix
> block: DAC960: print a hex number after a 0x prefix
> ipack: print a hex number after a 0x prefix
> misc: sgi-gru: print a hex number after a 0x prefix
> cris/arch-v32: cryptocop: print a hex number after a 0x prefix
um, lol, yup, thanks. I'll slam all five into 4.9-rcX.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/5] print a hex number after a 0x prefix
2016-10-26 12:56 [PATCH 0/5] print a hex number after a 0x prefix Uwe Kleine-König
` (5 preceding siblings ...)
2016-10-26 19:50 ` [PATCH 0/5] " Andrew Morton
@ 2016-10-26 23:35 ` Joe Perches
2016-10-27 6:51 ` Uwe Kleine-König
6 siblings, 1 reply; 11+ messages in thread
From: Joe Perches @ 2016-10-26 23:35 UTC (permalink / raw)
To: Uwe Kleine-König, Andrew Morton, linux-kernel; +Cc: kernel, Andy Whitcroft
On Wed, 2016-10-26 at 14:56 +0200, Uwe Kleine-König wrote:
> Hello,
>
> these were found by
>
> git grep -i 0x%[lh]*[du]
>
> Maybe it would make sense to catch this type of unconvenience in
> checkpatch?
Already there.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/5] print a hex number after a 0x prefix
2016-10-26 23:35 ` Joe Perches
@ 2016-10-27 6:51 ` Uwe Kleine-König
0 siblings, 0 replies; 11+ messages in thread
From: Uwe Kleine-König @ 2016-10-27 6:51 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, linux-kernel, kernel, Andy Whitcroft
On Wed, Oct 26, 2016 at 04:35:22PM -0700, Joe Perches wrote:
> On Wed, 2016-10-26 at 14:56 +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > these were found by
> >
> > git grep -i 0x%[lh]*[du]
> >
> > Maybe it would make sense to catch this type of unconvenience in
> > checkpatch?
>
> Already there.
Oh, you're right. It's there since over a year. Strange that noone fixed
this before then.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 11+ messages in thread