All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Ed Blake <ed.blake@imgtec.com>,
	gregkh@linuxfoundation.org, jslaby@suse.com,
	wangkefeng.wang@huawei.com, noamc@ezchip.com, annie.wang@amd.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	james.hartley@imgtec.com
Subject: Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode
Date: Fri, 28 Oct 2016 11:20:40 +0300	[thread overview]
Message-ID: <20161028082040.GA31275@kuha.fi.intel.com> (raw)
In-Reply-To: <1477587370.5295.37.camel@linux.intel.com>

Hi Andy,

On Thu, Oct 27, 2016 at 07:56:10PM +0300, Andy Shevchenko wrote:
> On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote:
> > Add a set_ldisc function to enable/disable IrDA SIR mode according to
> > the new line discipline.
> 
> Thanks for the patch.
> 
> Consider that not all implementations based on 8250_dw support IRDA
> feature. I suppose you need to read capability register bits 6 and 7,
> set flag and then based on the value accept or reject IRDA mode.
> 
> P.S. Use -n when prepare patches to link them if you consider them
> dependent.

These are numbered? Or do you mean that please prefer sending
series of patches as threads?

        % git send-email --thread...

Or something like that? I guess coverletter would be nice too.


Thanks,

-- 
heikki

  parent reply	other threads:[~2016-10-28  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 16:38 [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode Ed Blake
2016-10-27 16:38 ` Ed Blake
2016-10-27 16:56 ` Andy Shevchenko
2016-10-27 17:33   ` Ed Blake
2016-10-27 17:33     ` Ed Blake
2016-10-28  8:20   ` Heikki Krogerus [this message]
2016-10-28 10:45     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028082040.GA31275@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=annie.wang@amd.com \
    --cc=ed.blake@imgtec.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.hartley@imgtec.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noamc@ezchip.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.