All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Blake <ed.blake@imgtec.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <gregkh@linuxfoundation.org>, <jslaby@suse.com>,
	<wangkefeng.wang@huawei.com>, <heikki.krogerus@linux.intel.com>,
	<noamc@ezchip.com>, <annie.wang@amd.com>,
	<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<james.hartley@imgtec.com>
Subject: Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode
Date: Thu, 27 Oct 2016 18:33:45 +0100	[thread overview]
Message-ID: <58123A79.3080905@imgtec.com> (raw)
In-Reply-To: <1477587370.5295.37.camel@linux.intel.com>

On 10/27/16 17:56, Andy Shevchenko wrote:
> On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote:
>> Add a set_ldisc function to enable/disable IrDA SIR mode according to
>> the new line discipline.
> Thanks for the patch.
>
> Consider that not all implementations based on 8250_dw support IRDA
> feature. I suppose you need to read capability register bits 6 and 7,
> set flag and then based on the value accept or reject IRDA mode.

Thanks for the review, I'll add this for the second version.

Ed.

>
> P.S. Use -n when prepare patches to link them if you consider them
> dependent.
>
>> Signed-off-by: Ed Blake <ed.blake@imgtec.com>
>> ---
>>   drivers/tty/serial/8250/8250_dw.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/tty/serial/8250/8250_dw.c
>> b/drivers/tty/serial/8250/8250_dw.c
>> index 459d726..7dd5369 100644
>> --- a/drivers/tty/serial/8250/8250_dw.c
>> +++ b/drivers/tty/serial/8250/8250_dw.c
>> @@ -53,6 +53,8 @@
>>   /* Helper for fifo size calculation */
>>   #define DW_UART_CPR_FIFO_SIZE(a)	(((a >> 16) & 0xff) * 16)
>>   
>> +/* DesignWare specific register fields */
>> +#define DW_UART_MCR_SIRE		BIT(6)
>>   
>>   struct dw8250_data {
>>   	u8			usr_reg;
>> @@ -254,6 +256,20 @@ static void dw8250_set_termios(struct uart_port
>> *p, struct ktermios *termios,
>>   	serial8250_do_set_termios(p, termios, old);
>>   }
>>   
>> +static void dw8250_set_ldisc(struct uart_port *p, struct ktermios
>> *termios)
>> +{
>> +	unsigned int mcr = p->serial_in(p, UART_MCR);
>> +
>> +	if (termios->c_line == N_IRDA)
>> +		mcr |= DW_UART_MCR_SIRE;
>> +	else
>> +		mcr &= ~DW_UART_MCR_SIRE;
>> +
>> +	p->serial_out(p, UART_MCR, mcr);
>> +
>> +	serial8250_do_set_ldisc(p, termios);
>> +}
>> +
>>   /*
>>    * dw8250_fallback_dma_filter will prevent the UART from getting just
>> any free
>>    * channel on platforms that have DMA engines, but don't have any
>> channels
>> @@ -392,6 +408,7 @@ static int dw8250_probe(struct platform_device
>> *pdev)
>>   	p->iotype	= UPIO_MEM;
>>   	p->serial_in	= dw8250_serial_in;
>>   	p->serial_out	= dw8250_serial_out;
>> +	p->set_ldisc	= dw8250_set_ldisc;
>>   
>>   	p->membase = devm_ioremap(dev, regs->start,
>> resource_size(regs));
>>   	if (!p->membase)

WARNING: multiple messages have this Message-ID (diff)
From: Ed Blake <ed.blake@imgtec.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
	wangkefeng.wang@huawei.com, heikki.krogerus@linux.intel.com,
	noamc@ezchip.com, annie.wang@amd.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	james.hartley@imgtec.com
Subject: Re: [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode
Date: Thu, 27 Oct 2016 18:33:45 +0100	[thread overview]
Message-ID: <58123A79.3080905@imgtec.com> (raw)
In-Reply-To: <1477587370.5295.37.camel@linux.intel.com>

On 10/27/16 17:56, Andy Shevchenko wrote:
> On Thu, 2016-10-27 at 17:38 +0100, Ed Blake wrote:
>> Add a set_ldisc function to enable/disable IrDA SIR mode according to
>> the new line discipline.
> Thanks for the patch.
>
> Consider that not all implementations based on 8250_dw support IRDA
> feature. I suppose you need to read capability register bits 6 and 7,
> set flag and then based on the value accept or reject IRDA mode.

Thanks for the review, I'll add this for the second version.

Ed.

>
> P.S. Use -n when prepare patches to link them if you consider them
> dependent.
>
>> Signed-off-by: Ed Blake <ed.blake@imgtec.com>
>> ---
>>   drivers/tty/serial/8250/8250_dw.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/tty/serial/8250/8250_dw.c
>> b/drivers/tty/serial/8250/8250_dw.c
>> index 459d726..7dd5369 100644
>> --- a/drivers/tty/serial/8250/8250_dw.c
>> +++ b/drivers/tty/serial/8250/8250_dw.c
>> @@ -53,6 +53,8 @@
>>   /* Helper for fifo size calculation */
>>   #define DW_UART_CPR_FIFO_SIZE(a)	(((a >> 16) & 0xff) * 16)
>>   
>> +/* DesignWare specific register fields */
>> +#define DW_UART_MCR_SIRE		BIT(6)
>>   
>>   struct dw8250_data {
>>   	u8			usr_reg;
>> @@ -254,6 +256,20 @@ static void dw8250_set_termios(struct uart_port
>> *p, struct ktermios *termios,
>>   	serial8250_do_set_termios(p, termios, old);
>>   }
>>   
>> +static void dw8250_set_ldisc(struct uart_port *p, struct ktermios
>> *termios)
>> +{
>> +	unsigned int mcr = p->serial_in(p, UART_MCR);
>> +
>> +	if (termios->c_line == N_IRDA)
>> +		mcr |= DW_UART_MCR_SIRE;
>> +	else
>> +		mcr &= ~DW_UART_MCR_SIRE;
>> +
>> +	p->serial_out(p, UART_MCR, mcr);
>> +
>> +	serial8250_do_set_ldisc(p, termios);
>> +}
>> +
>>   /*
>>    * dw8250_fallback_dma_filter will prevent the UART from getting just
>> any free
>>    * channel on platforms that have DMA engines, but don't have any
>> channels
>> @@ -392,6 +408,7 @@ static int dw8250_probe(struct platform_device
>> *pdev)
>>   	p->iotype	= UPIO_MEM;
>>   	p->serial_in	= dw8250_serial_in;
>>   	p->serial_out	= dw8250_serial_out;
>> +	p->set_ldisc	= dw8250_set_ldisc;
>>   
>>   	p->membase = devm_ioremap(dev, regs->start,
>> resource_size(regs));
>>   	if (!p->membase)

  reply	other threads:[~2016-10-27 17:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 16:38 [PATCH 2/2] serial: 8250_dw: Add support for IrDA SIR mode Ed Blake
2016-10-27 16:38 ` Ed Blake
2016-10-27 16:56 ` Andy Shevchenko
2016-10-27 17:33   ` Ed Blake [this message]
2016-10-27 17:33     ` Ed Blake
2016-10-28  8:20   ` Heikki Krogerus
2016-10-28 10:45     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58123A79.3080905@imgtec.com \
    --to=ed.blake@imgtec.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=annie.wang@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=james.hartley@imgtec.com \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=noamc@ezchip.com \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.