From: Christoph Hellwig <firstname.lastname@example.org> To: Michael Callahan <email@example.com> Cc: Christoph Hellwig <firstname.lastname@example.org>, Dave Chinner <email@example.com>, "firstname.lastname@example.org" <email@example.com> Subject: Re: [PATCH 2/3] xfs: don't block the log commit handler for discards Date: Mon, 31 Oct 2016 16:16:36 +0100 [thread overview] Message-ID: <20161031151636.GA14981@lst.de> (raw) In-Reply-To: <D438D4D4.2CD0firstname.lastname@example.org> On Fri, Oct 28, 2016 at 04:16:01PM +0000, Michael Callahan wrote: > Doesn't the block layer already do a reasonable job of merging adjacent > discards? It certainly didn't with my fast NVMe device. But even if it did we have all the information available here, so it's still cheaper to do it in the submitter. One thing we should try is to move it into __blkdev_issue_discard in the future, though. Note that I've also started to look into merging disjoint discard range into a single request for ranged trim/unmap/deallocate and that also seems to work nicely, but it will need some large tree-wide changes.
next prev parent reply other threads:[~2016-10-31 15:16 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-17 20:22 discard improvements Christoph Hellwig 2016-10-17 20:22 ` [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents Christoph Hellwig 2016-10-19 13:48 ` Brian Foster 2016-10-21 12:48 ` Christoph Hellwig 2016-10-21 14:41 ` Brian Foster 2016-11-08 6:15 ` Dave Chinner 2016-11-10 19:17 ` Christoph Hellwig 2016-10-17 20:22 ` [PATCH 2/3] xfs: don't block the log commit handler for discards Christoph Hellwig 2016-10-17 23:29 ` Dave Chinner 2016-10-18 5:05 ` Christoph Hellwig 2016-10-19 10:58 ` Christoph Hellwig 2016-10-28 16:16 ` Michael Callahan 2016-10-31 15:16 ` Christoph Hellwig [this message] 2016-10-17 20:22 ` [PATCH 3/3] xfs: merge discard requests Christoph Hellwig 2016-10-28 10:11 ` discard improvements Avi Kivity 2016-10-31 15:14 ` Christoph Hellwig 2016-11-05 18:18 ` Avi Kivity 2016-11-06 16:36 ` Christoph Hellwig 2016-11-06 23:21 ` Dave Chinner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161031151636.GA14981@lst.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/3] xfs: don'\''t block the log commit handler for discards' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.