* [PATCH] build: Fix build script to use correct cmake cmd @ 2016-10-21 17:27 Dennis Dalessandro [not found] ` <20161021172728.27367.86783.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Dennis Dalessandro @ 2016-10-21 17:27 UTC (permalink / raw) To: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/ Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA The build script does not use the variable it sets up for cmake. Fix it so it does. Signed-off-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- build.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.sh b/build.sh index 9006030..10518d8 100755 --- a/build.sh +++ b/build.sh @@ -23,9 +23,9 @@ fi cd "$BUILDDIR" if [ "x$NINJA" == "x" ]; then - cmake .. + $CMAKE .. make else - cmake -GNinja .. + $CMAKE -GNinja .. $NINJA fi -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 8+ messages in thread
[parent not found: <20161021172728.27367.86783.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161021172728.27367.86783.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org> @ 2016-10-21 18:05 ` Jason Gunthorpe [not found] ` <20161021180523.GA554-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Jason Gunthorpe @ 2016-10-21 18:05 UTC (permalink / raw) To: Dennis Dalessandro; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA On Fri, Oct 21, 2016 at 10:27:28AM -0700, Dennis Dalessandro wrote: > The build script does not use the variable it sets up for cmake. Fix it > so it does. Yep, my bad. I put this with the other minor fixes that came by lately: https://github.com/linux-rdma/rdma-core/pull/25 Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20161021180523.GA554-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161021180523.GA554-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> @ 2016-10-21 19:03 ` Doug Ledford [not found] ` <9745f6c7-8d09-8bed-d04c-78f610330ead-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Doug Ledford @ 2016-10-21 19:03 UTC (permalink / raw) To: Jason Gunthorpe, Dennis Dalessandro; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1.1: Type: text/plain, Size: 964 bytes --] On 10/21/2016 2:05 PM, Jason Gunthorpe wrote: > On Fri, Oct 21, 2016 at 10:27:28AM -0700, Dennis Dalessandro wrote: >> The build script does not use the variable it sets up for cmake. Fix it >> so it does. > > Yep, my bad. I put this with the other minor fixes that came by > lately: > > https://github.com/linux-rdma/rdma-core/pull/25 > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > According to github, this change broke the travis CI build on your pull request when the previous patches all worked. However, travis is down right now, so I suspect this didn't *actually* break it, that the travis CI was down anyway and github logged a failure. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG Key ID: 0E572FDD [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 884 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <9745f6c7-8d09-8bed-d04c-78f610330ead-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <9745f6c7-8d09-8bed-d04c-78f610330ead-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2016-10-21 19:30 ` Jason Gunthorpe [not found] ` <20161021193034.GA616-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Jason Gunthorpe @ 2016-10-21 19:30 UTC (permalink / raw) To: Doug Ledford; +Cc: Dennis Dalessandro, linux-rdma-u79uwXL29TY76Z2rM5mHXA On Fri, Oct 21, 2016 at 03:03:23PM -0400, Doug Ledford wrote: > According to github, this change broke the travis CI build on your pull > request when the previous patches all worked. However, travis is down > right now, so I suspect this didn't *actually* break it, that the travis > CI was down anyway and github logged a failure. Yes, travis does not use build.sh Maybe this is a good time to ask if anyone is interested in the docker stuff I have - eg should I make it pushable? It is easy to use, but you need to have docker installed. There are several other container/chroot/docker based toolkits out there for doing this sort of work, but I haven't studied that area in a while to see if there is something workable. The docker script is able to run almost-travis locally, as well as do clean package builds for all distros. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20161021193034.GA616-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161021193034.GA616-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> @ 2016-10-25 10:12 ` Leon Romanovsky [not found] ` <20161025101200.GP25013-2ukJVAZIZ/Y@public.gmane.org> 0 siblings, 1 reply; 8+ messages in thread From: Leon Romanovsky @ 2016-10-25 10:12 UTC (permalink / raw) To: Jason Gunthorpe Cc: Doug Ledford, Dennis Dalessandro, linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 1365 bytes --] On Fri, Oct 21, 2016 at 01:30:34PM -0600, Jason Gunthorpe wrote: > On Fri, Oct 21, 2016 at 03:03:23PM -0400, Doug Ledford wrote: > > According to github, this change broke the travis CI build on your pull > > request when the previous patches all worked. However, travis is down > > right now, so I suspect this didn't *actually* break it, that the travis > > CI was down anyway and github logged a failure. > > Yes, travis does not use build.sh > > Maybe this is a good time to ask if anyone is interested in the docker > stuff I have - eg should I make it pushable? It is easy to use, but > you need to have docker installed. I would be happy to get it and be more confident in my local tests. > > There are several other container/chroot/docker based toolkits out > there for doing this sort of work, but I haven't studied that area in > a while to see if there is something workable. > > The docker script is able to run almost-travis locally, as well as do > clean package builds for all distros. It looks like it goes beyond rdma-core definition. Do we want to put it separately or anyway integrate into main library? > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20161025101200.GP25013-2ukJVAZIZ/Y@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161025101200.GP25013-2ukJVAZIZ/Y@public.gmane.org> @ 2016-10-28 22:09 ` Jason Gunthorpe 2016-11-07 23:57 ` Jason Gunthorpe 1 sibling, 0 replies; 8+ messages in thread From: Jason Gunthorpe @ 2016-10-28 22:09 UTC (permalink / raw) To: Leon Romanovsky Cc: Doug Ledford, Dennis Dalessandro, linux-rdma-u79uwXL29TY76Z2rM5mHXA On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote: > > Maybe this is a good time to ask if anyone is interested in the docker > > stuff I have - eg should I make it pushable? It is easy to use, but > > you need to have docker installed. > > I would be happy to get it and be more confident in my local tests. Okay, let me look at it some more, I think it could be streamlined a bit. > > The docker script is able to run almost-travis locally, as well as do > > clean package builds for all distros. > > It looks like it goes beyond rdma-core definition. Do we want to put it > separately or anyway integrate into main library? It is a 500 line script, I'd keep it internal. The latest version has learned to use different spec files depend on the distro build too, so there is a bunch of subtle integration. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161025101200.GP25013-2ukJVAZIZ/Y@public.gmane.org> 2016-10-28 22:09 ` Jason Gunthorpe @ 2016-11-07 23:57 ` Jason Gunthorpe [not found] ` <20161107235709.GF7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 1 sibling, 1 reply; 8+ messages in thread From: Jason Gunthorpe @ 2016-11-07 23:57 UTC (permalink / raw) To: Leon Romanovsky Cc: Doug Ledford, Dennis Dalessandro, linux-rdma-u79uwXL29TY76Z2rM5mHXA On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote: > > stuff I have - eg should I make it pushable? It is easy to use, but > > you need to have docker installed. > > I would be happy to get it and be more confident in my local tests. You can test it out with this commit: https://github.com/jgunthorpe/rdma-plumbing/commit/ef24b991c949ad4f50614bf6bf549e1cdf841358 It will need some tidying before it can merged, but let me know if it is useful as-is. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <20161107235709.GF7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>]
* Re: [PATCH] build: Fix build script to use correct cmake cmd [not found] ` <20161107235709.GF7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> @ 2016-11-09 7:27 ` Leon Romanovsky 0 siblings, 0 replies; 8+ messages in thread From: Leon Romanovsky @ 2016-11-09 7:27 UTC (permalink / raw) To: Jason Gunthorpe Cc: Doug Ledford, Dennis Dalessandro, linux-rdma-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 611 bytes --] On Mon, Nov 07, 2016 at 04:57:09PM -0700, Jason Gunthorpe wrote: > On Tue, Oct 25, 2016 at 01:12:00PM +0300, Leon Romanovsky wrote: > > > stuff I have - eg should I make it pushable? It is easy to use, but > > > you need to have docker installed. > > > > I would be happy to get it and be more confident in my local tests. > > You can test it out with this commit: > > https://github.com/jgunthorpe/rdma-plumbing/commit/ef24b991c949ad4f50614bf6bf549e1cdf841358 > > It will need some tidying before it can merged, but let me know if it > is useful as-is. Thanks, I'll do my best to try it next week. > > Jason [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-11-09 7:27 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-10-21 17:27 [PATCH] build: Fix build script to use correct cmake cmd Dennis Dalessandro [not found] ` <20161021172728.27367.86783.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org> 2016-10-21 18:05 ` Jason Gunthorpe [not found] ` <20161021180523.GA554-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2016-10-21 19:03 ` Doug Ledford [not found] ` <9745f6c7-8d09-8bed-d04c-78f610330ead-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-10-21 19:30 ` Jason Gunthorpe [not found] ` <20161021193034.GA616-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2016-10-25 10:12 ` Leon Romanovsky [not found] ` <20161025101200.GP25013-2ukJVAZIZ/Y@public.gmane.org> 2016-10-28 22:09 ` Jason Gunthorpe 2016-11-07 23:57 ` Jason Gunthorpe [not found] ` <20161107235709.GF7002-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2016-11-09 7:27 ` Leon Romanovsky
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.