All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	Max Reitz <mreitz@redhat.com>,
	"open list:X86" <xen-devel@lists.xensource.com>,
	Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges
Date: Tue, 22 Nov 2016 18:00:01 +0100	[thread overview]
Message-ID: <20161122170001.GA19126@aepfle.de> (raw)
In-Reply-To: <1340ce97-092f-877a-d244-f0bf1b50e6e6@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Tue, Nov 22, Eric Blake wrote:

> if (sec_start + sec_count < sec_count ||
>     sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count) {
>     return false;
> }

My point was: how does this handle sec_start=0,sec_count=UINT64_MAX or
sec_start=INT64_MAX,sec_count=INT64_MAX? For me this gets past the if().

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	"open list:X86" <xen-devel@lists.xensource.com>,
	qemu-block@nongnu.org,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	Max Reitz <mreitz@redhat.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges
Date: Tue, 22 Nov 2016 18:00:01 +0100	[thread overview]
Message-ID: <20161122170001.GA19126@aepfle.de> (raw)
In-Reply-To: <1340ce97-092f-877a-d244-f0bf1b50e6e6@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 318 bytes --]

On Tue, Nov 22, Eric Blake wrote:

> if (sec_start + sec_count < sec_count ||
>     sec_start > (INT64_MAX >> BDRV_SECTOR_BITS) - sec_count) {
>     return false;
> }

My point was: how does this handle sec_start=0,sec_count=UINT64_MAX or
sec_start=INT64_MAX,sec_count=INT64_MAX? For me this gets past the if().

Olaf

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-11-22 17:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 10:24 [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Olaf Hering
2016-11-18 10:24 ` Olaf Hering
2016-11-18 10:30 ` [Qemu-devel] " Olaf Hering
2016-11-18 10:30   ` Olaf Hering
2016-11-23 10:49   ` [Qemu-devel] " Olaf Hering
2016-11-23 10:49     ` Olaf Hering
2016-11-23 11:02     ` [Qemu-devel] " Olaf Hering
2016-11-23 11:02       ` Olaf Hering
2016-11-23 18:51       ` [Qemu-devel] " Stefano Stabellini
2016-11-23 18:51         ` Stefano Stabellini
2016-11-18 13:43 ` [Qemu-devel] " Eric Blake
2016-11-18 13:43   ` Eric Blake
2016-11-18 14:19   ` Olaf Hering
2016-11-18 14:19     ` Olaf Hering
2016-11-18 14:35     ` Eric Blake
2016-11-18 14:35       ` Eric Blake
2016-11-18 15:38       ` Kevin Wolf
2016-11-18 15:38         ` Kevin Wolf
2016-11-18 16:39 ` Eric Blake
2016-11-18 16:39   ` Eric Blake
2016-11-18 17:41   ` Olaf Hering
2016-11-18 17:41     ` Olaf Hering
2016-11-18 18:50     ` Eric Blake
2016-11-18 18:50       ` Eric Blake
2016-11-22 16:12       ` Olaf Hering
2016-11-22 16:12         ` Olaf Hering
2016-11-22 16:32         ` Eric Blake
2016-11-22 16:32           ` Eric Blake
2016-11-22 17:00           ` Olaf Hering [this message]
2016-11-22 17:00             ` Olaf Hering
2016-11-22 17:11             ` Eric Blake
2016-11-22 17:11               ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122170001.GA19126@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=anthony.perard@citrix.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.