From: Eric Blake <eblake@redhat.com> To: Olaf Hering <olaf@aepfle.de>, qemu-block@nongnu.org Cc: Kevin Wolf <kwolf@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, "open list:All patches CC here" <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, "open list:X86" <xen-devel@lists.xensource.com>, Anthony Perard <anthony.perard@citrix.com> Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Date: Fri, 18 Nov 2016 07:43:18 -0600 [thread overview] Message-ID: <5aa0cd45-0c73-b940-81e1-235625a428a2@redhat.com> (raw) In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de> [-- Attachment #1: Type: text/plain, Size: 1503 bytes --] On 11/18/2016 04:24 AM, Olaf Hering wrote: > The guest sends discard requests as u64 sector/count pairs, but the > block layer operates internally with s64/s32 pairs. The conversion > leads to IO errors in the guest, the discard request is not processed. Doesn't the block layer already split discard requests into 2^31 byte chunks? > > domU.cfg: > 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2' > domU: > mkfs.ext4 -F /dev/xvda > Discarding device blocks: failed - Input/output error > > Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. > Add input range checking to avoid overflow. > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > --- > hw/block/xen_disk.c | 45 +++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 39 insertions(+), 6 deletions(-) > > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > break; > case BLKIF_OP_DISCARD: > { > - struct blkif_request_discard *discard_req = (void *)&ioreq->req; > - ioreq->aio_inflight++; > - blk_aio_pdiscard(blkdev->blk, That is, blk_aio_pdiscard() calls into bdrv_co_pdiscard() which is supposed to be fragmenting things as needed. Can you trace what is going wrong there? You shouldn't have to reimplement fragementation if the block layer is doing it correctly. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com> To: Olaf Hering <olaf@aepfle.de>, qemu-block@nongnu.org Cc: Kevin Wolf <kwolf@redhat.com>, "open list:X86" <xen-devel@lists.xensource.com>, "open list:All patches CC here" <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perard@citrix.com> Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Date: Fri, 18 Nov 2016 07:43:18 -0600 [thread overview] Message-ID: <5aa0cd45-0c73-b940-81e1-235625a428a2@redhat.com> (raw) In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de> [-- Attachment #1.1: Type: text/plain, Size: 1503 bytes --] On 11/18/2016 04:24 AM, Olaf Hering wrote: > The guest sends discard requests as u64 sector/count pairs, but the > block layer operates internally with s64/s32 pairs. The conversion > leads to IO errors in the guest, the discard request is not processed. Doesn't the block layer already split discard requests into 2^31 byte chunks? > > domU.cfg: > 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2' > domU: > mkfs.ext4 -F /dev/xvda > Discarding device blocks: failed - Input/output error > > Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. > Add input range checking to avoid overflow. > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > --- > hw/block/xen_disk.c | 45 +++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 39 insertions(+), 6 deletions(-) > > @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > break; > case BLKIF_OP_DISCARD: > { > - struct blkif_request_discard *discard_req = (void *)&ioreq->req; > - ioreq->aio_inflight++; > - blk_aio_pdiscard(blkdev->blk, That is, blk_aio_pdiscard() calls into bdrv_co_pdiscard() which is supposed to be fragmenting things as needed. Can you trace what is going wrong there? You shouldn't have to reimplement fragementation if the block layer is doing it correctly. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-11-18 13:43 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-18 10:24 [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Olaf Hering 2016-11-18 10:24 ` Olaf Hering 2016-11-18 10:30 ` [Qemu-devel] " Olaf Hering 2016-11-18 10:30 ` Olaf Hering 2016-11-23 10:49 ` [Qemu-devel] " Olaf Hering 2016-11-23 10:49 ` Olaf Hering 2016-11-23 11:02 ` [Qemu-devel] " Olaf Hering 2016-11-23 11:02 ` Olaf Hering 2016-11-23 18:51 ` [Qemu-devel] " Stefano Stabellini 2016-11-23 18:51 ` Stefano Stabellini 2016-11-18 13:43 ` Eric Blake [this message] 2016-11-18 13:43 ` [Qemu-devel] " Eric Blake 2016-11-18 14:19 ` Olaf Hering 2016-11-18 14:19 ` Olaf Hering 2016-11-18 14:35 ` Eric Blake 2016-11-18 14:35 ` Eric Blake 2016-11-18 15:38 ` Kevin Wolf 2016-11-18 15:38 ` Kevin Wolf 2016-11-18 16:39 ` Eric Blake 2016-11-18 16:39 ` Eric Blake 2016-11-18 17:41 ` Olaf Hering 2016-11-18 17:41 ` Olaf Hering 2016-11-18 18:50 ` Eric Blake 2016-11-18 18:50 ` Eric Blake 2016-11-22 16:12 ` Olaf Hering 2016-11-22 16:12 ` Olaf Hering 2016-11-22 16:32 ` Eric Blake 2016-11-22 16:32 ` Eric Blake 2016-11-22 17:00 ` Olaf Hering 2016-11-22 17:00 ` Olaf Hering 2016-11-22 17:11 ` Eric Blake 2016-11-22 17:11 ` Eric Blake
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5aa0cd45-0c73-b940-81e1-235625a428a2@redhat.com \ --to=eblake@redhat.com \ --cc=anthony.perard@citrix.com \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=olaf@aepfle.de \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=xen-devel@lists.xensource.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.