From: Anthony PERARD <anthony.perard@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: qemu-block@nongnu.org,
Stefano Stabellini <sstabellini@kernel.org>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xensource.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3] xen_disk: split discard input to match internal representation
Date: Wed, 23 Nov 2016 15:50:47 +0000 [thread overview]
Message-ID: <20161123155047.GB1847@perard.uk.xensource.com> (raw)
In-Reply-To: <20161123103912.26699-1-olaf@aepfle.de>
On Wed, Nov 23, 2016 at 10:39:12AM +0000, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2'
> domU:
> mkfs.ext4 -F /dev/xvda
> Discarding device blocks: failed - Input/output error
>
> Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS.
> Add input range checking to avoid overflow.
>
> Fixes f313520 ("xen_disk: add discard support")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-block@nongnu.org,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH v3] xen_disk: split discard input to match internal representation
Date: Wed, 23 Nov 2016 15:50:47 +0000 [thread overview]
Message-ID: <20161123155047.GB1847@perard.uk.xensource.com> (raw)
In-Reply-To: <20161123103912.26699-1-olaf@aepfle.de>
On Wed, Nov 23, 2016 at 10:39:12AM +0000, Olaf Hering wrote:
> The guest sends discard requests as u64 sector/count pairs, but the
> block layer operates internally with s64/s32 pairs. The conversion
> leads to IO errors in the guest, the discard request is not processed.
>
> domU.cfg:
> 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2'
> domU:
> mkfs.ext4 -F /dev/xvda
> Discarding device blocks: failed - Input/output error
>
> Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS.
> Add input range checking to avoid overflow.
>
> Fixes f313520 ("xen_disk: add discard support")
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
next prev parent reply other threads:[~2016-11-23 15:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:39 [Qemu-devel] [PATCH v3] xen_disk: split discard input to match internal representation Olaf Hering
2016-11-23 10:39 ` Olaf Hering
2016-11-23 11:40 ` [Qemu-devel] [PATCH for-2.8 " Eric Blake
2016-11-23 11:40 ` Eric Blake
2016-11-23 12:27 ` Kevin Wolf
2016-11-23 12:27 ` Kevin Wolf
2016-11-23 18:46 ` Stefano Stabellini
2016-11-23 18:46 ` Stefano Stabellini
2016-11-23 20:44 ` Olaf Hering
2016-11-23 20:44 ` Olaf Hering
2016-11-23 22:13 ` Olaf Hering
2016-11-23 22:13 ` Olaf Hering
2016-11-23 15:50 ` Anthony PERARD [this message]
2016-11-23 15:50 ` [PATCH " Anthony PERARD
2016-11-23 18:46 ` [Qemu-devel] " Stefano Stabellini
2016-11-23 18:46 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123155047.GB1847@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=olaf@aepfle.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.