[PATCH v2 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
	Mugunthan V N <mugunthanvnm@ti.com>,
	Richard Cochran <richardcochran@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Wingman Kwok <w-kwok2@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [PATCH  v2 06/13] net: ethernet: ti: cpts: disable cpts when unregistered
Date: Mon, 28 Nov 2016 17:03:30 -0600	[thread overview]
Message-ID: <20161128230337.6731-7-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20161128230337.6731-1-grygorii.strashko@ti.com>

The cpts now is left enabled after unregistration.
Hence, disable it in cpts_unregister().

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/net/ethernet/ti/cpts.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index cb851a7..9ad0998 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -404,6 +404,10 @@ void cpts_unregister(struct cpts *cpts)
 		ptp_clock_unregister(cpts->clock);
 		cancel_delayed_work_sync(&cpts->overflow_work);
 	}
+
+	cpts_write32(cpts, 0, int_enable);
+	cpts_write32(cpts, 0, control);
+
 	if (cpts->refclk)
 		cpts_clk_release(cpts);
 }
-- 
2.10.1

WARNING: multiple messages have this Message-ID (diff)

From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
	Richard Cochran <richardcochran@gmail.com>
Cc: Sekhar Nori <nsekhar@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Murali Karicheri <m-karicheri2@ti.com>,
	Wingman Kwok <w-kwok2@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: [PATCH  v2 06/13] net: ethernet: ti: cpts: disable cpts when unregistered
Date: Mon, 28 Nov 2016 17:03:30 -0600	[thread overview]
Message-ID: <20161128230337.6731-7-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20161128230337.6731-1-grygorii.strashko@ti.com>

The cpts now is left enabled after unregistration.
Hence, disable it in cpts_unregister().

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 drivers/net/ethernet/ti/cpts.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index cb851a7..9ad0998 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -404,6 +404,10 @@ void cpts_unregister(struct cpts *cpts)
 		ptp_clock_unregister(cpts->clock);
 		cancel_delayed_work_sync(&cpts->overflow_work);
 	}
+
+	cpts_write32(cpts, 0, int_enable);
+	cpts_write32(cpts, 0, control);
+
 	if (cpts->refclk)
 		cpts_clk_release(cpts);
 }
-- 
2.10.1

next prev parent reply	other threads:[~2016-11-28 23:04 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 23:03 [PATCH v2 00/13] net: ethernet: ti: cpts: update and fixes Grygorii Strashko
2016-11-28 23:03 ` Grygorii Strashko
2016-11-28 23:03 ` [PATCH v2 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed() Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29  9:38   ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 02/13] net: ethernet: ti: allow cpts to be built separately Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29  9:37   ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03 ` [PATCH v2 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29  9:48   ` Richard Cochran
2016-11-29  9:48     ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 05/13] net: ethernet: ti: cpts: fix registration order Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29  9:48   ` Richard Cochran
2016-11-29  9:48     ` Richard Cochran
2016-11-28 23:03 ` Grygorii Strashko [this message]
2016-11-28 23:03   ` [PATCH v2 06/13] net: ethernet: ti: cpts: disable cpts when unregistered Grygorii Strashko
2016-11-29  9:49   ` Richard Cochran
2016-11-29  9:49     ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29 10:07   ` Richard Cochran
2016-11-29 10:07     ` Richard Cochran
2016-11-29 15:50     ` Grygorii Strashko
2016-11-29 15:50       ` Grygorii Strashko
2016-11-29 15:50       ` Grygorii Strashko
2016-11-30 18:30       ` Grygorii Strashko
2016-11-30 18:30         ` Grygorii Strashko
2016-11-30 18:30         ` Grygorii Strashko
2016-11-28 23:03 ` [PATCH v2 08/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29 10:11   ` Richard Cochran
2016-11-29 15:54     ` Grygorii Strashko
2016-11-29 15:54       ` Grygorii Strashko
2016-11-28 23:03 ` [PATCH v2 09/13] net: ethernet: ti: cpts: clean up event list if event pool is empty Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29 10:13   ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 10/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29 10:14   ` Richard Cochran
2016-11-29 10:14     ` Richard Cochran
2016-11-28 23:03 ` [PATCH v2 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29  9:08   ` Thomas Gleixner
2016-11-29  9:08     ` Thomas Gleixner
2016-11-28 23:03 ` [PATCH v2 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-29 10:34   ` Richard Cochran
2016-11-29 10:34     ` Richard Cochran
2016-11-29 16:22     ` Grygorii Strashko
2016-11-29 16:22       ` Grygorii Strashko
2016-11-28 23:03 ` [PATCH v2 13/13] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko
2016-11-28 23:03   ` Grygorii Strashko
2016-11-30  9:12   ` Richard Cochran

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:cb851a7 dfblob:cb851a7 dfblob:9ad0998 dfblob:9ad0998
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161128230337.6731-7-grygorii.strashko@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=mugunthanvnm@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=w-kwok2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.