From: Grygorii Strashko <grygorii.strashko@ti.com> To: Richard Cochran <richardcochran@gmail.com> Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>, Mugunthan V N <mugunthanvnm@ti.com>, Sekhar Nori <nsekhar@ti.com>, <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>, Murali Karicheri <m-karicheri2@ti.com>, Wingman Kwok <w-kwok2@ti.com> Subject: Re: [PATCH v2 08/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver Date: Tue, 29 Nov 2016 09:54:26 -0600 [thread overview] Message-ID: <b4503f15-6927-9b09-7cb0-ce1c8a8c4f59@ti.com> (raw) In-Reply-To: <20161129101112.GG3110@localhost.localdomain> On 11/29/2016 04:11 AM, Richard Cochran wrote: > On Mon, Nov 28, 2016 at 05:03:32PM -0600, Grygorii Strashko wrote: >> +static int cpts_of_parse(struct cpts *cpts, struct device_node *node) >> +{ >> + int ret = -EINVAL; >> + u32 prop; >> + >> + if (of_property_read_u32(node, "cpts_clock_mult", &prop)) >> + goto of_error; >> + cpts->cc_mult = prop; > > Why not set cc.mult here at the same time? The same reason as in prev patch - cpts->cc_mult is original/initial mult value loaded from DT (or calculated), while cc.mult is dynamic value which can be changed as part of freq adjustment. > >> + >> + if (of_property_read_u32(node, "cpts_clock_shift", &prop)) >> + goto of_error; >> + cpts->cc.shift = prop; >> + >> + return 0; >> + >> +of_error: >> + dev_err(cpts->dev, "CPTS: Missing property in the DT.\n"); >> + return ret; >> +} > -- regards, -grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com> To: Richard Cochran <richardcochran@gmail.com> Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>, Sekhar Nori <nsekhar@ti.com>, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, Murali Karicheri <m-karicheri2@ti.com>, Wingman Kwok <w-kwok2@ti.com> Subject: Re: [PATCH v2 08/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver Date: Tue, 29 Nov 2016 09:54:26 -0600 [thread overview] Message-ID: <b4503f15-6927-9b09-7cb0-ce1c8a8c4f59@ti.com> (raw) In-Reply-To: <20161129101112.GG3110@localhost.localdomain> On 11/29/2016 04:11 AM, Richard Cochran wrote: > On Mon, Nov 28, 2016 at 05:03:32PM -0600, Grygorii Strashko wrote: >> +static int cpts_of_parse(struct cpts *cpts, struct device_node *node) >> +{ >> + int ret = -EINVAL; >> + u32 prop; >> + >> + if (of_property_read_u32(node, "cpts_clock_mult", &prop)) >> + goto of_error; >> + cpts->cc_mult = prop; > > Why not set cc.mult here at the same time? The same reason as in prev patch - cpts->cc_mult is original/initial mult value loaded from DT (or calculated), while cc.mult is dynamic value which can be changed as part of freq adjustment. > >> + >> + if (of_property_read_u32(node, "cpts_clock_shift", &prop)) >> + goto of_error; >> + cpts->cc.shift = prop; >> + >> + return 0; >> + >> +of_error: >> + dev_err(cpts->dev, "CPTS: Missing property in the DT.\n"); >> + return ret; >> +} > -- regards, -grygorii
next prev parent reply other threads:[~2016-11-29 15:54 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-28 23:03 [PATCH v2 00/13] net: ethernet: ti: cpts: update and fixes Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` [PATCH v2 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed() Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:38 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 02/13] net: ethernet: ti: allow cpts to be built separately Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:37 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` [PATCH v2 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:48 ` Richard Cochran 2016-11-29 9:48 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 05/13] net: ethernet: ti: cpts: fix registration order Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:48 ` Richard Cochran 2016-11-29 9:48 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 06/13] net: ethernet: ti: cpts: disable cpts when unregistered Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:49 ` Richard Cochran 2016-11-29 9:49 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 10:07 ` Richard Cochran 2016-11-29 10:07 ` Richard Cochran 2016-11-29 15:50 ` Grygorii Strashko 2016-11-29 15:50 ` Grygorii Strashko 2016-11-29 15:50 ` Grygorii Strashko 2016-11-30 18:30 ` Grygorii Strashko 2016-11-30 18:30 ` Grygorii Strashko 2016-11-30 18:30 ` Grygorii Strashko 2016-11-28 23:03 ` [PATCH v2 08/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 10:11 ` Richard Cochran 2016-11-29 15:54 ` Grygorii Strashko [this message] 2016-11-29 15:54 ` Grygorii Strashko 2016-11-28 23:03 ` [PATCH v2 09/13] net: ethernet: ti: cpts: clean up event list if event pool is empty Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 10:13 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 10/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 10:14 ` Richard Cochran 2016-11-29 10:14 ` Richard Cochran 2016-11-28 23:03 ` [PATCH v2 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 9:08 ` Thomas Gleixner 2016-11-29 9:08 ` Thomas Gleixner 2016-11-28 23:03 ` [PATCH v2 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-29 10:34 ` Richard Cochran 2016-11-29 10:34 ` Richard Cochran 2016-11-29 16:22 ` Grygorii Strashko 2016-11-29 16:22 ` Grygorii Strashko 2016-11-28 23:03 ` [PATCH v2 13/13] net: ethernet: ti: cpts: fix overflow check period Grygorii Strashko 2016-11-28 23:03 ` Grygorii Strashko 2016-11-30 9:12 ` Richard Cochran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b4503f15-6927-9b09-7cb0-ce1c8a8c4f59@ti.com \ --to=grygorii.strashko@ti.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=m-karicheri2@ti.com \ --cc=mugunthanvnm@ti.com \ --cc=netdev@vger.kernel.org \ --cc=nsekhar@ti.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ --cc=w-kwok2@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.