All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Jim Mattson <jmattson@google.com>,
	kvm@vger.kernel.org, GanShun <ganshun@google.com>
Subject: Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
Date: Thu, 8 Dec 2016 16:27:45 +0100	[thread overview]
Message-ID: <20161208152744.GB22892@potion> (raw)
In-Reply-To: <1680a2c8-f132-aaae-9435-025325488aaf@redhat.com>

2016-12-05 15:31+0100, David Hildenbrand:
> Am 30.11.2016 um 19:28 schrieb Jim Mattson:
>> From: GanShun <ganshun@google.com>
>> 
>> When the operand passed to VMPTRLD matches the address of the VMXON
>> region, the VMX instruction error code should be
>> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>> 
>> Signed-off-by: Jim Mattson <jmattson@google.com>
>> ---
>>  arch/x86/kvm/vmx.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 0c4cde8..a1c7a43 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>> 
>>  		if (vmptr == vmx->nested.vmxon_ptr) {
>>  			nested_vmx_failValid(vcpu,
>> -					     VMXERR_VMCLEAR_VMXON_POINTER);
>> +					     VMXERR_VMPTRLD_VMXON_POINTER);
>>  			skip_emulated_instruction(vcpu);
>>  			return 1;
>>  		}
>> 
> 
> VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is correct
> (Vol. 3C 30-16 and 30-29).
> 
> Reviewed-by: David Hildenbrand <david@redhat.com>

Jim, I don't see your emails on the list (that don't Cc me) after Nov 4.
Have you posted more than this patch and the checkpoint/restore series?
([PATCH 0/8] kvm: nVMX: Checkpoint/restore support for VMX state)

I'm sorry they fell through cracks.
(Still no idea why -- filters don't even delete mail.)

  reply	other threads:[~2016-12-08 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 23:50 [PATCH] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD Jim Mattson
2016-11-30 17:54 ` Jim Mattson
2016-11-30 18:28   ` [PATCH v2] " Jim Mattson
2016-12-05 14:31     ` David Hildenbrand
2016-12-08 15:27       ` Radim Krčmář [this message]
2016-12-08 15:59         ` Jim Mattson
2016-12-09 14:54     ` Paolo Bonzini
2016-12-12  6:28     ` Paolo Bonzini
2016-12-13 23:16       ` Gan Shun Lim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208152744.GB22892@potion \
    --to=rkrcmar@redhat.com \
    --cc=david@redhat.com \
    --cc=ganshun@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.