* [PATCH] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
@ 2016-11-28 23:50 Jim Mattson
2016-11-30 17:54 ` Jim Mattson
0 siblings, 1 reply; 9+ messages in thread
From: Jim Mattson @ 2016-11-28 23:50 UTC (permalink / raw)
To: kvm; +Cc: GanShun, Jim Mattson
From: GanShun <ganshun@google.com>
When the operand passed to VMPTRLD matches the address of the VMXON
region, the VMX instruction error code should be
VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
Signed-off-by: Jim Mattson <jmattson@google.com>
---
arch/x86/kvm/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0c4cde8..7e3a45e 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -6945,7 +6945,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
if (vmptr == vmx->nested.vmxon_ptr) {
nested_vmx_failValid(vcpu,
- VMXERR_VMCLEAR_VMXON_POINTER);
+ VMXERR_VMPTRLD_VMXON_POINTER);
skip_emulated_instruction(vcpu);
return 1;
}
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-11-28 23:50 [PATCH] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD Jim Mattson
@ 2016-11-30 17:54 ` Jim Mattson
2016-11-30 18:28 ` [PATCH v2] " Jim Mattson
0 siblings, 1 reply; 9+ messages in thread
From: Jim Mattson @ 2016-11-30 17:54 UTC (permalink / raw)
To: kvm; +Cc: GanShun, Jim Mattson
Sigh. Mis-applied patch. Update forthcoming.
On Mon, Nov 28, 2016 at 3:50 PM, Jim Mattson <jmattson@google.com> wrote:
> From: GanShun <ganshun@google.com>
>
> When the operand passed to VMPTRLD matches the address of the VMXON
> region, the VMX instruction error code should be
> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0c4cde8..7e3a45e 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6945,7 +6945,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>
> if (vmptr == vmx->nested.vmxon_ptr) {
> nested_vmx_failValid(vcpu,
> - VMXERR_VMCLEAR_VMXON_POINTER);
> + VMXERR_VMPTRLD_VMXON_POINTER);
> skip_emulated_instruction(vcpu);
> return 1;
> }
> --
> 2.8.0.rc3.226.g39d4020
>
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-11-30 17:54 ` Jim Mattson
@ 2016-11-30 18:28 ` Jim Mattson
2016-12-05 14:31 ` David Hildenbrand
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jim Mattson @ 2016-11-30 18:28 UTC (permalink / raw)
To: kvm; +Cc: GanShun, Jim Mattson
From: GanShun <ganshun@google.com>
When the operand passed to VMPTRLD matches the address of the VMXON
region, the VMX instruction error code should be
VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
Signed-off-by: Jim Mattson <jmattson@google.com>
---
arch/x86/kvm/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 0c4cde8..a1c7a43 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
if (vmptr == vmx->nested.vmxon_ptr) {
nested_vmx_failValid(vcpu,
- VMXERR_VMCLEAR_VMXON_POINTER);
+ VMXERR_VMPTRLD_VMXON_POINTER);
skip_emulated_instruction(vcpu);
return 1;
}
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-11-30 18:28 ` [PATCH v2] " Jim Mattson
@ 2016-12-05 14:31 ` David Hildenbrand
2016-12-08 15:27 ` Radim Krčmář
2016-12-09 14:54 ` Paolo Bonzini
2016-12-12 6:28 ` Paolo Bonzini
2 siblings, 1 reply; 9+ messages in thread
From: David Hildenbrand @ 2016-12-05 14:31 UTC (permalink / raw)
To: Jim Mattson, kvm; +Cc: GanShun
Am 30.11.2016 um 19:28 schrieb Jim Mattson:
> From: GanShun <ganshun@google.com>
>
> When the operand passed to VMPTRLD matches the address of the VMXON
> region, the VMX instruction error code should be
> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0c4cde8..a1c7a43 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>
> if (vmptr == vmx->nested.vmxon_ptr) {
> nested_vmx_failValid(vcpu,
> - VMXERR_VMCLEAR_VMXON_POINTER);
> + VMXERR_VMPTRLD_VMXON_POINTER);
> skip_emulated_instruction(vcpu);
> return 1;
> }
>
VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is
correct (Vol. 3C 30-16 and 30-29).
Reviewed-by: David Hildenbrand <david@redhat.com>
--
David
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-12-05 14:31 ` David Hildenbrand
@ 2016-12-08 15:27 ` Radim Krčmář
2016-12-08 15:59 ` Jim Mattson
0 siblings, 1 reply; 9+ messages in thread
From: Radim Krčmář @ 2016-12-08 15:27 UTC (permalink / raw)
To: David Hildenbrand; +Cc: Jim Mattson, kvm, GanShun
2016-12-05 15:31+0100, David Hildenbrand:
> Am 30.11.2016 um 19:28 schrieb Jim Mattson:
>> From: GanShun <ganshun@google.com>
>>
>> When the operand passed to VMPTRLD matches the address of the VMXON
>> region, the VMX instruction error code should be
>> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>>
>> Signed-off-by: Jim Mattson <jmattson@google.com>
>> ---
>> arch/x86/kvm/vmx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 0c4cde8..a1c7a43 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>>
>> if (vmptr == vmx->nested.vmxon_ptr) {
>> nested_vmx_failValid(vcpu,
>> - VMXERR_VMCLEAR_VMXON_POINTER);
>> + VMXERR_VMPTRLD_VMXON_POINTER);
>> skip_emulated_instruction(vcpu);
>> return 1;
>> }
>>
>
> VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is correct
> (Vol. 3C 30-16 and 30-29).
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
Jim, I don't see your emails on the list (that don't Cc me) after Nov 4.
Have you posted more than this patch and the checkpoint/restore series?
([PATCH 0/8] kvm: nVMX: Checkpoint/restore support for VMX state)
I'm sorry they fell through cracks.
(Still no idea why -- filters don't even delete mail.)
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-12-08 15:27 ` Radim Krčmář
@ 2016-12-08 15:59 ` Jim Mattson
0 siblings, 0 replies; 9+ messages in thread
From: Jim Mattson @ 2016-12-08 15:59 UTC (permalink / raw)
To: Radim Krčmář; +Cc: David Hildenbrand, kvm, GanShun
Just one, I think: [kvm-unit-tests PATCH] Test 32-bit ljmp emulation.
On Thu, Dec 8, 2016 at 7:27 AM, Radim Krčmář <rkrcmar@redhat.com> wrote:
> 2016-12-05 15:31+0100, David Hildenbrand:
>> Am 30.11.2016 um 19:28 schrieb Jim Mattson:
>>> From: GanShun <ganshun@google.com>
>>>
>>> When the operand passed to VMPTRLD matches the address of the VMXON
>>> region, the VMX instruction error code should be
>>> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>>>
>>> Signed-off-by: Jim Mattson <jmattson@google.com>
>>> ---
>>> arch/x86/kvm/vmx.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>>> index 0c4cde8..a1c7a43 100644
>>> --- a/arch/x86/kvm/vmx.c
>>> +++ b/arch/x86/kvm/vmx.c
>>> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>>>
>>> if (vmptr == vmx->nested.vmxon_ptr) {
>>> nested_vmx_failValid(vcpu,
>>> - VMXERR_VMCLEAR_VMXON_POINTER);
>>> + VMXERR_VMPTRLD_VMXON_POINTER);
>>> skip_emulated_instruction(vcpu);
>>> return 1;
>>> }
>>>
>>
>> VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is correct
>> (Vol. 3C 30-16 and 30-29).
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>
> Jim, I don't see your emails on the list (that don't Cc me) after Nov 4.
> Have you posted more than this patch and the checkpoint/restore series?
> ([PATCH 0/8] kvm: nVMX: Checkpoint/restore support for VMX state)
>
> I'm sorry they fell through cracks.
> (Still no idea why -- filters don't even delete mail.)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-11-30 18:28 ` [PATCH v2] " Jim Mattson
2016-12-05 14:31 ` David Hildenbrand
@ 2016-12-09 14:54 ` Paolo Bonzini
2016-12-12 6:28 ` Paolo Bonzini
2 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2016-12-09 14:54 UTC (permalink / raw)
To: Jim Mattson, kvm; +Cc: GanShun
On 30/11/2016 19:28, Jim Mattson wrote:
> From: GanShun <ganshun@google.com>
>
> When the operand passed to VMPTRLD matches the address of the VMXON
> region, the VMX instruction error code should be
> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 0c4cde8..a1c7a43 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>
> if (vmptr == vmx->nested.vmxon_ptr) {
> nested_vmx_failValid(vcpu,
> - VMXERR_VMCLEAR_VMXON_POINTER);
> + VMXERR_VMPTRLD_VMXON_POINTER);
> skip_emulated_instruction(vcpu);
> return 1;
> }
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-11-30 18:28 ` [PATCH v2] " Jim Mattson
2016-12-05 14:31 ` David Hildenbrand
2016-12-09 14:54 ` Paolo Bonzini
@ 2016-12-12 6:28 ` Paolo Bonzini
2016-12-13 23:16 ` Gan Shun Lim
2 siblings, 1 reply; 9+ messages in thread
From: Paolo Bonzini @ 2016-12-12 6:28 UTC (permalink / raw)
To: Jim Mattson, kvm; +Cc: GanShun
On 30/11/2016 19:28, Jim Mattson wrote:
> From: GanShun <ganshun@google.com>
>
> When the operand passed to VMPTRLD matches the address of the VMXON
> region, the VMX instruction error code should be
> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch is missing GanShun's Signed-off-by.
Paolo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD
2016-12-12 6:28 ` Paolo Bonzini
@ 2016-12-13 23:16 ` Gan Shun Lim
0 siblings, 0 replies; 9+ messages in thread
From: Gan Shun Lim @ 2016-12-13 23:16 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Jim Mattson, kvm
Signed-off-by: GanShun <ganshun@google.com>
On Mon, Dec 12, 2016 at 2:28 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 30/11/2016 19:28, Jim Mattson wrote:
>> From: GanShun <ganshun@google.com>
>>
>> When the operand passed to VMPTRLD matches the address of the VMXON
>> region, the VMX instruction error code should be
>> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>>
>> Signed-off-by: Jim Mattson <jmattson@google.com>
>> ---
>> arch/x86/kvm/vmx.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch is missing GanShun's Signed-off-by.
>
> Paolo
--
-- Gan Shun
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-12-13 23:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 23:50 [PATCH] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD Jim Mattson
2016-11-30 17:54 ` Jim Mattson
2016-11-30 18:28 ` [PATCH v2] " Jim Mattson
2016-12-05 14:31 ` David Hildenbrand
2016-12-08 15:27 ` Radim Krčmář
2016-12-08 15:59 ` Jim Mattson
2016-12-09 14:54 ` Paolo Bonzini
2016-12-12 6:28 ` Paolo Bonzini
2016-12-13 23:16 ` Gan Shun Lim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.