All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
@ 2016-12-14 14:47 Stefan Hajnoczi
  2016-12-14 15:10 ` Fam Zheng
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-14 14:47 UTC (permalink / raw)
  To: qemu-devel
  Cc: Laurent Vivier, Kevin Wolf, Pino Toscano, Fam Zheng, Stefan Hajnoczi

There are missing translations for the new "Copy" menu item.

The following people provided them to me on IRC just in time for the
QEMU 2.8 release:

 * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
 * fr_FR - Laurent Vivier <laurent@vivier.eu>
 * it    - Pino Toscano <ptoscano@redhat.com>
 * zh_CN - Fam Zheng <famz@redhat.com>

Reported-by: Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>
Cc: Pino Toscano <ptoscano@redhat.com>
Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 po/de_DE.po | 2 +-
 po/fr_FR.po | 2 +-
 po/it.po    | 4 ++--
 po/zh_CN.po | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/po/de_DE.po b/po/de_DE.po
index 7dcd0dc..de27fcf 100644
--- a/po/de_DE.po
+++ b/po/de_DE.po
@@ -46,7 +46,7 @@ msgstr "_Vollbild"
 
 #: ui/gtk.c:2032
 msgid "_Copy"
-msgstr ""
+msgstr "_Kopieren"
 
 #: ui/gtk.c:2048
 msgid "Zoom _In"
diff --git a/po/fr_FR.po b/po/fr_FR.po
index 358532b..94f4a94 100644
--- a/po/fr_FR.po
+++ b/po/fr_FR.po
@@ -47,7 +47,7 @@ msgstr "Mode _plein écran"
 
 #: ui/gtk.c:2032
 msgid "_Copy"
-msgstr ""
+msgstr "_Copier"
 
 #: ui/gtk.c:2048
 msgid "Zoom _In"
diff --git a/po/it.po b/po/it.po
index 8eadf2f..bfae84e 100644
--- a/po/it.po
+++ b/po/it.po
@@ -42,11 +42,11 @@ msgstr "_Esci"
 
 #: ui/gtk.c:2029
 msgid "_Fullscreen"
-msgstr ""
+msgstr "A t_utto schermo"
 
 #: ui/gtk.c:2032
 msgid "_Copy"
-msgstr ""
+msgstr "_Copia"
 
 #: ui/gtk.c:2048
 msgid "Zoom _In"
diff --git a/po/zh_CN.po b/po/zh_CN.po
index 9523cfb..3491bf2 100644
--- a/po/zh_CN.po
+++ b/po/zh_CN.po
@@ -47,7 +47,7 @@ msgstr "全屏(_F)"
 
 #: ui/gtk.c:2032
 msgid "_Copy"
-msgstr ""
+msgstr "复制 (_C)"
 
 #: ui/gtk.c:2048
 msgid "Zoom _In"
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 14:47 [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh Stefan Hajnoczi
@ 2016-12-14 15:10 ` Fam Zheng
  2016-12-14 15:14   ` Stefan Hajnoczi
  2016-12-14 15:40 ` Pino Toscano
  2016-12-14 15:41 ` Laurent Vivier
  2 siblings, 1 reply; 12+ messages in thread
From: Fam Zheng @ 2016-12-14 15:10 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel, Laurent Vivier, Kevin Wolf, Pino Toscano

On Wed, 12/14 14:47, Stefan Hajnoczi wrote:
> There are missing translations for the new "Copy" menu item.
> 
> The following people provided them to me on IRC just in time for the
> QEMU 2.8 release:
> 
>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>  * it    - Pino Toscano <ptoscano@redhat.com>
>  * zh_CN - Fam Zheng <famz@redhat.com>
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Pino Toscano <ptoscano@redhat.com>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  po/de_DE.po | 2 +-
>  po/fr_FR.po | 2 +-
>  po/it.po    | 4 ++--
>  po/zh_CN.po | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/po/de_DE.po b/po/de_DE.po
> index 7dcd0dc..de27fcf 100644
> --- a/po/de_DE.po
> +++ b/po/de_DE.po
> @@ -46,7 +46,7 @@ msgstr "_Vollbild"
>  
>  #: ui/gtk.c:2032
>  msgid "_Copy"
> -msgstr ""
> +msgstr "_Kopieren"
>  
>  #: ui/gtk.c:2048
>  msgid "Zoom _In"
> diff --git a/po/fr_FR.po b/po/fr_FR.po
> index 358532b..94f4a94 100644
> --- a/po/fr_FR.po
> +++ b/po/fr_FR.po
> @@ -47,7 +47,7 @@ msgstr "Mode _plein écran"
>  
>  #: ui/gtk.c:2032
>  msgid "_Copy"
> -msgstr ""
> +msgstr "_Copier"
>  
>  #: ui/gtk.c:2048
>  msgid "Zoom _In"
> diff --git a/po/it.po b/po/it.po
> index 8eadf2f..bfae84e 100644
> --- a/po/it.po
> +++ b/po/it.po
> @@ -42,11 +42,11 @@ msgstr "_Esci"
>  
>  #: ui/gtk.c:2029
>  msgid "_Fullscreen"
> -msgstr ""
> +msgstr "A t_utto schermo"
>  
>  #: ui/gtk.c:2032
>  msgid "_Copy"
> -msgstr ""
> +msgstr "_Copia"
>  
>  #: ui/gtk.c:2048
>  msgid "Zoom _In"
> diff --git a/po/zh_CN.po b/po/zh_CN.po
> index 9523cfb..3491bf2 100644
> --- a/po/zh_CN.po
> +++ b/po/zh_CN.po
> @@ -47,7 +47,7 @@ msgstr "全屏(_F)"
>  
>  #: ui/gtk.c:2032
>  msgid "_Copy"
> -msgstr ""
> +msgstr "复制 (_C)"

Other entries don't have the space before the open parenthesis, could you drop
it when applying?

Fam

>  
>  #: ui/gtk.c:2048
>  msgid "Zoom _In"
> -- 
> 2.9.3
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 15:10 ` Fam Zheng
@ 2016-12-14 15:14   ` Stefan Hajnoczi
  0 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-14 15:14 UTC (permalink / raw)
  To: Fam Zheng
  Cc: Stefan Hajnoczi, Kevin Wolf, Pino Toscano, qemu-devel, Laurent Vivier

On Wed, Dec 14, 2016 at 3:10 PM, Fam Zheng <famz@redhat.com> wrote:
> On Wed, 12/14 14:47, Stefan Hajnoczi wrote:
>> There are missing translations for the new "Copy" menu item.
>>
>> The following people provided them to me on IRC just in time for the
>> QEMU 2.8 release:
>>
>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>>  * it    - Pino Toscano <ptoscano@redhat.com>
>>  * zh_CN - Fam Zheng <famz@redhat.com>
>>
>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> Cc: Fam Zheng <famz@redhat.com>
>> Cc: Pino Toscano <ptoscano@redhat.com>
>> Cc: Laurent Vivier <laurent@vivier.eu>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>  po/de_DE.po | 2 +-
>>  po/fr_FR.po | 2 +-
>>  po/it.po    | 4 ++--
>>  po/zh_CN.po | 2 +-
>>  4 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/po/de_DE.po b/po/de_DE.po
>> index 7dcd0dc..de27fcf 100644
>> --- a/po/de_DE.po
>> +++ b/po/de_DE.po
>> @@ -46,7 +46,7 @@ msgstr "_Vollbild"
>>
>>  #: ui/gtk.c:2032
>>  msgid "_Copy"
>> -msgstr ""
>> +msgstr "_Kopieren"
>>
>>  #: ui/gtk.c:2048
>>  msgid "Zoom _In"
>> diff --git a/po/fr_FR.po b/po/fr_FR.po
>> index 358532b..94f4a94 100644
>> --- a/po/fr_FR.po
>> +++ b/po/fr_FR.po
>> @@ -47,7 +47,7 @@ msgstr "Mode _plein écran"
>>
>>  #: ui/gtk.c:2032
>>  msgid "_Copy"
>> -msgstr ""
>> +msgstr "_Copier"
>>
>>  #: ui/gtk.c:2048
>>  msgid "Zoom _In"
>> diff --git a/po/it.po b/po/it.po
>> index 8eadf2f..bfae84e 100644
>> --- a/po/it.po
>> +++ b/po/it.po
>> @@ -42,11 +42,11 @@ msgstr "_Esci"
>>
>>  #: ui/gtk.c:2029
>>  msgid "_Fullscreen"
>> -msgstr ""
>> +msgstr "A t_utto schermo"
>>
>>  #: ui/gtk.c:2032
>>  msgid "_Copy"
>> -msgstr ""
>> +msgstr "_Copia"
>>
>>  #: ui/gtk.c:2048
>>  msgid "Zoom _In"
>> diff --git a/po/zh_CN.po b/po/zh_CN.po
>> index 9523cfb..3491bf2 100644
>> --- a/po/zh_CN.po
>> +++ b/po/zh_CN.po
>> @@ -47,7 +47,7 @@ msgstr "全屏(_F)"
>>
>>  #: ui/gtk.c:2032
>>  msgid "_Copy"
>> -msgstr ""
>> +msgstr "复制 (_C)"
>
> Other entries don't have the space before the open parenthesis, could you drop
> it when applying?

Yes, I'll fix it, thanks!

Stefan

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 14:47 [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh Stefan Hajnoczi
  2016-12-14 15:10 ` Fam Zheng
@ 2016-12-14 15:40 ` Pino Toscano
  2016-12-14 16:27   ` Stefan Hajnoczi
  2016-12-14 15:41 ` Laurent Vivier
  2 siblings, 1 reply; 12+ messages in thread
From: Pino Toscano @ 2016-12-14 15:40 UTC (permalink / raw)
  To: Stefan Hajnoczi; +Cc: qemu-devel, Laurent Vivier, Kevin Wolf, Fam Zheng

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Wednesday, 14 December 2016 14:47:13 CET Stefan Hajnoczi wrote:
> There are missing translations for the new "Copy" menu item.
> 
> The following people provided them to me on IRC just in time for the
> QEMU 2.8 release:
> 
>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>  * it    - Pino Toscano <ptoscano@redhat.com>
>  * zh_CN - Fam Zheng <famz@redhat.com>
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Pino Toscano <ptoscano@redhat.com>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> [...]
> diff --git a/po/it.po b/po/it.po
> index 8eadf2f..bfae84e 100644
> --- a/po/it.po
> +++ b/po/it.po
> @@ -42,11 +42,11 @@ msgstr "_Esci"
>  
>  #: ui/gtk.c:2029
>  msgid "_Fullscreen"
> -msgstr ""
> +msgstr "A t_utto schermo"
>  
>  #: ui/gtk.c:2032
>  msgid "_Copy"
> -msgstr ""
> +msgstr "_Copia"
>  
>  #: ui/gtk.c:2048
>  msgid "Zoom _In"

ACK.

Should PO-Revision-Date be updated as well?

Thanks,
-- 
Pino Toscano

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 14:47 [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh Stefan Hajnoczi
  2016-12-14 15:10 ` Fam Zheng
  2016-12-14 15:40 ` Pino Toscano
@ 2016-12-14 15:41 ` Laurent Vivier
  2016-12-14 15:58   ` Stefan Hajnoczi
  2 siblings, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2016-12-14 15:41 UTC (permalink / raw)
  To: Stefan Hajnoczi, qemu-devel; +Cc: Kevin Wolf, Pino Toscano, Fam Zheng

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
> There are missing translations for the new "Copy" menu item.
> 
> The following people provided them to me on IRC just in time for the
> QEMU 2.8 release:
> 
>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>  * it    - Pino Toscano <ptoscano@redhat.com>
>  * zh_CN - Fam Zheng <famz@redhat.com>
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Cc: Fam Zheng <famz@redhat.com>
> Cc: Pino Toscano <ptoscano@redhat.com>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

"Copier" is OK now, but it seems we have some problems with the accents.
I don't know why.

Laurent


[-- Attachment #2: QEMU_fr.png --]
[-- Type: image/png, Size: 33595 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 15:41 ` Laurent Vivier
@ 2016-12-14 15:58   ` Stefan Hajnoczi
  2016-12-14 16:08     ` Kevin Wolf
  0 siblings, 1 reply; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-14 15:58 UTC (permalink / raw)
  To: Laurent Vivier
  Cc: Stefan Hajnoczi, qemu-devel, Kevin Wolf, Fam Zheng, Pino Toscano

On Wed, Dec 14, 2016 at 3:41 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
>> There are missing translations for the new "Copy" menu item.
>>
>> The following people provided them to me on IRC just in time for the
>> QEMU 2.8 release:
>>
>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>>  * it    - Pino Toscano <ptoscano@redhat.com>
>>  * zh_CN - Fam Zheng <famz@redhat.com>
>>
>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> Cc: Fam Zheng <famz@redhat.com>
>> Cc: Pino Toscano <ptoscano@redhat.com>
>> Cc: Laurent Vivier <laurent@vivier.eu>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> "Copier" is OK now, but it seems we have some problems with the accents.
> I don't know why.

It could be an email encoding issue.  On disk I see the proper UTF-8 characters.

You could try my git branch to avoid email issues:
https://github.com/stefanha/qemu/tree/missing-translations-2.8

Stefan

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 15:58   ` Stefan Hajnoczi
@ 2016-12-14 16:08     ` Kevin Wolf
  2016-12-14 16:17       ` Laurent Vivier
  0 siblings, 1 reply; 12+ messages in thread
From: Kevin Wolf @ 2016-12-14 16:08 UTC (permalink / raw)
  To: Stefan Hajnoczi
  Cc: Laurent Vivier, Stefan Hajnoczi, qemu-devel, Fam Zheng, Pino Toscano

Am 14.12.2016 um 16:58 hat Stefan Hajnoczi geschrieben:
> On Wed, Dec 14, 2016 at 3:41 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> > Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
> >> There are missing translations for the new "Copy" menu item.
> >>
> >> The following people provided them to me on IRC just in time for the
> >> QEMU 2.8 release:
> >>
> >>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
> >>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
> >>  * it    - Pino Toscano <ptoscano@redhat.com>
> >>  * zh_CN - Fam Zheng <famz@redhat.com>
> >>
> >> Reported-by: Kevin Wolf <kwolf@redhat.com>
> >> Cc: Fam Zheng <famz@redhat.com>
> >> Cc: Pino Toscano <ptoscano@redhat.com>
> >> Cc: Laurent Vivier <laurent@vivier.eu>
> >> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> >
> > "Copier" is OK now, but it seems we have some problems with the accents.
> > I don't know why.
> 
> It could be an email encoding issue.  On disk I see the proper UTF-8 characters.
> 
> You could try my git branch to avoid email issues:
> https://github.com/stefanha/qemu/tree/missing-translations-2.8

IIRC, it's actually a known problem with not consistently using a UTF-8
locale, and we avoid changing some locale categories because that would
break things like floating point representation in JSON (because printf
might end up using comma as the decimal separator).

Kevin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 16:08     ` Kevin Wolf
@ 2016-12-14 16:17       ` Laurent Vivier
  2016-12-14 16:31         ` Kevin Wolf
  0 siblings, 1 reply; 12+ messages in thread
From: Laurent Vivier @ 2016-12-14 16:17 UTC (permalink / raw)
  To: Kevin Wolf, Stefan Hajnoczi
  Cc: Stefan Hajnoczi, qemu-devel, Fam Zheng, Pino Toscano

Le 14/12/2016 à 17:08, Kevin Wolf a écrit :
> Am 14.12.2016 um 16:58 hat Stefan Hajnoczi geschrieben:
>> On Wed, Dec 14, 2016 at 3:41 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>>> Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
>>>> There are missing translations for the new "Copy" menu item.
>>>>
>>>> The following people provided them to me on IRC just in time for the
>>>> QEMU 2.8 release:
>>>>
>>>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>>>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>>>>  * it    - Pino Toscano <ptoscano@redhat.com>
>>>>  * zh_CN - Fam Zheng <famz@redhat.com>
>>>>
>>>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>>>> Cc: Fam Zheng <famz@redhat.com>
>>>> Cc: Pino Toscano <ptoscano@redhat.com>
>>>> Cc: Laurent Vivier <laurent@vivier.eu>
>>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>>>
>>> "Copier" is OK now, but it seems we have some problems with the accents.
>>> I don't know why.
>>
>> It could be an email encoding issue.  On disk I see the proper UTF-8 characters.
>>
>> You could try my git branch to avoid email issues:
>> https://github.com/stefanha/qemu/tree/missing-translations-2.8
> 
> IIRC, it's actually a known problem with not consistently using a UTF-8
> locale, and we avoid changing some locale categories because that would
> break things like floating point representation in JSON (because printf
> might end up using comma as the decimal separator).

So the translation like the Chinese one is totally unusable?

Laurent

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 15:40 ` Pino Toscano
@ 2016-12-14 16:27   ` Stefan Hajnoczi
  0 siblings, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-14 16:27 UTC (permalink / raw)
  To: Pino Toscano
  Cc: Stefan Hajnoczi, Kevin Wolf, Fam Zheng, qemu-devel, Laurent Vivier

On Wed, Dec 14, 2016 at 3:40 PM, Pino Toscano <ptoscano@redhat.com> wrote:
> On Wednesday, 14 December 2016 14:47:13 CET Stefan Hajnoczi wrote:
>> There are missing translations for the new "Copy" menu item.
>>
>> The following people provided them to me on IRC just in time for the
>> QEMU 2.8 release:
>>
>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>>  * it    - Pino Toscano <ptoscano@redhat.com>
>>  * zh_CN - Fam Zheng <famz@redhat.com>
>>
>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> Cc: Fam Zheng <famz@redhat.com>
>> Cc: Pino Toscano <ptoscano@redhat.com>
>> Cc: Laurent Vivier <laurent@vivier.eu>
>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> [...]
>> diff --git a/po/it.po b/po/it.po
>> index 8eadf2f..bfae84e 100644
>> --- a/po/it.po
>> +++ b/po/it.po
>> @@ -42,11 +42,11 @@ msgstr "_Esci"
>>
>>  #: ui/gtk.c:2029
>>  msgid "_Fullscreen"
>> -msgstr ""
>> +msgstr "A t_utto schermo"
>>
>>  #: ui/gtk.c:2032
>>  msgid "_Copy"
>> -msgstr ""
>> +msgstr "_Copia"
>>
>>  #: ui/gtk.c:2048
>>  msgid "Zoom _In"
>
> ACK.
>
> Should PO-Revision-Date be updated as well?

No, I will ignore the po metadata as some of the previous commits have done.

I've looked through the commit history: sometimes we update them,
sometimes we don't.  The creation date field keeps getting changed
although the revision date doesn't (i.e. creation is newer than
revision date!).  The QEMU version in the Project-Id is ridiculously
out of date.  These fields may make sense in some translation
workflows, especially without a version control system, but for the
QEMU project they are useless.

If allowed by the file format we should remove them completely since
git already contains this information.

Stefan

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 16:17       ` Laurent Vivier
@ 2016-12-14 16:31         ` Kevin Wolf
  2016-12-14 16:56           ` Stefan Hajnoczi
  2016-12-14 17:03           ` Stefan Weil
  0 siblings, 2 replies; 12+ messages in thread
From: Kevin Wolf @ 2016-12-14 16:31 UTC (permalink / raw)
  To: Laurent Vivier
  Cc: Stefan Hajnoczi, Stefan Hajnoczi, qemu-devel, Fam Zheng, Pino Toscano

Am 14.12.2016 um 17:17 hat Laurent Vivier geschrieben:
> Le 14/12/2016 à 17:08, Kevin Wolf a écrit :
> > Am 14.12.2016 um 16:58 hat Stefan Hajnoczi geschrieben:
> >> On Wed, Dec 14, 2016 at 3:41 PM, Laurent Vivier <laurent@vivier.eu> wrote:
> >>> Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
> >>>> There are missing translations for the new "Copy" menu item.
> >>>>
> >>>> The following people provided them to me on IRC just in time for the
> >>>> QEMU 2.8 release:
> >>>>
> >>>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
> >>>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
> >>>>  * it    - Pino Toscano <ptoscano@redhat.com>
> >>>>  * zh_CN - Fam Zheng <famz@redhat.com>
> >>>>
> >>>> Reported-by: Kevin Wolf <kwolf@redhat.com>
> >>>> Cc: Fam Zheng <famz@redhat.com>
> >>>> Cc: Pino Toscano <ptoscano@redhat.com>
> >>>> Cc: Laurent Vivier <laurent@vivier.eu>
> >>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> >>>
> >>> "Copier" is OK now, but it seems we have some problems with the accents.
> >>> I don't know why.
> >>
> >> It could be an email encoding issue.  On disk I see the proper UTF-8 characters.
> >>
> >> You could try my git branch to avoid email issues:
> >> https://github.com/stefanha/qemu/tree/missing-translations-2.8
> > 
> > IIRC, it's actually a known problem with not consistently using a UTF-8
> > locale, and we avoid changing some locale categories because that would
> > break things like floating point representation in JSON (because printf
> > might end up using comma as the decimal separator).
> 
> So the translation like the Chinese one is totally unusable?

I just tried it:

$ LANG=zh_CN x86_64-softmmu/qemu-system-x86_64

And yes, lots of question marks there...

Kevin

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 16:31         ` Kevin Wolf
@ 2016-12-14 16:56           ` Stefan Hajnoczi
  2016-12-14 17:03           ` Stefan Weil
  1 sibling, 0 replies; 12+ messages in thread
From: Stefan Hajnoczi @ 2016-12-14 16:56 UTC (permalink / raw)
  To: Kevin Wolf
  Cc: Laurent Vivier, Stefan Hajnoczi, qemu-devel, Fam Zheng, Pino Toscano

On Wed, Dec 14, 2016 at 4:31 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 14.12.2016 um 17:17 hat Laurent Vivier geschrieben:
>> Le 14/12/2016 à 17:08, Kevin Wolf a écrit :
>> > Am 14.12.2016 um 16:58 hat Stefan Hajnoczi geschrieben:
>> >> On Wed, Dec 14, 2016 at 3:41 PM, Laurent Vivier <laurent@vivier.eu> wrote:
>> >>> Le 14/12/2016 à 15:47, Stefan Hajnoczi a écrit :
>> >>>> There are missing translations for the new "Copy" menu item.
>> >>>>
>> >>>> The following people provided them to me on IRC just in time for the
>> >>>> QEMU 2.8 release:
>> >>>>
>> >>>>  * de_DE - Stefan Hajnoczi <stefanha@redhat.com>
>> >>>>  * fr_FR - Laurent Vivier <laurent@vivier.eu>
>> >>>>  * it    - Pino Toscano <ptoscano@redhat.com>
>> >>>>  * zh_CN - Fam Zheng <famz@redhat.com>
>> >>>>
>> >>>> Reported-by: Kevin Wolf <kwolf@redhat.com>
>> >>>> Cc: Fam Zheng <famz@redhat.com>
>> >>>> Cc: Pino Toscano <ptoscano@redhat.com>
>> >>>> Cc: Laurent Vivier <laurent@vivier.eu>
>> >>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> >>>
>> >>> "Copier" is OK now, but it seems we have some problems with the accents.
>> >>> I don't know why.
>> >>
>> >> It could be an email encoding issue.  On disk I see the proper UTF-8 characters.
>> >>
>> >> You could try my git branch to avoid email issues:
>> >> https://github.com/stefanha/qemu/tree/missing-translations-2.8
>> >
>> > IIRC, it's actually a known problem with not consistently using a UTF-8
>> > locale, and we avoid changing some locale categories because that would
>> > break things like floating point representation in JSON (because printf
>> > might end up using comma as the decimal separator).
>>
>> So the translation like the Chinese one is totally unusable?
>
> I just tried it:
>
> $ LANG=zh_CN x86_64-softmmu/qemu-system-x86_64
>
> And yes, lots of question marks there...

Berto pointed at
https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03368.html

I've confirmed that removing gtk_disable_setlocale() fixes non-ASCII
character rendering.  But we don't it breaks other things in QEMU so
the solution isn't that simple...

Stefan

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh
  2016-12-14 16:31         ` Kevin Wolf
  2016-12-14 16:56           ` Stefan Hajnoczi
@ 2016-12-14 17:03           ` Stefan Weil
  1 sibling, 0 replies; 12+ messages in thread
From: Stefan Weil @ 2016-12-14 17:03 UTC (permalink / raw)
  To: Kevin Wolf, Laurent Vivier
  Cc: Stefan Hajnoczi, Fam Zheng, qemu-devel, Stefan Hajnoczi, Pino Toscano

Am 14.12.2016 um 17:31 schrieb Kevin Wolf:
> Am 14.12.2016 um 17:17 hat Laurent Vivier geschrieben:
>> Le 14/12/2016 à 17:08, Kevin Wolf a écrit :
>>> Am 14.12.2016 um 16:58 hat Stefan Hajnoczi geschrieben:
>>> IIRC, it's actually a known problem with not consistently using a UTF-8
>>> locale, and we avoid changing some locale categories because that would
>>> break things like floating point representation in JSON (because printf
>>> might end up using comma as the decimal separator).
>>
>> So the translation like the Chinese one is totally unusable?
> 
> I just tried it:
> 
> $ LANG=zh_CN x86_64-softmmu/qemu-system-x86_64
> 
> And yes, lots of question marks there...
> 
> Kevin

It's good to know that there remains some work to be done after 2.8. :-)
This is not a regression, so IMHO the status quo is good enough for now.

Stefan

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2016-12-14 17:03 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14 14:47 [Qemu-devel] [PATCH for-2.8] po: add missing translations in de, fr, it, zh Stefan Hajnoczi
2016-12-14 15:10 ` Fam Zheng
2016-12-14 15:14   ` Stefan Hajnoczi
2016-12-14 15:40 ` Pino Toscano
2016-12-14 16:27   ` Stefan Hajnoczi
2016-12-14 15:41 ` Laurent Vivier
2016-12-14 15:58   ` Stefan Hajnoczi
2016-12-14 16:08     ` Kevin Wolf
2016-12-14 16:17       ` Laurent Vivier
2016-12-14 16:31         ` Kevin Wolf
2016-12-14 16:56           ` Stefan Hajnoczi
2016-12-14 17:03           ` Stefan Weil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.