All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Kyle McMartin <kyle@redhat.com>,
	David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	lkml <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)
Date: Fri, 16 Dec 2016 15:15:54 +0100	[thread overview]
Message-ID: <20161216141554.GA5218@krava> (raw)
In-Reply-To: <20161216140247.GK6866@kernel.org>

On Fri, Dec 16, 2016 at 11:02:47AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 15, 2016 at 08:56:54PM +0100, Jiri Olsa escreveu:
> > There might be systems where MAP_32BIT is not defined,
> > like some some RHEL7 powerpc versions.
> > 
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> > Cc: Kyle McMartin <kyle@redhat.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Fixes: 277cf08f3feb ("perf trace beauty mmap: Fix defines for non !x86_64")
> 
> Ouch, so we need what was removed in:
> 
> Fixes: 256763b01741 ("perf trace beauty mmap: Add more conditional defines")
> 
> I.e. the ifdef at the switch case entry, not the removal of the
> conditional definition expecting that it would be available in the arch
> header, as in some cases those are not there. So I'm replacing the Fixme
> cset, ok?

sure, ok

> 
> Thanks for taking the time to fill in that tag, appreciated!
> 
> Also this all needs a revamp to support cross 'perf trace'ing, i.e.
> collecting a file on arch A and doing 'perf trace -i perf.data' on a
> different machine with a CPU fo a different arch, where either per arch
> beautifiers are needed or a dynamic switch, i.e. the value for some
> define is different between archs....
> 
> Patch applied, thanks,

thanks,
jirka

  reply	other threads:[~2016-12-16 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 19:56 Jiri Olsa
2016-12-16 14:02 ` Arnaldo Carvalho de Melo
2016-12-16 14:15   ` Jiri Olsa [this message]
2016-12-20 19:29 ` [tip:perf/urgent] " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161216141554.GA5218@krava \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kyle@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --subject='Re: [PATCH] perf trace: Check if MAP_32BIT is defined (again)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.