From: Christoph Hellwig <hch@infradead.org> To: Scott Bauer <scott.bauer@intel.com> Cc: linux-nvme@lists.infradead.org, keith.busch@intel.com, sagi@grimberg.me, hch@infradead.org, Rafael.Antognolli@intel.com, linux-kernel@vger.kernel.org, axboe@fb.com, viro@zeniv.linux.org.uk, jonathan.derrick@intel.com Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. Date: Mon, 19 Dec 2016 22:49:01 -0800 [thread overview] Message-ID: <20161220064901.GB13844@infradead.org> (raw) In-Reply-To: <1482176149-2257-5-git-send-email-scott.bauer@intel.com> > +void nvme_unlock_from_suspend(struct nvme_ctrl *ctrl) > +{ > + if (opal_unlock_from_suspend(&ctrl->sed_ctx)) > + pr_warn("Failed to unlock one or more locking ranges!\n"); > +} > +EXPORT_SYMBOL_GPL(nvme_unlock_from_suspend); I don't think we even need this wrapper. Also for the warning please use dev_warn so that the user knows which controller failed. > @@ -1765,7 +1766,7 @@ static void nvme_reset_work(struct work_struct *work) > { > struct nvme_dev *dev = container_of(work, struct nvme_dev, reset_work); > int result = -ENODEV; > - > + bool was_suspend = !!(dev->ctrl.ctrl_config & NVME_CC_SHN_NORMAL); > if (WARN_ON(dev->ctrl.state == NVME_CTRL_RESETTING)) Please don't remove the empty line after the variable declarations. Also I would place your new line before the result line, as that makes it a tad easier to read.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig) Subject: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code. Date: Mon, 19 Dec 2016 22:49:01 -0800 [thread overview] Message-ID: <20161220064901.GB13844@infradead.org> (raw) In-Reply-To: <1482176149-2257-5-git-send-email-scott.bauer@intel.com> > +void nvme_unlock_from_suspend(struct nvme_ctrl *ctrl) > +{ > + if (opal_unlock_from_suspend(&ctrl->sed_ctx)) > + pr_warn("Failed to unlock one or more locking ranges!\n"); > +} > +EXPORT_SYMBOL_GPL(nvme_unlock_from_suspend); I don't think we even need this wrapper. Also for the warning please use dev_warn so that the user knows which controller failed. > @@ -1765,7 +1766,7 @@ static void nvme_reset_work(struct work_struct *work) > { > struct nvme_dev *dev = container_of(work, struct nvme_dev, reset_work); > int result = -ENODEV; > - > + bool was_suspend = !!(dev->ctrl.ctrl_config & NVME_CC_SHN_NORMAL); > if (WARN_ON(dev->ctrl.state == NVME_CTRL_RESETTING)) Please don't remove the empty line after the variable declarations. Also I would place your new line before the result line, as that makes it a tad easier to read.
next prev parent reply other threads:[~2016-12-20 6:49 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-19 19:35 [PATCH v3 0/5] SED OPAL Library Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 19:35 ` [PATCH v3 1/5] include: Add definitions for sed Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-20 6:46 ` Christoph Hellwig 2016-12-20 6:46 ` Christoph Hellwig 2016-12-25 14:15 ` Jethro Beekman 2016-12-25 14:15 ` Jethro Beekman 2016-12-27 22:14 ` Scott Bauer 2016-12-27 22:14 ` Scott Bauer 2016-12-19 19:35 ` [PATCH v3 2/5] lib: Add Sed-opal library Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 21:34 ` Keith Busch 2016-12-19 21:34 ` Keith Busch 2016-12-20 6:07 ` Christoph Hellwig 2016-12-20 6:07 ` Christoph Hellwig 2016-12-20 3:21 ` kbuild test robot 2016-12-20 3:21 ` kbuild test robot 2016-12-20 3:48 ` kbuild test robot 2016-12-20 3:48 ` kbuild test robot 2016-12-20 6:50 ` Al Viro 2016-12-20 6:50 ` Al Viro 2016-12-20 7:28 ` Christoph Hellwig 2016-12-20 7:28 ` Christoph Hellwig 2016-12-20 21:55 ` Scott Bauer 2016-12-20 21:55 ` Scott Bauer 2016-12-21 9:42 ` Christoph Hellwig 2016-12-21 9:42 ` Christoph Hellwig 2016-12-20 22:07 ` Jon Derrick 2016-12-20 22:07 ` Jon Derrick 2016-12-21 9:47 ` Christoph Hellwig 2016-12-21 9:47 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:21 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 21:59 ` Keith Busch 2016-12-19 21:59 ` Keith Busch 2016-12-19 22:23 ` Scott Bauer 2016-12-19 22:23 ` Scott Bauer 2016-12-20 6:17 ` Christoph Hellwig 2016-12-20 6:17 ` Christoph Hellwig 2016-12-20 15:49 ` Keith Busch 2016-12-20 15:49 ` Keith Busch 2016-12-20 15:46 ` Christoph Hellwig 2016-12-20 15:46 ` Christoph Hellwig 2016-12-20 16:05 ` Scott Bauer 2016-12-20 16:05 ` Scott Bauer 2016-12-21 9:01 ` Christoph Hellwig 2016-12-21 9:01 ` Christoph Hellwig 2016-12-20 17:52 ` Scott Bauer 2016-12-20 17:52 ` Scott Bauer 2016-12-21 9:37 ` Christoph Hellwig 2016-12-21 9:37 ` Christoph Hellwig 2016-12-20 4:11 ` kbuild test robot 2016-12-20 4:11 ` kbuild test robot 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:49 ` Christoph Hellwig [this message] 2016-12-20 6:49 ` Christoph Hellwig 2016-12-25 14:15 ` Jethro Beekman 2016-12-25 14:15 ` Jethro Beekman 2016-12-27 22:12 ` Scott Bauer 2016-12-27 22:12 ` Scott Bauer 2016-12-28 8:39 ` Christoph Hellwig 2016-12-28 8:39 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 5/5] Maintainers: Add Information for SED Opal library Scott Bauer 2016-12-19 19:35 ` Scott Bauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161220064901.GB13844@infradead.org \ --to=hch@infradead.org \ --cc=Rafael.Antognolli@intel.com \ --cc=axboe@fb.com \ --cc=jonathan.derrick@intel.com \ --cc=keith.busch@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ --cc=scott.bauer@intel.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.