From: Christoph Hellwig <hch@infradead.org> To: Scott Bauer <scott.bauer@intel.com> Cc: Christoph Hellwig <hch@infradead.org>, linux-nvme@lists.infradead.org, keith.busch@intel.com, sagi@grimberg.me, Rafael.Antognolli@intel.com, linux-kernel@vger.kernel.org, axboe@fb.com, viro@zeniv.linux.org.uk, jonathan.derrick@intel.com Subject: Re: [PATCH v3 2/5] lib: Add Sed-opal library Date: Wed, 21 Dec 2016 01:42:38 -0800 [thread overview] Message-ID: <20161221094238.GC32084@infradead.org> (raw) In-Reply-To: <20161220215509.GA2462@sbauer-Z170X-UD5> On Tue, Dec 20, 2016 at 02:55:10PM -0700, Scott Bauer wrote: > Do you mean from nvme_ioctl? or from blk_ioctl? It was removed from blk_ioctl > because I must have misinterpreted your comments here: > http://lists.infradead.org/pipermail/linux-nvme/2016-December/007364.html nvme_ioctl, aka the ioctl method of the block driver. In the future I expect another caller in scsi_ioctl or sd_ioctl. > I took your hesitation about the block_device to mean try something new, > that combined with my concern about having namespaces have the ability to > lock the global range which can span ourside their LBA ranges lead me to > remove it from block and put it in the char dev world. In the link I literally meant the struct block_device, not nessecarily the block device node. > > On the same note there is a public review of > TCG Storage Opal SSC Feature Set: Configurable Namespace Locking: > Which Jon Derrick found for us: > https://www.trustedcomputinggroup.org/wp-content/uploads/TCG_Storage_Feature_Set_Namespaces_phase_1b_v1_00_r1_19_public-review.pdf > > Where they are thinking about doing a complete 180 from: > https://www.trustedcomputinggroup.org/wp-content/uploads/TCG_SWG_SIIS_Version_1_05_Revision_1_00.pdf > > And now Namespaces can have their own global locking range as well as locking > objects within them. Interesting. From a quick look this is how it should have been done from the start. Now the big question is when devices are going to implement it, and how we can support both from the same driver, as this means we'll have to deal with two different ways to allocate the security context based on the device. And do the horrible mess that the TCG SIISs are there is absolute no way to discover this at the NVMe level, but we actually need to start doing TCG method calls to even figure out what's going on.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig) Subject: [PATCH v3 2/5] lib: Add Sed-opal library Date: Wed, 21 Dec 2016 01:42:38 -0800 [thread overview] Message-ID: <20161221094238.GC32084@infradead.org> (raw) In-Reply-To: <20161220215509.GA2462@sbauer-Z170X-UD5> On Tue, Dec 20, 2016@02:55:10PM -0700, Scott Bauer wrote: > Do you mean from nvme_ioctl? or from blk_ioctl? It was removed from blk_ioctl > because I must have misinterpreted your comments here: > http://lists.infradead.org/pipermail/linux-nvme/2016-December/007364.html nvme_ioctl, aka the ioctl method of the block driver. In the future I expect another caller in scsi_ioctl or sd_ioctl. > I took your hesitation about the block_device to mean try something new, > that combined with my concern about having namespaces have the ability to > lock the global range which can span ourside their LBA ranges lead me to > remove it from block and put it in the char dev world. In the link I literally meant the struct block_device, not nessecarily the block device node. > > On the same note there is a public review of > TCG Storage Opal SSC Feature Set: Configurable Namespace Locking: > Which Jon Derrick found for us: > https://www.trustedcomputinggroup.org/wp-content/uploads/TCG_Storage_Feature_Set_Namespaces_phase_1b_v1_00_r1_19_public-review.pdf > > Where they are thinking about doing a complete 180 from: > https://www.trustedcomputinggroup.org/wp-content/uploads/TCG_SWG_SIIS_Version_1_05_Revision_1_00.pdf > > And now Namespaces can have their own global locking range as well as locking > objects within them. Interesting. From a quick look this is how it should have been done from the start. Now the big question is when devices are going to implement it, and how we can support both from the same driver, as this means we'll have to deal with two different ways to allocate the security context based on the device. And do the horrible mess that the TCG SIISs are there is absolute no way to discover this at the NVMe level, but we actually need to start doing TCG method calls to even figure out what's going on.
next prev parent reply other threads:[~2016-12-21 9:42 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-19 19:35 [PATCH v3 0/5] SED OPAL Library Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 19:35 ` [PATCH v3 1/5] include: Add definitions for sed Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-20 6:46 ` Christoph Hellwig 2016-12-20 6:46 ` Christoph Hellwig 2016-12-25 14:15 ` Jethro Beekman 2016-12-25 14:15 ` Jethro Beekman 2016-12-27 22:14 ` Scott Bauer 2016-12-27 22:14 ` Scott Bauer 2016-12-19 19:35 ` [PATCH v3 2/5] lib: Add Sed-opal library Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 21:34 ` Keith Busch 2016-12-19 21:34 ` Keith Busch 2016-12-20 6:07 ` Christoph Hellwig 2016-12-20 6:07 ` Christoph Hellwig 2016-12-20 3:21 ` kbuild test robot 2016-12-20 3:21 ` kbuild test robot 2016-12-20 3:48 ` kbuild test robot 2016-12-20 3:48 ` kbuild test robot 2016-12-20 6:50 ` Al Viro 2016-12-20 6:50 ` Al Viro 2016-12-20 7:28 ` Christoph Hellwig 2016-12-20 7:28 ` Christoph Hellwig 2016-12-20 21:55 ` Scott Bauer 2016-12-20 21:55 ` Scott Bauer 2016-12-21 9:42 ` Christoph Hellwig [this message] 2016-12-21 9:42 ` Christoph Hellwig 2016-12-20 22:07 ` Jon Derrick 2016-12-20 22:07 ` Jon Derrick 2016-12-21 9:47 ` Christoph Hellwig 2016-12-21 9:47 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:21 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code Scott Bauer 2016-12-19 19:35 ` Scott Bauer 2016-12-19 21:59 ` Keith Busch 2016-12-19 21:59 ` Keith Busch 2016-12-19 22:23 ` Scott Bauer 2016-12-19 22:23 ` Scott Bauer 2016-12-20 6:17 ` Christoph Hellwig 2016-12-20 6:17 ` Christoph Hellwig 2016-12-20 15:49 ` Keith Busch 2016-12-20 15:49 ` Keith Busch 2016-12-20 15:46 ` Christoph Hellwig 2016-12-20 15:46 ` Christoph Hellwig 2016-12-20 16:05 ` Scott Bauer 2016-12-20 16:05 ` Scott Bauer 2016-12-21 9:01 ` Christoph Hellwig 2016-12-21 9:01 ` Christoph Hellwig 2016-12-20 17:52 ` Scott Bauer 2016-12-20 17:52 ` Scott Bauer 2016-12-21 9:37 ` Christoph Hellwig 2016-12-21 9:37 ` Christoph Hellwig 2016-12-20 4:11 ` kbuild test robot 2016-12-20 4:11 ` kbuild test robot 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:21 ` Christoph Hellwig 2016-12-20 6:49 ` Christoph Hellwig 2016-12-20 6:49 ` Christoph Hellwig 2016-12-25 14:15 ` Jethro Beekman 2016-12-25 14:15 ` Jethro Beekman 2016-12-27 22:12 ` Scott Bauer 2016-12-27 22:12 ` Scott Bauer 2016-12-28 8:39 ` Christoph Hellwig 2016-12-28 8:39 ` Christoph Hellwig 2016-12-19 19:35 ` [PATCH v3 5/5] Maintainers: Add Information for SED Opal library Scott Bauer 2016-12-19 19:35 ` Scott Bauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161221094238.GC32084@infradead.org \ --to=hch@infradead.org \ --cc=Rafael.Antognolli@intel.com \ --cc=axboe@fb.com \ --cc=jonathan.derrick@intel.com \ --cc=keith.busch@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ --cc=scott.bauer@intel.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.