From: Chris Wilson <chris@chris-wilson.co.uk>
To: changbin.du@intel.com
Cc: daniel.vetter@intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content
Date: Fri, 23 Dec 2016 07:51:21 +0000 [thread overview]
Message-ID: <20161223075121.GB14877@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161223054636.3924-1-changbin.du@intel.com>
On Fri, Dec 23, 2016 at 01:46:36PM +0800, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
>
> This patch fix a crash in function reset_common_ring. In this case,
> the port[0].request is null when reset the render ring, so a null
> dereference exception is raised. We need to check execlist_port status
> first.
No. The root cause is whatever got you into the illegal condition in the
first place.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: changbin.du@intel.com
Cc: daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: check if execlist_port is empty before using its content
Date: Fri, 23 Dec 2016 07:51:21 +0000 [thread overview]
Message-ID: <20161223075121.GB14877@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161223054636.3924-1-changbin.du@intel.com>
On Fri, Dec 23, 2016 at 01:46:36PM +0800, changbin.du@intel.com wrote:
> From: "Du, Changbin" <changbin.du@intel.com>
>
> This patch fix a crash in function reset_common_ring. In this case,
> the port[0].request is null when reset the render ring, so a null
> dereference exception is raised. We need to check execlist_port status
> first.
No. The root cause is whatever got you into the illegal condition in the
first place.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-23 7:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 5:46 [PATCH] drm/i915: check if execlist_port is empty before using its content changbin.du
2016-12-23 5:46 ` changbin.du
2016-12-23 6:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-12-23 7:04 ` [PATCH] " Jani Nikula
2016-12-23 7:04 ` Jani Nikula
2016-12-23 7:51 ` Chris Wilson [this message]
2016-12-23 7:51 ` [Intel-gfx] " Chris Wilson
2016-12-26 7:41 ` Du, Changbin
2016-12-26 7:41 ` Du, Changbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223075121.GB14877@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=changbin.du@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.