All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	davem@davemloft.net
Subject: Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks
Date: Mon, 9 Jan 2017 07:43:25 -0500	[thread overview]
Message-ID: <20170109124325.GB20973@hmswarspite.think-freely.org> (raw)
In-Reply-To: <cover.1483781759.git.lucien.xin@gmail.com>

On Sat, Jan 07, 2017 at 05:42:57PM +0800, Xin Long wrote:
> This patchset is to add some functions to generate stream reconf chunks,
> described in RFC6525 Section 3 and Section 4.
> 
> v1->v2:
>   - put these into a smaller group.
>   - rename some temporary variables in the codes.
>   - rename the titles of the commits and improve some changelogs.
> 
> Xin Long (5):
>   sctp: add a common helper function to generate stream reconf chunk
>   sctp: add support for generating stream reconf ssn reset request chunk
>   sctp: add support for generating stream reconf ssn/tsn reset request
>     chunk
>   sctp: add support for generating stream reconf response chunk
>   sctp: add support for generating stream reconf add streams request
>     chunk
> 
>  include/linux/sctp.h       |  68 ++++++++++++
>  include/net/sctp/sm.h      |  17 ++-
>  include/net/sctp/structs.h |   3 +
>  net/sctp/associola.c       |   1 +
>  net/sctp/sm_make_chunk.c   | 270 +++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 358 insertions(+), 1 deletion(-)
> 
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

These all look reasonably good, but it seems before we accept them,
there should be an additional patch that actually makes use of the code.
I presume that is forthcomming?

Neil

WARNING: multiple messages have this Message-ID (diff)
From: Neil Horman <nhorman@tuxdriver.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Vlad Yasevich <vyasevich@gmail.com>,
	davem@davemloft.net
Subject: Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks
Date: Mon, 09 Jan 2017 12:43:25 +0000	[thread overview]
Message-ID: <20170109124325.GB20973@hmswarspite.think-freely.org> (raw)
In-Reply-To: <cover.1483781759.git.lucien.xin@gmail.com>

On Sat, Jan 07, 2017 at 05:42:57PM +0800, Xin Long wrote:
> This patchset is to add some functions to generate stream reconf chunks,
> described in RFC6525 Section 3 and Section 4.
> 
> v1->v2:
>   - put these into a smaller group.
>   - rename some temporary variables in the codes.
>   - rename the titles of the commits and improve some changelogs.
> 
> Xin Long (5):
>   sctp: add a common helper function to generate stream reconf chunk
>   sctp: add support for generating stream reconf ssn reset request chunk
>   sctp: add support for generating stream reconf ssn/tsn reset request
>     chunk
>   sctp: add support for generating stream reconf response chunk
>   sctp: add support for generating stream reconf add streams request
>     chunk
> 
>  include/linux/sctp.h       |  68 ++++++++++++
>  include/net/sctp/sm.h      |  17 ++-
>  include/net/sctp/structs.h |   3 +
>  net/sctp/associola.c       |   1 +
>  net/sctp/sm_make_chunk.c   | 270 +++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 358 insertions(+), 1 deletion(-)
> 
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

These all look reasonably good, but it seems before we accept them,
there should be an additional patch that actually makes use of the code.
I presume that is forthcomming?

Neil


  parent reply	other threads:[~2017-01-09 12:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07  9:42 [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks Xin Long
2017-01-07  9:42 ` Xin Long
2017-01-07  9:42 ` [PATCHv2 net-next 1/5] sctp: add a common helper function to generate stream reconf chunk Xin Long
2017-01-07  9:42   ` Xin Long
2017-01-07  9:42   ` [PATCHv2 net-next 2/5] sctp: add support for generating stream reconf ssn reset request chunk Xin Long
2017-01-07  9:42     ` Xin Long
2017-01-07  9:43     ` [PATCHv2 net-next 3/5] sctp: add support for generating stream reconf ssn/tsn " Xin Long
2017-01-07  9:43       ` Xin Long
2017-01-07  9:43       ` [PATCHv2 net-next 4/5] sctp: add support for generating stream reconf response chunk Xin Long
2017-01-07  9:43         ` Xin Long
2017-01-07  9:43         ` [PATCHv2 net-next 5/5] sctp: add support for generating stream reconf add streams request chunk Xin Long
2017-01-07  9:43           ` Xin Long
2017-01-09 12:43 ` Neil Horman [this message]
2017-01-09 12:43   ` [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks Neil Horman
2017-01-09 15:53   ` David Miller
2017-01-09 15:53     ` David Miller
2017-01-09 18:27     ` Xin Long
2017-01-09 18:27       ` Xin Long
2017-01-09 18:53       ` David Miller
2017-01-09 18:53         ` David Miller
2017-01-09 19:04       ` Marcelo Ricardo Leitner
2017-01-09 19:04         ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109124325.GB20973@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.