From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
vyasevich@gmail.com
Subject: Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks
Date: Mon, 09 Jan 2017 10:53:01 -0500 (EST) [thread overview]
Message-ID: <20170109.105301.469495957021068521.davem@davemloft.net> (raw)
In-Reply-To: <20170109124325.GB20973@hmswarspite.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 9 Jan 2017 07:43:25 -0500
> These all look reasonably good, but it seems before we accept them,
> there should be an additional patch that actually makes use of the code.
> I presume that is forthcomming?
This all comes from my asking that the original huge set of patches be
split up.
People always just rush this kind of work and never think about laying
out the resubmission properly.
One should always only submit new interfaces along with an actual use
because only with a use can we properly review whether the new
interface is good or not.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com,
vyasevich@gmail.com
Subject: Re: [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks
Date: Mon, 09 Jan 2017 15:53:01 +0000 [thread overview]
Message-ID: <20170109.105301.469495957021068521.davem@davemloft.net> (raw)
In-Reply-To: <20170109124325.GB20973@hmswarspite.think-freely.org>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 9 Jan 2017 07:43:25 -0500
> These all look reasonably good, but it seems before we accept them,
> there should be an additional patch that actually makes use of the code.
> I presume that is forthcomming?
This all comes from my asking that the original huge set of patches be
split up.
People always just rush this kind of work and never think about laying
out the resubmission properly.
One should always only submit new interfaces along with an actual use
because only with a use can we properly review whether the new
interface is good or not.
next prev parent reply other threads:[~2017-01-09 15:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 9:42 [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks Xin Long
2017-01-07 9:42 ` Xin Long
2017-01-07 9:42 ` [PATCHv2 net-next 1/5] sctp: add a common helper function to generate stream reconf chunk Xin Long
2017-01-07 9:42 ` Xin Long
2017-01-07 9:42 ` [PATCHv2 net-next 2/5] sctp: add support for generating stream reconf ssn reset request chunk Xin Long
2017-01-07 9:42 ` Xin Long
2017-01-07 9:43 ` [PATCHv2 net-next 3/5] sctp: add support for generating stream reconf ssn/tsn " Xin Long
2017-01-07 9:43 ` Xin Long
2017-01-07 9:43 ` [PATCHv2 net-next 4/5] sctp: add support for generating stream reconf response chunk Xin Long
2017-01-07 9:43 ` Xin Long
2017-01-07 9:43 ` [PATCHv2 net-next 5/5] sctp: add support for generating stream reconf add streams request chunk Xin Long
2017-01-07 9:43 ` Xin Long
2017-01-09 12:43 ` [PATCHv2 net-next 0/5] sctp: add support for generating stream reconf chunks Neil Horman
2017-01-09 12:43 ` Neil Horman
2017-01-09 15:53 ` David Miller [this message]
2017-01-09 15:53 ` David Miller
2017-01-09 18:27 ` Xin Long
2017-01-09 18:27 ` Xin Long
2017-01-09 18:53 ` David Miller
2017-01-09 18:53 ` David Miller
2017-01-09 19:04 ` Marcelo Ricardo Leitner
2017-01-09 19:04 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109.105301.469495957021068521.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.